Re: [PR] Support load per-iteration replacement of NamedSPI [lucene]

2025-04-07 Thread via GitHub
github-actions[bot] commented on PR #14275: URL: https://github.com/apache/lucene/pull/14275#issuecomment-2784920720 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Clean up how the test framework creates asserting scorables. [lucene]

2025-04-07 Thread via GitHub
jainankitk commented on code in PR #14452: URL: https://github.com/apache/lucene/pull/14452#discussion_r2032123491 ## lucene/test-framework/src/java/org/apache/lucene/tests/search/AssertingScorer.java: ## @@ -80,8 +74,8 @@ boolean iterating() { @Override public void setM

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-04-07 Thread via GitHub
jainankitk commented on code in PR #14413: URL: https://github.com/apache/lucene/pull/14413#discussion_r2032049110 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfilerTimer.java: ## @@ -33,9 +33,21 @@ * */ class QueryProfilerTimer { - private boole

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-04-07 Thread via GitHub
jainankitk commented on code in PR #14413: URL: https://github.com/apache/lucene/pull/14413#discussion_r2032043915 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfilerBreakdown.java: ## @@ -17,46 +17,113 @@ package org.apache.lucene.sandbox.search; +imp

Re: [I] lucene.internal.vectorization.TestVectorScorer eats all available disk space [lucene]

2025-04-07 Thread via GitHub
rmuir closed issue #14446: lucene.internal.vectorization.TestVectorScorer eats all available disk space URL: https://github.com/apache/lucene/issues/14446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] tests: mark TestVectorScorer.testLarge() @Monster [lucene]

2025-04-07 Thread via GitHub
rmuir merged PR #14449: URL: https://github.com/apache/lucene/pull/14449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] Logic for collecting Histogram efficiently using Point Trees [lucene]

2025-04-07 Thread via GitHub
jainankitk commented on PR #14439: URL: https://github.com/apache/lucene/pull/14439#issuecomment-2784239065 @stefanvodita / @jpountz - Would love to get your thoughts on this optimization, and how we can leverage it in Lucene. In a nutshell, it solves the below problem: Given a sorte

Re: [PR] Tests: TestLongNormValueSource, AssertingScorable [lucene]

2025-04-07 Thread via GitHub
dsmiley commented on code in PR #14448: URL: https://github.com/apache/lucene/pull/14448#discussion_r2031794946 ## lucene/test-framework/src/java/org/apache/lucene/tests/search/AssertingScorable.java: ## @@ -44,7 +44,7 @@ public void setMinCompetitiveScore(float minScore) throws

Re: [PR] New IndexReaderFunctions.positionLength from the norm [lucene]

2025-04-07 Thread via GitHub
dsmiley commented on PR #14433: URL: https://github.com/apache/lucene/pull/14433#issuecomment-2784143694 Would it make sense in this PR to add a `Similarity.decodeNorm(long norm)` returning an int of the field position length? It feels like the right thing to add. -- This is an automate

Re: [I] lucene.internal.vectorization.TestVectorScorer eats all available disk space [lucene]

2025-04-07 Thread via GitHub
ChrisHegarty commented on issue #14446: URL: https://github.com/apache/lucene/issues/14446#issuecomment-2783573530 erk! this was me, I added this test quite a while ago and put the `@Nightly` anno on it. I'll update it to `@Monster`. -- This is an automated message from the Apache Git Ser

[PR] tests: mark TestVectorScorer.testLarge() @Monster [lucene]

2025-04-07 Thread via GitHub
rmuir opened a new pull request, #14449: URL: https://github.com/apache/lucene/pull/14449 This test requires gigabytes of disk space to run. Closes #14446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] Compute the doc range more efficiently when flushing doc block [lucene]

2025-04-07 Thread via GitHub
bugmakerr opened a new pull request, #14447: URL: https://github.com/apache/lucene/pull/14447 ### Description Today, we sum all the doc delta to compute the range when flushing doc block, which is equivalent to `lastDocID - level0LastDocID`. -- This is an automated message

[PR] Tests: TestLongNormValueSource, AssertingScorable [lucene]

2025-04-07 Thread via GitHub
dsmiley opened a new pull request, #14448: URL: https://github.com/apache/lucene/pull/14448 TestLongNormValueSource: test specifics AssertingScorable: don't wrap needlessly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[I] lucene.internal.vectorization.TestVectorScorer eats all available disk space [lucene]

2025-04-07 Thread via GitHub
rmuir opened a new issue, #14446: URL: https://github.com/apache/lucene/issues/14446 ### Description I hit `ENOSPC` while testing the release candidate: ``` java.io.IOException: No space left on device com.esotericsoftware.kryo.KryoException: java.io.IOException: No space left

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-04-07 Thread via GitHub
jpountz commented on code in PR #14413: URL: https://github.com/apache/lucene/pull/14413#discussion_r2031188700 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfilerBreakdown.java: ## @@ -17,46 +17,113 @@ package org.apache.lucene.sandbox.search; +import

Re: [I] Term Query is slower post Lucene 9.12 for fields with IndexOptions.DOCS [lucene]

2025-04-07 Thread via GitHub
jpountz commented on issue #14445: URL: https://github.com/apache/lucene/issues/14445#issuecomment-2783150457 > However, we would need to handle cases like [ExactPhraseMatcher which depend on the frequency of dummy impacts](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org

Re: [PR] Support incremental refresh in Searcher Managers. [lucene]

2025-04-07 Thread via GitHub
jpountz commented on PR #14443: URL: https://github.com/apache/lucene/pull/14443#issuecomment-2783139852 Thanks for tackling this! > To incrementally refresh through multiple commit points until searcher is current with its directory: > > [...] > Invoke maybeRefresh() or may