dsmiley commented on code in PR #14448: URL: https://github.com/apache/lucene/pull/14448#discussion_r2031794946
########## lucene/test-framework/src/java/org/apache/lucene/tests/search/AssertingScorable.java: ########## @@ -44,7 +44,7 @@ public void setMinCompetitiveScore(float minScore) throws IOException { } public static Scorable wrap(Scorable in) { - if (in instanceof AssertingScorable) { + if (in instanceof WrappedScorer || in instanceof AssertingScorable) { Review Comment: The comment below explains why a WrappedScorer is used sometimes. It doesn't make sense to have a WrappedScorer around a WrappedScorer (right?). I encountered this issue while running the other test in a debugger. So much wrapping! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org