jpountz commented on issue #14445: URL: https://github.com/apache/lucene/issues/14445#issuecomment-2783150457
> However, we would need to handle cases like [ExactPhraseMatcher which depend on the frequency of dummy impacts](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/ExactPhraseMatcher.java#L282-L284). I don't think you need to worry about this case, it's only possible when frequencies are enabled (Lucene doesn't allow indexing positions - required by phrase queries - without indexing term frequencies). The reason why `ExactPhraseMatcher` special-cases it is because this `Impact` is guaranteed to produce the highest possible score, and it's cheaper to ignore it than to handle it with the normal code path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
