dweiss commented on code in PR #14309:
URL: https://github.com/apache/lucene/pull/14309#discussion_r1974964208
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/TestRuleLimitSysouts.java:
##
@@ -207,6 +207,7 @@ protected void before() throws Throwable {
check
hanbj opened a new issue, #14313:
URL: https://github.com/apache/lucene/issues/14313
### Description
There are many implementations of MultiTermQuery, such as TermInSetQuery
FuzzyQuery、WildcardQuery、PrefixQuery、TermRangeQuery、RegexpQuery、TermsQuery、AutomatonQuery
Wait, so optimizing
reta commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1974531053
##
lucene/core/src/java/org/apache/lucene/index/StandardDirectoryReader.java:
##
@@ -476,7 +476,7 @@ protected void doClose() throws IOException {
}
reta commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1974531053
##
lucene/core/src/java/org/apache/lucene/index/StandardDirectoryReader.java:
##
@@ -476,7 +476,7 @@ protected void doClose() throws IOException {
}
rmuir merged PR #14308:
URL: https://github.com/apache/lucene/pull/14308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
jpountz commented on issue #14295:
URL: https://github.com/apache/lucene/issues/14295#issuecomment-2689221399
FWIW I recently updated this page with this new link
https://github.com/apache/lucene/pull/14251/files#diff-0a8bc8e8ffb40f26815f92ad02188c457ddd7594c4ac06208e8f5376ffed3cfbR213.
--
jpountz merged PR #14310:
URL: https://github.com/apache/lucene/pull/14310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz commented on PR #14312:
URL: https://github.com/apache/lucene/pull/14312#issuecomment-2689215958
cc @gf2121 who's been reviewing related PRs recently and @iverase for the
connection with sparse indexing
--
This is an automated message from the Apache Git Service.
To respond to the
jpountz opened a new pull request, #14312:
URL: https://github.com/apache/lucene/pull/14312
This is an attempt to resurrect #12194 in a (hopefully) better way. Now that
many queries run with `DenseConjunctionBulkScorer`, which scores windows of doc
IDs at a time, it becomes natural to skip
renatoh commented on PR #14311:
URL: https://github.com/apache/lucene/pull/14311#issuecomment-2689203083
@rmuir onlyLongestMatchNoSubwords is basically what was
onlyLongestMatch=true + reuseChars=false
--
This is an automated message from the Apache Git Service.
To respond to the message,
renatoh opened a new pull request, #14311:
URL: https://github.com/apache/lucene/pull/14311
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
madrob commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1974374898
##
lucene/CHANGES.txt:
##
@@ -45,7 +45,8 @@ Bug Fixes
Other
-
-(No changes)
+
+* GITHUB#9: Bump minimum required Java version to 23
Review
uschindler commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2689174826
We may now also remove SecurityManager and AccessController everywhere in
main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
uschindler commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2689172018
I will look into moving the MMapDirectory parts to the main code and only
leave the vector stuff in the APIJAR special case.
--
This is an automated message from the Apache Git Serv
rmuir commented on PR #14308:
URL: https://github.com/apache/lucene/pull/14308#issuecomment-2689170929
Thanks, the change is just a bit annoying from noise perspective. I will
merge up main first, to make sure there aren't any new lambdas in recent
commits that anger the check.
--
This
uschindler commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2689162858
I stopped the Jenkins builds on Policeman Jenkins and will check to update
the config for Java 23.
--
This is an automated message from the Apache Git Service.
To respond to the mes
uschindler commented on code in PR #14306:
URL: https://github.com/apache/lucene/pull/14306#discussion_r1974361308
##
lucene/core/src/java/org/apache/lucene/codecs/lucene101/Lucene101PostingsFormat.java:
##
@@ -351,6 +352,14 @@ public final class Lucene101PostingsFormat extends
jpountz commented on code in PR #14310:
URL: https://github.com/apache/lucene/pull/14310#discussion_r1974354077
##
lucene/core/src/java/org/apache/lucene/search/package-info.java:
##
@@ -350,6 +350,40 @@
*
*
*
+ * Multi-stage retrieval pipelines
+ *
+ * The above explains
jpountz closed pull request #14280: ExceptionInInitializerError in ScorerUtil
URL: https://github.com/apache/lucene/pull/14280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
rmuir commented on code in PR #14310:
URL: https://github.com/apache/lucene/pull/14310#discussion_r1974350732
##
lucene/core/src/java/org/apache/lucene/search/package-info.java:
##
@@ -350,6 +350,40 @@
*
*
*
+ * Multi-stage retrieval pipelines
+ *
+ * The above explains h
rmuir commented on code in PR #14310:
URL: https://github.com/apache/lucene/pull/14310#discussion_r1974340780
##
lucene/core/src/java/org/apache/lucene/search/package-info.java:
##
@@ -350,6 +350,40 @@
*
*
*
+ * Multi-stage retrieval pipelines
+ *
+ * The above explains h
jpountz commented on code in PR #14310:
URL: https://github.com/apache/lucene/pull/14310#discussion_r1974344510
##
lucene/core/src/java/org/apache/lucene/search/package-info.java:
##
@@ -350,6 +350,40 @@
*
*
*
+ * Multi-stage retrieval pipelines
+ *
+ * The above explains
jpountz commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2689123306
I merged my other PR, which should supersede this one. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
jpountz commented on PR #14304:
URL: https://github.com/apache/lucene/pull/14304#issuecomment-2689117193
Have you been able to run `luceneutil` to get a sense of the indexing and
search speedups?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
jpountz commented on PR #13470:
URL: https://github.com/apache/lucene/pull/13470#issuecomment-2689114469
> I have a bias for the latter, as I was planning on improving the docs of
the oal.search package as a follow-up to provide guidance wrt how to do hybrid
search by linking to this RRF he
jpountz closed issue #14283: Lack of coverage of DenseConjunctionBulkScorer
with min competitive scores and competitive iterators
URL: https://github.com/apache/lucene/issues/14283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jpountz merged PR #14293:
URL: https://github.com/apache/lucene/pull/14293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz merged PR #14189:
URL: https://github.com/apache/lucene/pull/14189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
madrob commented on code in PR #14309:
URL: https://github.com/apache/lucene/pull/14309#discussion_r1974288498
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/TestRuleLimitSysouts.java:
##
@@ -207,6 +207,7 @@ protected void before() throws Throwable {
check
jpountz merged PR #13470:
URL: https://github.com/apache/lucene/pull/13470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz merged PR #14039:
URL: https://github.com/apache/lucene/pull/14039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz closed issue #14283: Lack of coverage of DenseConjunctionBulkScorer
with min competitive scores and competitive iterators
URL: https://github.com/apache/lucene/issues/14283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jpountz commented on PR #14306:
URL: https://github.com/apache/lucene/pull/14306#issuecomment-2689030846
I went ahead and merged to step the stream of failures. Happy to revisit the
approach in a follow-up if there are concerns.
--
This is an automated message from the Apache Git Service.
jpountz merged PR #14306:
URL: https://github.com/apache/lucene/pull/14306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz closed issue #14303: TestScorerUtil.testLikelyImpactsEnum fails
URL: https://github.com/apache/lucene/issues/14303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
dweiss commented on issue #14307:
URL: https://github.com/apache/lucene/issues/14307#issuecomment-2688934137
This one is caused by a more complex interaction - LuceneTestCase tries to
set up a random TimeZone and this prints a warning like this:
```
WARNING: Use of the three-letter tim
renatoh commented on PR #14278:
URL: https://github.com/apache/lucene/pull/14278#issuecomment-2688845145
@rmuir could we reduce it to only two 'valid' behavior:
onlyLongestMatch=true with reuseChars=false and onlyLongestMatch=false with
reuseChars=true. if we think only these two cases mak
rmuir commented on PR #14278:
URL: https://github.com/apache/lucene/pull/14278#issuecomment-2688769041
@renatoh Feel free to open another PR, if you have time, to try to improve
defaults around this for the next version of lucene. If i ask for "longest
match" I don't expect to have addition
renatoh commented on PR #14278:
URL: https://github.com/apache/lucene/pull/14278#issuecomment-2688748464
> Thanks @renatoh !
thanks for your inputs and review it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
javanna closed issue #13791: Should we auto-adjust top score doc and top field
collector manager based on slices?
URL: https://github.com/apache/lucene/issues/13791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rmuir opened a new pull request, #14308:
URL: https://github.com/apache/lucene/pull/14308
After the upgrade to java 23, my editor is flooded with warnings of unused
variables from lambdas. Fix them.
I also downloaded eclipse, installed it, checked all possible compiler
options, compa
jpountz commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2688597916
This sounded like a good idea so I applied it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
javanna commented on issue #13791:
URL: https://github.com/apache/lucene/issues/13791#issuecomment-2688326822
I will go ahead and close this. The supportsConcurrency flag has been
removed. The collector manager no longer gives a choice and users don't have to
think about it either.
--
Th
epugh commented on PR #14194:
URL: https://github.com/apache/lucene/pull/14194#issuecomment-2688311636
@cpoerschke (and anyone else) I haven't done a commit on Lucene in a long
time so I want to get another set of eyes on this..And I need to remember
what all is in the workflow as well
uschindler commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2688112479
But this is fine. We currently only have shared secrets for tests.
Making that class public does not hurt.
--
This is an automated message from the Apache Git Service.
To respond
uschindler commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2688104449
This is better. But best would be to add a getter for the class in our
internal package (like we do for other stuff). The usual SharedSecrets approach.
--
This is an automated messa
jpountz commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2688043954
It looks like another problem with the current code is that codec
randomization may randomly run before this block of code, making it unreliable
when running tests. I opened #14306 as an
jpountz opened a new pull request, #14306:
URL: https://github.com/apache/lucene/pull/14306
This allows access from `ScorerUtil` so that it no longer needs a static
block that creates an index to be able to introspect what implementation is
used for impacts.
Closes #14303
--
This
jpountz commented on issue #14303:
URL: https://github.com/apache/lucene/issues/14303#issuecomment-2688040417
It looks like this is due to codec randomization getting applied before the
static block runs. I opened #14306.
--
This is an automated message from the Apache Git Service.
To res
dweiss commented on issue #14305:
URL: https://github.com/apache/lucene/issues/14305#issuecomment-2687815179
Example:
--
This is an automated message from the Apache Git Service.
To respon
dweiss opened a new issue, #14305:
URL: https://github.com/apache/lucene/issues/14305
### Description
Seems like they're expiring before the build is completed. Relevant links:
https://issues.apache.org/jira/browse/INFRA-26057
https://github.com/gradle/actions/blob/main/docs/set
ChrisHegarty commented on PR #14275:
URL: https://github.com/apache/lucene/pull/14275#issuecomment-2687787710
@jpountz given the connection of this PR with completion FST, do you have
opinions here?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
thecoop opened a new pull request, #14304:
URL: https://github.com/apache/lucene/pull/14304
This resolves #13922
JMH shows a ~5x speedup:
```
Benchmark Mode Cnt ScoreError Units
Quant.quantizethrpt5 231.147 ± 13.401 ops/ms
Quant.quanti
uschindler commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2687575659
Generally the issue here could be solved using this JEP which is long
awaited: https://openjdk.org/jeps/8209964
--
This is an automated message from the Apache Git Service.
To respo
ChrisHegarty commented on issue #14229:
URL: https://github.com/apache/lucene/issues/14229#issuecomment-2687571909
... we're on the train now. I repurposed this issue to track the upgrade to
Java 25.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
ChrisHegarty merged PR #14302:
URL: https://github.com/apache/lucene/pull/14302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
uschindler commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2687564614
I get crazy when I see this code (before and after). 😜
In general I would rewrite that in a different way to not use a test index
to initialize the code. Can't we figure out wha
ChrisHegarty commented on issue #14303:
URL: https://github.com/apache/lucene/issues/14303#issuecomment-2687502442
The test was introduced by #14294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ChrisHegarty opened a new issue, #14303:
URL: https://github.com/apache/lucene/issues/14303
### Description
```
Reproduce with: gradlew :lucene:core:test --tests \
"org.apache.lucene.search.TestScorerUtil.testLikelyImpactsEnum" \
-Ptests.jvms=1 \
-Ptests.jvmargs= \
-Ptes
ChrisHegarty commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2687487855
> The same test failed again, this time on windows.
>
> To me at a glance, this looks to be unrelated issue caused by #14294
ha! I had to merge main, since I didn't have
rmuir commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2687466537
The same test failed again, this time on windows.
To me at a glance, this looks to be unrelated issue caused by #14294
cc @jpountz
--
This is an automated message from th
rmuir commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2687423920
test failure on mac looked like a good ole flaky test to me, I re-reran.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
ChrisHegarty commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973227461
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refC
rmuir commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973219365
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refCount.de
rmuir commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973206235
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refCount.de
ChrisHegarty commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973205040
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refC
rmuir commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973201491
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refCount.de
dweiss commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973191532
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refCount.d
hanbj commented on PR #14301:
URL: https://github.com/apache/lucene/pull/14301#issuecomment-2687359672
Thank you for the review. Changes have been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dweiss commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973185969
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refCount.d
javanna commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1973180965
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,89 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits,
javanna commented on PR #14270:
URL: https://github.com/apache/lucene/pull/14270#issuecomment-2687334196
That's good with me. Shall we clearly document this then as a follow-up, and
shall I make the fst load mode static field package private perhaps, so that we
at least test both modes?
-
dweiss commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2687333543
All the way up to 3.40.0 in versions.toml:
```
ecj = "3.36.0"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ChrisHegarty commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2687333833
> ```
> > Task :lucene:core.tests:ecjLintMain FAILED
> source level should be in '1.1'...'1.8','9'...'21' (or '5.0'..'21.0'): 23
> ```
>
> ECJ is failing, perhaps it n
dweiss commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2687329916
```
> Task :lucene:core.tests:ecjLintMain FAILED
source level should be in '1.1'...'1.8','9'...'21' (or '5.0'..'21.0'): 23
```
ECJ is failing, perhaps it needs to be updated
ChrisHegarty commented on issue #14229:
URL: https://github.com/apache/lucene/issues/14229#issuecomment-2687327575
I opened [#14302](https://github.com/apache/lucene/pull/14302) for the
initial bump to Java 23.
--
This is an automated message from the Apache Git Service.
To respond to the
ChrisHegarty opened a new pull request, #14302:
URL: https://github.com/apache/lucene/pull/14302
This commit bumps minimum required Java version to 23.
The _main_ branch is accumulating changes for the next major release, Lucene
11.0.0. The intent is to release Lucene 11.0.0 with a mi
jpountz commented on PR #14293:
URL: https://github.com/apache/lucene/pull/14293#issuecomment-2687300793
Yes, especially with queries that match long ranges of doc IDs by design,
such as those that take advantage of sparse indexing.
> For reminding, I think we also need a CHANGES entr
jpountz commented on code in PR #14039:
URL: https://github.com/apache/lucene/pull/14039#discussion_r1973145270
##
lucene/core/src/java/org/apache/lucene/search/Weight.java:
##
@@ -289,75 +262,108 @@ static int scoreRange(
}
}
- int doc = iterator.docID();
jpountz commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2687278510
One concern I have with this change is that this code now runs as part of
evaluating a query, when users care about query latency.
@uschindler You usually have informed opinions on
ChrisHegarty closed issue #14184: Support JDK 24
URL: https://github.com/apache/lucene/issues/14184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issu
jpountz commented on code in PR #14293:
URL: https://github.com/apache/lucene/pull/14293#discussion_r1973122492
##
lucene/core/src/java/org/apache/lucene/search/TermQuery.java:
##
@@ -165,6 +165,17 @@ public Scorer get(long leadCost) throws IOException {
}
}
ChrisHegarty commented on issue #14184:
URL: https://github.com/apache/lucene/issues/14184#issuecomment-2687262361
The JDK 24 RC builds are tested with Lucene very frequently [1], and there
are no observable issues.
[1] https://jenkins.thetaphi.de/view/Lucene/job/Lucene-main-Linux/
jpountz commented on code in PR #14293:
URL: https://github.com/apache/lucene/pull/14293#discussion_r1973119540
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -341,11 +341,10 @@ public ScorerSupplier scorerSupplier(LeafReaderContext
context) throws
jpountz merged PR #14294:
URL: https://github.com/apache/lucene/pull/14294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
ChrisHegarty merged PR #14300:
URL: https://github.com/apache/lucene/pull/14300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
86 matches
Mail list logo
