rmuir commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973206235
##########
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##########
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refCount.decrementAndGet();
if (rc == 0) {
closed = true;
- try (Closeable finalizer = this::reportCloseToParentReaders;
- Closeable finalizer1 = this::notifyReaderClosedListeners) {
+ try (@SuppressWarnings("unused")
+ Closeable finalizer = this::reportCloseToParentReaders;
+ @SuppressWarnings("unused")
+ Closeable finalizer1 = this::notifyReaderClosedListeners) {
Review Comment:
Example of what i'm seeing. I can take care in a followup PR if it does not
fail build for now.
```
diff --git a/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
b/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
index a8eca64c962..0f7693eedd1 100644
--- a/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
+++ b/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
@@ -3333,7 +3333,7 @@ public class IndexWriter
infoStream.message("IW", "now abort pending addIndexes
merge");
}
merge.setAborted();
- merge.close(false, false, mr -> {});
+ merge.close(false, false, _ -> {});
onMergeFinished(merge);
});
pendingAddIndexesMerges.clear();
@@ -3350,7 +3350,7 @@ public class IndexWriter
handleMergeException(t, merge);
} finally {
synchronized (IndexWriter.this) {
- merge.close(success, false, mr -> {});
+ merge.close(success, false, _ -> {});
onMergeFinished(merge);
}
}
@@ -3731,7 +3731,7 @@ public class IndexWriter
// necessary files to disk and checkpointed them.
pointInTimeMerges =
preparePointInTimeMerge(
- toCommit, stopAddingMergedSegments::get,
MergeTrigger.COMMIT, sci -> {});
+ toCommit, stopAddingMergedSegments::get,
MergeTrigger.COMMIT, _ -> {});
}
}
success = true;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
