Re: [PR] Tighten up initialization of DisjunctionDISIApproximation [lucene]

2025-01-02 Thread via GitHub
gsmiller merged PR #14082: URL: https://github.com/apache/lucene/pull/14082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] Allow reading binary doc values as a RandomAccessInput [lucene]

2025-01-02 Thread via GitHub
github-actions[bot] commented on PR #13948: URL: https://github.com/apache/lucene/pull/13948#issuecomment-2568551704 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [I] VirtualMachineError: Out of space in CodeCache for adapters in gradle [lucene]

2025-01-02 Thread via GitHub
dweiss commented on issue #14090: URL: https://github.com/apache/lucene/issues/14090#issuecomment-2568364154 Applied to 10x and main. Closing this issue. We can tweak if we observe more anomalies. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [I] VirtualMachineError: Out of space in CodeCache for adapters in gradle [lucene]

2025-01-02 Thread via GitHub
dweiss closed issue #14090: VirtualMachineError: Out of space in CodeCache for adapters in gradle URL: https://github.com/apache/lucene/issues/14090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] VirtualMachineError: Out of space in CodeCache for adapters in gradle [lucene]

2025-01-02 Thread via GitHub
dweiss commented on issue #14090: URL: https://github.com/apache/lucene/issues/14090#issuecomment-2568361596 I've lowered it to 256 MB. I think it's going to be fine. Thanks for pointing out the ergonomics affect this setting, Rob. -- This is an automated message from the Apache Git Servi

Re: [PR] HNSW BP reordering [lucene]

2025-01-02 Thread via GitHub
msokolov commented on PR #14097: URL: https://github.com/apache/lucene/pull/14097#issuecomment-2568337179 One interesting detail that came out while testing with the merge policy is that indexing actually becomes *faster* with this change since the additional work we do in the BP reordering

Re: [PR] HNSW BP reordering [lucene]

2025-01-02 Thread via GitHub
msokolov commented on PR #14097: URL: https://github.com/apache/lucene/pull/14097#issuecomment-2568305787 note: addresses issue #13565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] HNSW BP reordering [lucene]

2025-01-02 Thread via GitHub
msokolov opened a new pull request, #14097: URL: https://github.com/apache/lucene/pull/14097 ### Description This is similar to the previous PR on the same issue, but the difference here is: 1. rebased on main (there was a 10.0 major release in between) 2. refactored to make

Re: [PR] Improve use of generics in DisjunctionMaxQuery construction [lucene]

2025-01-02 Thread via GitHub
ChrisHegarty commented on code in PR #14096: URL: https://github.com/apache/lucene/pull/14096#discussion_r1901082343 ## lucene/core/src/test/org/apache/lucene/search/TestDisjunctionMaxQuery.java: ## @@ -637,13 +637,27 @@ private void doTestRandomTopDocs(int numFields, double...

Re: [I] VirtualMachineError: Out of space in CodeCache for adapters in gradle [lucene]

2025-01-02 Thread via GitHub
dweiss commented on issue #14090: URL: https://github.com/apache/lucene/issues/14090#issuecomment-2568078503 Yep, good observation. For me, it's not the forced cpu count but the tiered-stop-at-level that causes this to decrease: ``` > java -XX:+PrintFlagsFinal -Xmx1g -XX:TieredStopAtLe

Re: [PR] Improve use of generics in DisjunctionMaxQuery construction [lucene]

2025-01-02 Thread via GitHub
ChrisHegarty commented on code in PR #14096: URL: https://github.com/apache/lucene/pull/14096#discussion_r1901063826 ## lucene/core/src/test/org/apache/lucene/search/TestDisjunctionMaxQuery.java: ## @@ -637,13 +637,27 @@ private void doTestRandomTopDocs(int numFields, double...

Re: [PR] Improve use of generics in DisjunctionMaxQuery construction [lucene]

2025-01-02 Thread via GitHub
ChrisHegarty commented on code in PR #14096: URL: https://github.com/apache/lucene/pull/14096#discussion_r1901063826 ## lucene/core/src/test/org/apache/lucene/search/TestDisjunctionMaxQuery.java: ## @@ -637,13 +637,27 @@ private void doTestRandomTopDocs(int numFields, double...

Re: [PR] Improve use of generics in DisjunctionMaxQuery construction [lucene]

2025-01-02 Thread via GitHub
dweiss commented on code in PR #14096: URL: https://github.com/apache/lucene/pull/14096#discussion_r1901062453 ## lucene/core/src/test/org/apache/lucene/search/TestDisjunctionMaxQuery.java: ## @@ -637,13 +637,27 @@ private void doTestRandomTopDocs(int numFields, double... freqs

Re: [I] VirtualMachineError: Out of space in CodeCache for adapters in gradle [lucene]

2025-01-02 Thread via GitHub
rmuir commented on issue #14090: URL: https://github.com/apache/lucene/issues/14090#issuecomment-2567935427 i havent looked at the defaults, but we probably give their crazy ergonomic algorithms trouble by telling it to use 1 cpu (which is really necessary to do the way we do parallel tests

Re: [I] VirtualMachineError: Out of space in CodeCache for adapters in gradle [lucene]

2025-01-02 Thread via GitHub
rmuir commented on issue #14090: URL: https://github.com/apache/lucene/issues/14090#issuecomment-2567926622 @dweiss thanks, I've been setting this one explicitly for java stuff at builds at work. Problem is that this setting has an ergonomic default, based on how much cpus/ram it se

[PR] Improve use of generics in DisjunctionMaxQuery construction [lucene]

2025-01-02 Thread via GitHub
ChrisHegarty opened a new pull request, #14096: URL: https://github.com/apache/lucene/pull/14096 This is a small usability improvement which allows construction of a DisjunctionMaxQuery to play nicer with type inference. Follows PECS. -- This is an automated message from the Apache Git Se

Re: [PR] Improve use of generics in DisjunctionDISIApproximation construction [lucene]

2025-01-02 Thread via GitHub
ChrisHegarty merged PR #14095: URL: https://github.com/apache/lucene/pull/14095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

[PR] Add a HNSW collector that exits early when nearest neighbor queue saturates [lucene]

2025-01-02 Thread via GitHub
tteofili opened a new pull request, #14094: URL: https://github.com/apache/lucene/pull/14094 This introduces a `HnswKnnCollector` interface, extending `KnnCollector` for HNSW, to make it possible to hook into HNSW execution for optimizations. It then adds a new collector which uses a satu