dweiss commented on code in PR #14096:
URL: https://github.com/apache/lucene/pull/14096#discussion_r1901062453
##########
lucene/core/src/test/org/apache/lucene/search/TestDisjunctionMaxQuery.java:
##########
@@ -637,13 +637,27 @@ private void doTestRandomTopDocs(int numFields, double...
freqs) throws IOExcept
dir.close();
}
+ // Non-functional. Compile only - to ensure generics and type inference play
nicely together
Review Comment:
I'd just use ```@Ignore("Compile only - to ensure generics and type
inference play nicely together") and then perhaps add some sinkhole for the
variables so that suppress warnings isn't needed; something like:
```
assertTrue(Arrays.asList(dmq1, disjuncts, dmq2).size() > 0)
```
Or whatever so that the variables are consumed somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
