dungba88 commented on issue #13699:
URL: https://github.com/apache/lucene/issues/13699#issuecomment-2319630418
I think system property might be prohibitive for configurability. This
parameter is a query-time control, but system property inherently enforce a
single value for the whole applic
Mikep86 commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1737286552
##
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##
@@ -275,6 +289,51 @@ public float matchCost() {
}
}
+ private static c
Mikep86 commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1737286552
##
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##
@@ -275,6 +289,51 @@ public float matchCost() {
}
}
+ private static c
msokolov commented on PR #13683:
URL: https://github.com/apache/lucene/pull/13683#issuecomment-2319154781
Well, I don't mind just leaving this on a branch/PR, but I didn't see a
better alternative; I talked about one other possibility in the comments above,
but this seemed the cleanest to m
Mikep86 commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1737282154
##
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##
@@ -440,6 +500,83 @@ private String formatScoreExplanation(int matches, int
star
msokolov commented on issue #13699:
URL: https://github.com/apache/lucene/issues/13699#issuecomment-2319141351
Do we have other internal API parameters via system property? I'm wondering
why you think that's preferable to adding Java functions?
--
This is an automated message from the Apa
dweiss commented on issue #13698:
URL: https://github.com/apache/lucene/issues/13698#issuecomment-2318946943
I filed a PR which passes CI tests. I have not been testing locally though -
it'd be good if you tried if everything works as expected before we merge this
in, @ChrisHegarty .
--
cbuescher opened a new pull request, #13701:
URL: https://github.com/apache/lucene/pull/13701
Neither this method nor any of the two overrides can throw an IOException.
This change removes the throws clauses from this method in order simplify not
have to handle them on the callers side.
-
jpountz commented on issue #13699:
URL: https://github.com/apache/lucene/issues/13699#issuecomment-2318859804
Lucene has tens of parameters like this one, exposing them all would make
our APIs look rather bad. I wonder how you envision users to tune this
parameter, would it be good enough i
jpountz commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1737087854
##
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##
@@ -275,6 +289,51 @@ public float matchCost() {
}
}
+ private static c
jpountz commented on PR #13683:
URL: https://github.com/apache/lucene/pull/13683#issuecomment-2318829477
> I'd like to get this tool merged
Some API changes are a bit annoying, e.g. the fact that `KnnVectorsReader`
now has an API that is specific to HNSW. I'm sorry as I know it makes
NavidMitchell commented on issue #3534:
URL: https://github.com/apache/lucene/issues/3534#issuecomment-2318584084
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
msokolov commented on PR #13683:
URL: https://github.com/apache/lucene/pull/13683#issuecomment-2318528961
Hmm, I realized that the clever casting trick I used in this version
(casting OffHeapHnswVectorValues to RandomAccessVectorValues.Floats) won't work
with the quantized vector values fla
dweiss closed issue #13676: Eclipse - one or more cycles were detected
URL: https://github.com/apache/lucene/issues/13676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
Mikep86 commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1736812026
##
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##
@@ -440,6 +500,83 @@ private String formatScoreExplanation(int matches, int
star
Mikep86 commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1736794565
##
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##
@@ -275,6 +289,51 @@ public float matchCost() {
}
}
+ private static c
dweiss commented on issue #13698:
URL: https://github.com/apache/lucene/issues/13698#issuecomment-2318115591
Ok, so one thing about the objects changing is that 'ext' now resolves to a
different property (a property on a different object) depending on the context.
I think I fixed this one.
dweiss commented on issue #13698:
URL: https://github.com/apache/lucene/issues/13698#issuecomment-2318015631
So... it's hell again. I can't explain it but objects stored in project.ext
during configuration phase seem to be dynamically changing. For example, we
store testOptions as an array
expani commented on PR #13521:
URL: https://github.com/apache/lucene/pull/13521#issuecomment-2317985648
Thanks for taking the time to review @msfroh and @mikemccand
I had enabled JVM Options to check what is going on with JIT C2 Compiler for
the different encoder variations.
dungba88 opened a new issue, #13699:
URL: https://github.com/apache/lucene/issues/13699
### Description
In Lucene 9.10, we introduced a new algorithm for sharing state between
segments to speed up the vector search process. This
[article](https://www.elastic.co/search-labs/blog/multi
jpountz commented on PR #13692:
URL: https://github.com/apache/lucene/pull/13692#issuecomment-2317837080
This is disappointing,
[`CountAndHighHigh`](https://benchmarks.mikemccandless.com/CountAndHighHigh.html)
did not see the same speedup that I saw. Some queries seem to have got a small
s
dweiss opened a new issue, #13698:
URL: https://github.com/apache/lucene/issues/13698
### Description
As in the title.
### Version and environment details
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
mikemccand commented on issue #13695:
URL: https://github.com/apache/lucene/issues/13695#issuecomment-2317305165
Thank you @uschindler!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
mikemccand commented on issue #13695:
URL: https://github.com/apache/lucene/issues/13695#issuecomment-2317304156
> > > after having a shower in my German bathroom
> >
> >
> > I'm sure all of us can't stop picturing this German bathroom, Uwe! :)
>
>
https://x.com/UweSays/sta
jpountz commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1735760199
##
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##
@@ -156,6 +161,15 @@ public Scorer get(long leadCost) throws IOException {
javanna commented on issue #12892:
URL: https://github.com/apache/lucene/issues/12892#issuecomment-2317085366
I edited the description of this issue to include an extensive list of the
leftover usages that need fixing.
--
This is an automated message from the Apache Git Service.
To respon
javanna merged PR #13602:
URL: https://github.com/apache/lucene/pull/13602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
27 matches
Mail list logo
