msokolov commented on PR #13683: URL: https://github.com/apache/lucene/pull/13683#issuecomment-2318528961
Hmm, I realized that the clever casting trick I used in this version (casting OffHeapHnswVectorValues to RandomAccessVectorValues.Floats) won't work with the quantized vector values flavors, and doing this cleanly will require moving to a first-class random access API. So I think it may be better to get this merged in more or less as is (I have some small tweaks for DOT_PRODUCT) and handle any such changes separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
