jpountz commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1737087854
##########
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##########
@@ -275,6 +289,51 @@ public float matchCost() {
}
}
+ private static class Score extends Scorable {
+ private final ScoreMode scoreMode;
+ private Float score;
Review Comment:
0 is a legal score (but negative values are not legal scores), but I'm
missing where we would need to assume that a matching doc cannot have a score
of zero?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
