Re: [I] Improve LongRange execution for ranges that have min value as Long.MIN_VALUE and max value as Long.MAX_VALUE or min as 0, and max as 2^64-1 [lucene]

2024-05-16 Thread via GitHub
timgrein commented on issue #13375: URL: https://github.com/apache/lucene/issues/13375#issuecomment-2116872792 > I suspect that existing benchmarks won't show needle moving results if they don't have enough queries that can be optimized through this opto. Yes, I'm gathering some specific

Re: [PR] Convert more classes to record classes [lucene]

2024-05-16 Thread via GitHub
github-actions[bot] commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2116414026 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [I] Improve LongRange execution for ranges that have min value as Long.MIN_VALUE and max value as Long.MAX_VALUE or min as 0, and max as 2^64-1 [lucene]

2024-05-16 Thread via GitHub
gautamworah96 commented on issue #13375: URL: https://github.com/apache/lucene/issues/13375#issuecomment-2116098631 > I can take a look at DoubleRange first and do so some benchmarking I suspect that existing benchmarks won't show needle moving results if they don't have enough queri

Re: [I] Multi range traversal for numeric range aggregations [lucene]

2024-05-16 Thread via GitHub
jainankitk commented on issue #13335: URL: https://github.com/apache/lucene/issues/13335#issuecomment-2115970672 @jpountz - Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] lucene-monitor: make TermFilteredPresearcher.ANYTOKEN[_FIELD] public [lucene]

2024-05-16 Thread via GitHub
cpoerschke opened a new pull request, #13379: URL: https://github.com/apache/lucene/pull/13379 This would allow applications -- e.g. @kotman12's https://github.com/apache/solr/pull/2382 -- to schematically validate the field w.r.t. existence and field type properties. A more complex

Re: [I] Improve LongRange execution for ranges that have min value as Long.MIN_VALUE and max value as Long.MAX_VALUE or min as 0, and max as 2^64-1 [lucene]

2024-05-16 Thread via GitHub
timgrein commented on issue #13375: URL: https://github.com/apache/lucene/issues/13375#issuecomment-2115615635 That sounds interesting, I can take a look at `DoubleRange` at first and do so some benchmarking, shouldn't be too hard to expand it then to the other data types. -- This is an

Re: [PR] Fix IntegerOverflow exception in postings encoding as group-varint [lucene]

2024-05-16 Thread via GitHub
easyice commented on PR #13376: URL: https://github.com/apache/lucene/pull/13376#issuecomment-2115450214 The essence of this issue is how to deal with the integer value with the sign bit as 1 (like this integer overflow case). We have two options. * The first is pass a negative long valu

Re: [PR] Fix bug in SQ when just a single vector present in a segment [lucene]

2024-05-16 Thread via GitHub
ChrisHegarty merged PR #13374: URL: https://github.com/apache/lucene/pull/13374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [I] Reproducible failure TestIndexWriterExceptions2.testBasics [lucene]

2024-05-16 Thread via GitHub
ChrisHegarty closed issue #13377: Reproducible failure TestIndexWriterExceptions2.testBasics URL: https://github.com/apache/lucene/issues/13377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Fix points writing with no values [lucene]

2024-05-16 Thread via GitHub
ChrisHegarty merged PR #13378: URL: https://github.com/apache/lucene/pull/13378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Fix points writing with no values [lucene]

2024-05-16 Thread via GitHub
ChrisHegarty commented on PR #13378: URL: https://github.com/apache/lucene/pull/13378#issuecomment-2115197055 > Thanks, the fix looks good to me. This makes me want to also improve the test from #13369 to add an `assertNull(onlyReader.getPointValues("field"));`, could you do it as part of t

[PR] Fix points writing with no values [lucene]

2024-05-16 Thread via GitHub
ChrisHegarty opened a new pull request, #13378: URL: https://github.com/apache/lucene/pull/13378 This commit updates the writer to handle the case where there are no values. Previously (before #13369), there was a check that there were some points values before trying to write, this i

Re: [I] Reproducible failure TestIndexWriterExceptions2.testBasics [lucene]

2024-05-16 Thread via GitHub
ChrisHegarty commented on issue #13377: URL: https://github.com/apache/lucene/issues/13377#issuecomment-2114841937 This test started failing as a result of #13369. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[I] Reproducible failure TestIndexWriterExceptions2.testBasics [lucene]

2024-05-16 Thread via GitHub
ChrisHegarty opened a new issue, #13377: URL: https://github.com/apache/lucene/issues/13377 ``` gradlew test --tests TestIndexWriterExceptions2.testBasics -Dtests.seed=8D4903C430CE15F -Dtests.asserts=true -Dtests.file.encoding=UTF-8 ``` ``` org.apache.lucene.index.TestInd

Re: [PR] Fix IntegerOverflow exception in postings encoding as group-varint [lucene]

2024-05-16 Thread via GitHub
easyice commented on PR #13376: URL: https://github.com/apache/lucene/pull/13376#issuecomment-2114744868 This change keeps the input values of `writeGroupVInts` explained as integer, instead of a big number greater than Integer.MAX_VALUE -- This is an automated message from the Apache Gi

[PR] Fix IntegerOverflow exception in postings encoding as group-varint [lucene]

2024-05-16 Thread via GitHub
easyice opened a new pull request, #13376: URL: https://github.com/apache/lucene/pull/13376 Closes: https://github.com/apache/lucene/issues/13373 This exception occurs because a negative integer value stores as positive long. In line 376, after a long value `<< 1`, if the sign bit

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-05-16 Thread via GitHub
Pulkitg64 commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1602894768 ## lucene/CHANGES.txt: ## @@ -102,6 +102,8 @@ API Changes Additionally, deprecated methods have been removed from ByteBuffersIndexInput, BooleanQuery and others.

Re: [I] DataOutput.writeGroupVInts throws IntegerOverflow exception during merging [lucene]

2024-05-16 Thread via GitHub
easyice commented on issue #13373: URL: https://github.com/apache/lucene/issues/13373#issuecomment-2114227500 Thank you @JervenBolleman , I have found the cause of the issue with @gf2121 , i will raise a PR later. -- This is an automated message from the Apache Git Service. To respo