Re: [PR] Do not use mock merge policy for TestSimilarity [lucene]

2024-04-17 Thread via GitHub
easyice merged PR #13314: URL: https://github.com/apache/lucene/pull/13314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Fix test failure TestKnnByteVectorQuery#testTimeLimitingKnnCollectorManager [lucene]

2024-04-17 Thread via GitHub
easyice merged PR #13312: URL: https://github.com/apache/lucene/pull/13312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Rename NodeHash to FSTSuffixNodeCache [lucene]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #13259: URL: https://github.com/apache/lucene/pull/13259#issuecomment-2062763499 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Add timeout support to AbstractKnnVectorQuery [lucene]

2024-04-17 Thread via GitHub
vigyasharma commented on PR #13202: URL: https://github.com/apache/lucene/pull/13202#issuecomment-2062496104 Backported to `branch_9x` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-17 Thread via GitHub
vigyasharma commented on PR #13283: URL: https://github.com/apache/lucene/pull/13283#issuecomment-2062495992 Backported to `branch_9x` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Backport #13202 to branch_9x [lucene]

2024-04-17 Thread via GitHub
vigyasharma commented on PR #13295: URL: https://github.com/apache/lucene/pull/13295#issuecomment-2062493037 Backported changes directly to retain original commit messages. This PR would've needed a squash merge as it was not rebased on the latest branch_9x commit. -- This is an automate

Re: [PR] Backport #13202 to branch_9x [lucene]

2024-04-17 Thread via GitHub
vigyasharma closed pull request #13295: Backport #13202 to branch_9x URL: https://github.com/apache/lucene/pull/13295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-17 Thread via GitHub
jpountz commented on PR #13308: URL: https://github.com/apache/lucene/pull/13308#issuecomment-2062265590 > Oh okay, that means we need to remove support for COSINE just from indexing side not from searching side? Correct. Practically, this means keeping the enum constant but marking i

Re: [I] [RFC] Improve skipping logic for after values in sort query [lucene]

2024-04-17 Thread via GitHub
jpountz commented on issue #13313: URL: https://github.com/apache/lucene/issues/13313#issuecomment-2062229941 FWIW there is a similar problem for sorting by score, as document scores may be clustered in the doc ID space, which increases the time for the minimum competitite score to converge

Re: [I] Lucene index modeling - Why are skiplists used instead of B+ Tree? [lucene]

2024-04-17 Thread via GitHub
jpountz closed issue #13309: Lucene index modeling - Why are skiplists used instead of B+ Tree? URL: https://github.com/apache/lucene/issues/13309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [RFC] Improve skipping logic for after values in sort query [lucene]

2024-04-17 Thread via GitHub
jpountz commented on issue #13313: URL: https://github.com/apache/lucene/issues/13313#issuecomment-2062170216 > Lets invoke skipping logic in case topValue is known but bottomvalue is unknown ir-respective of number of docuements we are able to skip. That will be one time invocation of skip

[I] Investigate indexing slowdown on NYC taxis on 2024-01-18 [lucene]

2024-04-17 Thread via GitHub
jpountz opened a new issue, #13317: URL: https://github.com/apache/lucene/issues/13317 ### Description I was looking at the [NYC taxis benchmarks](https://home.apache.org/~mikemccand/lucenebench/sparseResults.html#index_throughput), where we saw a significant indexing rate regression

Re: [PR] Use jdk11 primitives to allow backport to branch_9x [lucene]

2024-04-17 Thread via GitHub
benwtrent commented on code in PR #13311: URL: https://github.com/apache/lucene/pull/13311#discussion_r1569381543 ## lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java: ## @@ -781,7 +781,7 @@ public void testTimeLimitingKnnCollectorManager() throws IO

Re: [PR] Use jdk11 primitives to allow backport to branch_9x [lucene]

2024-04-17 Thread via GitHub
vigyasharma commented on code in PR #13311: URL: https://github.com/apache/lucene/pull/13311#discussion_r1569337501 ## lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java: ## @@ -781,7 +781,7 @@ public void testTimeLimitingKnnCollectorManager() throws

Re: [PR] Align toString methods in geo module [lucene]

2024-04-17 Thread via GitHub
slow-J commented on code in PR #13302: URL: https://github.com/apache/lucene/pull/13302#discussion_r1569215690 ## lucene/core/src/java/org/apache/lucene/geo/XYPolygon.java: ## @@ -187,6 +187,7 @@ public boolean equals(Object obj) { @Override public String toString() {

Re: [PR] Add new pluggable vector similarity to field info [lucene]

2024-04-17 Thread via GitHub
benwtrent commented on PR #13200: URL: https://github.com/apache/lucene/pull/13200#issuecomment-2061818544 usurped by: https://github.com/apache/lucene/pull/13288 closing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add new pluggable vector similarity to field info [lucene]

2024-04-17 Thread via GitHub
benwtrent closed pull request #13200: Add new pluggable vector similarity to field info URL: https://github.com/apache/lucene/pull/13200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add BitVectors format and make flat vectors format easier to extend [lucene]

2024-04-17 Thread via GitHub
benwtrent merged PR #13288: URL: https://github.com/apache/lucene/pull/13288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[PR] Fix IndexOutOfBoundsException thrown in DefaultPassageFormatter by unordered matches [lucene]

2024-04-17 Thread via GitHub
scampi opened a new pull request, #13315: URL: https://github.com/apache/lucene/pull/13315 - **test: add unit tests to reproduce the IndexOutOfBoundsException in DefaultPassageFormatter** - **doc: clarify javadoc of MatchesIterator** - **fix: sort passages by offset if positions are mi

Re: [PR] Remove unnecessary `AbstractKnnVectorQuery.exactSearch()` [lucene]

2024-04-17 Thread via GitHub
benwtrent commented on PR #13143: URL: https://github.com/apache/lucene/pull/13143#issuecomment-2061143742 I agree, I think it can be closed. We will still need the `exactSearch` method, even with refactorings that make it play well with quantization. -- This is an automated message from

Re: [PR] Use jdk11 primitives to allow backport to branch_9x [lucene]

2024-04-17 Thread via GitHub
benwtrent commented on code in PR #13311: URL: https://github.com/apache/lucene/pull/13311#discussion_r1568758563 ## lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java: ## @@ -781,7 +781,7 @@ public void testTimeLimitingKnnCollectorManager() throws IO

Re: [PR] Fix test failure TestKnnByteVectorQuery#testTimeLimitingKnnCollectorManager [lucene]

2024-04-17 Thread via GitHub
easyice commented on code in PR #13312: URL: https://github.com/apache/lucene/pull/13312#discussion_r1568742254 ## lucene/core/src/java/org/apache/lucene/search/TimeLimitingKnnCollectorManager.java: ## @@ -42,54 +42,62 @@ public KnnCollector newCollector(int visitedLimit, LeafR

Re: [PR] Fix test failure TestKnnByteVectorQuery#testTimeLimitingKnnCollectorManager [lucene]

2024-04-17 Thread via GitHub
kaivalnp commented on code in PR #13312: URL: https://github.com/apache/lucene/pull/13312#discussion_r1568720556 ## lucene/core/src/java/org/apache/lucene/search/TimeLimitingKnnCollectorManager.java: ## @@ -42,54 +42,62 @@ public KnnCollector newCollector(int visitedLimit, Leaf

Re: [PR] Fix test failure TestKnnByteVectorQuery#testTimeLimitingKnnCollectorManager [lucene]

2024-04-17 Thread via GitHub
easyice commented on code in PR #13312: URL: https://github.com/apache/lucene/pull/13312#discussion_r1568402988 ## lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java: ## @@ -784,7 +785,9 @@ public void testTimeLimitingKnnCollectorManager() throws IOEx

Re: [I] [RFC] Improve skipping logic for after values in sort query [lucene]

2024-04-17 Thread via GitHub
gashutos commented on issue #13313: URL: https://github.com/apache/lucene/issues/13313#issuecomment-2060591506 @jpountz @gsmiller what you guys think on this ? let me know if you need sample code change for this -- This is an automated message from the Apache Git Service. To respond

[I] [RFC] Improve skipping logic for after values in sort query [lucene]

2024-04-17 Thread via GitHub
gashutos opened a new issue, #13313: URL: https://github.com/apache/lucene/issues/13313 ### Description ### Background Lucene sort queries are using skipping logic for faster execution and skip non-competitive documents by updating its competitive iterator whenever it updates its

Re: [PR] Change MASKS from int[] to byte[], and assign it with left shift in UTF32ToUTF8 [lucene]

2024-04-17 Thread via GitHub
vsop-479 commented on PR #13310: URL: https://github.com/apache/lucene/pull/13310#issuecomment-2060577752 @mikemccand Please take a look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Fix test failure TestKnnByteVectorQuery#testTimeLimitingKnnCollectorManager [lucene]

2024-04-17 Thread via GitHub
dweiss commented on code in PR #13312: URL: https://github.com/apache/lucene/pull/13312#discussion_r1568342142 ## lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java: ## @@ -784,7 +785,9 @@ public void testTimeLimitingKnnCollectorManager() throws IOExc