benwtrent commented on code in PR #13311:
URL: https://github.com/apache/lucene/pull/13311#discussion_r1568758563
##########
lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java:
##########
@@ -781,7 +781,7 @@ public void testTimeLimitingKnnCollectorManager() throws
IOException {
TimeLimitingKnnCollectorManager noTimeoutManager =
new TimeLimitingKnnCollectorManager(delegate, null);
KnnCollector noTimeoutCollector =
- noTimeoutManager.newCollector(Integer.MAX_VALUE,
searcher.leafContexts.getFirst());
+ noTimeoutManager.newCollector(Integer.MAX_VALUE,
searcher.leafContexts.get(0));
Review Comment:
This doesn't really make sense to me :/. Main requires JDK21 and using all
the nice things 21 provides is, well, nice.
Its pretty common for backports to have one or more weird issues due to
compilation levels. The biggest one I have seen is `if (klass instanceof
ClassFoo classFoo)` or the new `switch` statement syntax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
