easyice commented on code in PR #13312:
URL: https://github.com/apache/lucene/pull/13312#discussion_r1568402988


##########
lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java:
##########
@@ -784,7 +785,9 @@ public void testTimeLimitingKnnCollectorManager() throws 
IOException {
           noTimeoutManager.newCollector(Integer.MAX_VALUE, 
searcher.leafContexts.getFirst());
 
       // Check that a normal collector is created without timeout
-      assertTrue(noTimeoutCollector instanceof TopKnnCollector);
+      assertTrue(

Review Comment:
   Thanks for you suggestions! you are right, I like the idea!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to