vigyasharma merged PR #13283:
URL: https://github.com/apache/lucene/pull/13283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
vigyasharma closed issue #13272: TestKnnByteVectorQuery.testTimeout fails
URL: https://github.com/apache/lucene/issues/13272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
easyice opened a new issue, #13292:
URL: https://github.com/apache/lucene/issues/13292
### Description
This failure is because when comparing float values using the `==`
operation, `-0.0` is equal to `0.0`, but their hashcode is different. should we
use `Float.compare` or `Float.floa
vsop-479 commented on PR #13291:
URL: https://github.com/apache/lucene/pull/13291#issuecomment-2048830987
@mikemccand
Please take a look when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
vsop-479 opened a new pull request, #13291:
URL: https://github.com/apache/lucene/pull/13291
### Description
It seems `tmpLen` is only used after scanning done, We could remove
unnecessary calculating for `termLen` in
`SegmentTermsEnumFrame.scanToTermNonLeaf`'s loop.
--
This is an
rmuir commented on PR #13277:
URL: https://github.com/apache/lucene/pull/13277#issuecomment-2048667001
I've been mulling over this PR for a while, not the type of one you want to
rush in. But the more I think about it, the more I like it.
* javadocs for Error describe them as `abnorma
github-actions[bot] commented on PR #13201:
URL: https://github.com/apache/lucene/pull/13201#issuecomment-2048636803
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
jimczi commented on code in PR #13288:
URL: https://github.com/apache/lucene/pull/13288#discussion_r1560095226
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsWriter.java:
##
@@ -71,7 +72,9 @@ public final class Lucene99FlatVectorsWriter extends
Fla
mayya-sharipova commented on code in PR #13268:
URL: https://github.com/apache/lucene/pull/13268#discussion_r1559895242
##
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java:
##
@@ -360,6 +366,22 @@ public Builder withFieldMatcher(Predicate v
ChrisHegarty commented on code in PR #13288:
URL: https://github.com/apache/lucene/pull/13288#discussion_r1559885835
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/word2vec/Word2VecModel.java:
##
@@ -29,7 +29,7 @@
*
* @lucene.experimental
*/
-public
benwtrent commented on code in PR #13288:
URL: https://github.com/apache/lucene/pull/13288#discussion_r1559873050
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/codecs/bitvectors/HnswBitVectorsFormat.java:
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Founda
benwtrent commented on code in PR #13288:
URL: https://github.com/apache/lucene/pull/13288#discussion_r1559871922
##
lucene/core/src/java/org/apache/lucene/codecs/lucene95/OffHeapFloatVectorValues.java:
##
@@ -79,7 +84,7 @@ public static OffHeapFloatVectorValues load(
ret
benwtrent commented on code in PR #13288:
URL: https://github.com/apache/lucene/pull/13288#discussion_r1559871450
##
lucene/core/src/java/org/apache/lucene/codecs/FlatVectorsScorer.java:
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
cpoerschke opened a new pull request, #13290:
URL: https://github.com/apache/lucene/pull/13290
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jpountz commented on code in PR #13288:
URL: https://github.com/apache/lucene/pull/13288#discussion_r1559759260
##
lucene/core/src/java/org/apache/lucene/codecs/lucene95/OffHeapFloatVectorValues.java:
##
@@ -79,7 +84,7 @@ public static OffHeapFloatVectorValues load(
retur
jpountz commented on code in PR #13286:
URL: https://github.com/apache/lucene/pull/13286#discussion_r1559754236
##
lucene/CHANGES.txt:
##
@@ -98,6 +98,9 @@ API Changes
* GITHUB#13241: Remove Accountable interface on KnnVectorsReader. (Pulkit
Gupta)
+* GITHUB#13262: Remove
benwtrent commented on PR #13200:
URL: https://github.com/apache/lucene/pull/13200#issuecomment-2047653894
So, I took another take on this in:
https://github.com/apache/lucene/pull/13288
The main idea here is that instead of adding another pluggable thing, we
rely on formats & custom
jimczi commented on code in PR #13268:
URL: https://github.com/apache/lucene/pull/13268#discussion_r1559420851
##
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java:
##
@@ -360,6 +366,22 @@ public Builder withFieldMatcher(Predicate value) {
iamsanjay commented on PR #13286:
URL: https://github.com/apache/lucene/pull/13286#issuecomment-2047290711
I added MIGRATE docs. Let me know if that's not required.
There is one more class pending `SortField`. I am still looking into some of
the test cases that are failing , we may have t
stefanvodita commented on PR #13198:
URL: https://github.com/apache/lucene/pull/13198#issuecomment-2047250772
Thank you for persisting @iamsanjay! I spend a bit of time on this and
noticed two bugs, which should be fixed by #13287. Feel free to add the changes
to your PR. I can still get so
cpoerschke commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2047245790
> ... Of course another solution would be to simply make these functions
public, but I understand the desire to avoid that if possible.
Again, I'm not really familiar with this
gf2121 merged PR #13246:
URL: https://github.com/apache/lucene/pull/13246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
jpountz commented on PR #13286:
URL: https://github.com/apache/lucene/pull/13286#issuecomment-2046894099
@iamsanjay Yes please go ahead. All these problems should be easy to address
by these various projects. Thanks for checking!
--
This is an automated message from the Apache Git Service
iamsanjay commented on PR #13286:
URL: https://github.com/apache/lucene/pull/13286#issuecomment-2046812811
I looked into different Search engines whether they use it or not -- Many
of them still using the deprecated code.
1. `LongPoint.newDistanceFeatureQuery` (ElasticSearch uses it
htt
jpountz commented on PR #13286:
URL: https://github.com/apache/lucene/pull/13286#issuecomment-2046689556
Thanks for looking into this. I think I'd rather keep `VH_BE_DOUBLE` for now
for consistency, since we're also keeping the INT, LONG and FLOAT BE variants.
- In addition to IntFie
jpountz commented on PR #12996:
URL: https://github.com/apache/lucene/pull/12996#issuecomment-2046679510
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
26 matches
Mail list logo
