cpoerschke commented on PR #13109: URL: https://github.com/apache/lucene/pull/13109#issuecomment-2047245790
> ... Of course another solution would be to simply make these functions public, but I understand the desire to avoid that if possible. Again, I'm not really familiar with this area of the code but would be curious what making the functions public would look like and if making them public is necessarily problematic. And echo-ing @mkhludnev's https://github.com/apache/solr/pull/2315#issuecomment-1968545878 comment w.r.t. just-compile test to retain extensibility in future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
