easyice opened a new issue, #13292:
URL: https://github.com/apache/lucene/issues/13292
### Description
This failure is because when comparing float values using the `==`
operation, `-0.0` is equal to `0.0`, but their hashcode is different. should we
use `Float.compare` or `Float.floatToRawIntBits` instead of `==` for the
compare? it seems to do this change also in `XYPoint#equals` like:
```diff
- return point.x == x && point.y == y;
+ return Float.compare(point.x, x) == 0 && Float.compare(point.y, y) == 0;
```
```
> java.lang.AssertionError: expected:<2139095030> but was:<-8388618>
> at
__randomizedtesting.SeedInfo.seed([3ABEFE4D876DD310:4970068084C8AC21]:0)
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.failNotEquals(Assert.java:835)
> at org.junit.Assert.assertEquals(Assert.java:647)
> at org.junit.Assert.assertEquals(Assert.java:633)
> at
org.apache.lucene.geo.TestXYPoint.testEqualsAndHashCode(TestXYPoint.java:95)
> at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
```
A similar issue exists in `TestXYRectangle#testEqualsAndHashCode`,
`TestXYCircle#testEqualsAndHashCode`
### Gradle command to reproduce
```
./gradlew test --tests TestXYPoint.testEqualsAndHashCode
-Dtests.seed=3ABEFE4D876DD310 -Dtests.nightly=true -Dtests.locale=es-419
-Dtests.timezone=Asia/Ulaanbaatar -Dtests.asserts=true
-Dtests.file.encoding=UTF-8
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
