jpountz commented on code in PR #13232:
URL: https://github.com/apache/lucene/pull/13232#discussion_r1544135442
##
lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java:
##
@@ -566,10 +566,20 @@ public String toString() {
/** A {@link Reader} which has all its va
jpountz merged PR #13224:
URL: https://github.com/apache/lucene/pull/13224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
vsop-479 commented on code in PR #11888:
URL: https://github.com/apache/lucene/pull/11888#discussion_r1543957681
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##
@@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef targ
vsop-479 commented on code in PR #11888:
URL: https://github.com/apache/lucene/pull/11888#discussion_r1543957681
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##
@@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef targ
vsop-479 commented on code in PR #13192:
URL: https://github.com/apache/lucene/pull/13192#discussion_r1543119650
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##
@@ -196,6 +207,90 @@ void loadBlock() throws IOException {
suf
rmuir opened a new issue, #13240:
URL: https://github.com/apache/lucene/issues/13240
### Description
While working on #13239, I did find another pre-existing condition with
`gradlew regenerate` besides the groovy version not being able to read java 21
.class files.
I think it
github-actions[bot] commented on PR #12966:
URL: https://github.com/apache/lucene/pull/12966#issuecomment-2026362752
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #13142:
URL: https://github.com/apache/lucene/pull/13142#issuecomment-2026362655
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
azagniotov commented on PR #12517:
URL: https://github.com/apache/lucene/pull/12517#issuecomment-2026358207
@mocobeta thank you. I have not done any benchmarks, thus, I cannot comment
on potential performance implications. One thing that probably be certain that
a larger dictionary will req
dweiss commented on issue #12907:
URL: https://github.com/apache/lucene/issues/12907#issuecomment-2026287480
Looks like this shouldn't be an issue anymore, yay.
https://issues.apache.org/jira/browse/INFRA-25269
--
This is an automated message from the Apache Git Service.
To respond to t
rmuir merged PR #13233:
URL: https://github.com/apache/lucene/pull/13233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
zacharymorn commented on issue #13218:
URL: https://github.com/apache/lucene/issues/13218#issuecomment-2026243782
Thanks @mikemccand for catching this! I've opened a PR to add it
https://github.com/apache/lucene/pull/13238
--
This is an automated message from the Apache Git Service.
To r
zacharymorn opened a new pull request, #13238:
URL: https://github.com/apache/lucene/pull/13238
This is a PR to add migration entry for `Collector` to `CollectorManager`
migration for `IndexSearch#search`.
Thanks @mikemccand for the suggestions on entry content!
Note: I have s
original-brownbear commented on code in PR #13232:
URL: https://github.com/apache/lucene/pull/13232#discussion_r1543755288
##
lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java:
##
@@ -566,10 +566,20 @@ public String toString() {
/** A {@link Reader} which has
original-brownbear commented on code in PR #13232:
URL: https://github.com/apache/lucene/pull/13232#discussion_r1543739530
##
lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java:
##
@@ -566,10 +566,20 @@ public String toString() {
/** A {@link Reader} which has
original-brownbear commented on PR #13232:
URL: https://github.com/apache/lucene/pull/13232#issuecomment-2026126418
Thanks for taking a look Adrien!
> Can you add a CHANGES entry?
Done :) Hope 9.11.0 was correct?
--
This is an automated message from the Apache Git Service.
T
original-brownbear commented on code in PR #13232:
URL: https://github.com/apache/lucene/pull/13232#discussion_r1543715181
##
lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java:
##
@@ -566,10 +566,20 @@ public String toString() {
/** A {@link Reader} which has
original-brownbear commented on code in PR #13224:
URL: https://github.com/apache/lucene/pull/13224#discussion_r1543661219
##
lucene/CHANGES.txt:
##
@@ -249,6 +249,8 @@ Optimizations
* GITHUB#13203: Speed up writeGroupVInts (Zhang Chao)
+* GITHUB#13224: Use singleton for si
benwtrent opened a new pull request, #13237:
URL: https://github.com/apache/lucene/pull/13237
Both the KnnWriters & FieldInfo keep track of the vector similarity used by
a given field. This commit ensures they are the same and utilizes the FieldInfo
one (which, while these are enums, are ex
jpountz commented on code in PR #13232:
URL: https://github.com/apache/lucene/pull/13232#discussion_r1543624600
##
lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java:
##
@@ -566,10 +566,20 @@ public String toString() {
/** A {@link Reader} which has all its va
rmuir merged PR #13231:
URL: https://github.com/apache/lucene/pull/13231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir merged PR #13230:
URL: https://github.com/apache/lucene/pull/13230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
jpountz commented on PR #13229:
URL: https://github.com/apache/lucene/pull/13229#issuecomment-2026074854
> I'm looking into a (separate) change that renames it to WRITE and enforces
that it's never used for reading.
I opened #13236.
--
This is an automated message from the Apache G
jpountz opened a new pull request, #13236:
URL: https://github.com/apache/lucene/pull/13236
This effectively removes the `DEFAULT` `IOContext` and forces callers to use
the existing `IOContext.READ` context or the new `IOContext.WRITE` context
instead.
This comes with some interestin
original-brownbear commented on code in PR #13224:
URL: https://github.com/apache/lucene/pull/13224#discussion_r1543613500
##
lucene/core/src/test/org/apache/lucene/util/packed/TestDirectMonotonic.java:
##
@@ -154,6 +154,43 @@ public void testConstantSlope() throws IOException {
jpountz commented on code in PR #13224:
URL: https://github.com/apache/lucene/pull/13224#discussion_r1543614960
##
lucene/CHANGES.txt:
##
@@ -249,6 +249,8 @@ Optimizations
* GITHUB#13203: Speed up writeGroupVInts (Zhang Chao)
+* GITHUB#13224: Use singleton for single block,
original-brownbear commented on code in PR #13224:
URL: https://github.com/apache/lucene/pull/13224#discussion_r1543613500
##
lucene/core/src/test/org/apache/lucene/util/packed/TestDirectMonotonic.java:
##
@@ -154,6 +154,43 @@ public void testConstantSlope() throws IOException {
jpountz commented on code in PR #13224:
URL: https://github.com/apache/lucene/pull/13224#discussion_r1543603529
##
lucene/core/src/test/org/apache/lucene/util/packed/TestDirectMonotonic.java:
##
@@ -154,6 +154,43 @@ public void testConstantSlope() throws IOException {
dir.c
jpountz commented on code in PR #13224:
URL: https://github.com/apache/lucene/pull/13224#discussion_r1543602422
##
lucene/core/src/test/org/apache/lucene/util/packed/TestDirectMonotonic.java:
##
@@ -154,6 +154,43 @@ public void testConstantSlope() throws IOException {
dir.c
original-brownbear commented on PR #13224:
URL: https://github.com/apache/lucene/pull/13224#issuecomment-2026021732
@jpountz I did my best:
[478f6c3](https://github.com/apache/lucene/pull/13224/commits/478f6c3006e6abc43ac939507be8ce46207e40ec)
hope I got this right, I could only really get
benwtrent commented on PR #13235:
URL: https://github.com/apache/lucene/pull/13235#issuecomment-2025931282
@bugmakerr ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
kaivalnp commented on PR #13202:
URL: https://github.com/apache/lucene/pull/13202#issuecomment-2025776234
> I am guessing the `QueryTimeout` object has to do some global syncing to
determine the current runtime to check
I have used the default
[`QueryTimeoutImpl`](https://github.com/
jpountz commented on PR #13223:
URL: https://github.com/apache/lucene/pull/13223#issuecomment-2025770130
For reference, this change is based on similar observations as made on
https://biriukov.dev/docs/page-cache/3-page-cache-and-basic-file-operations.
`mmap` comes with a 128kB readahead wh
marko-bekhta opened a new issue, #13234:
URL: https://github.com/apache/lucene/issues/13234
### Description
Assume there's a query parser created, e.g.:
```java
Analyzer analyzer = new ClassicAnalyzer();
QueryParser queryParser = new QueryParser( "field", analyzer );
``
rmuir commented on PR #13223:
URL: https://github.com/apache/lucene/pull/13223#issuecomment-2025529142
my thoughts here are that issues can be addressed by providing correct
advice to `madvise`. IMO this should typically be `MADV_RANDOM` because
accesses are in random order: even if "we" th
Trey314159 commented on PR #12172:
URL: https://github.com/apache/lucene/pull/12172#issuecomment-2025451266
Thanks, @rmuir for shepherding this through to completion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
vsop-479 commented on code in PR #13192:
URL: https://github.com/apache/lucene/pull/13192#discussion_r1543119650
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##
@@ -196,6 +207,90 @@ void loadBlock() throws IOException {
suf
rmuir commented on PR #12172:
URL: https://github.com/apache/lucene/pull/12172#issuecomment-2025373123
Thank you again @Trey314159 for raising this issue. I want to apologize
again for it taking so long...
Stemmer and stopwords are now fixed, to complete the loop, I've opened
#13233
rmuir merged PR #12172:
URL: https://github.com/apache/lucene/pull/12172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
vsop-479 commented on code in PR #13192:
URL: https://github.com/apache/lucene/pull/13192#discussion_r1543074950
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##
@@ -554,49 +683,128 @@ public SeekStatus scanToTermLeaf(BytesRef ta
vsop-479 commented on code in PR #13192:
URL: https://github.com/apache/lucene/pull/13192#discussion_r1543071871
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##
@@ -196,6 +207,90 @@ void loadBlock() throws IOException {
suf
vsop-479 commented on code in PR #11888:
URL: https://github.com/apache/lucene/pull/11888#discussion_r1543070445
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##
@@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef targ
mikemccand commented on issue #13193:
URL: https://github.com/apache/lucene/issues/13193#issuecomment-2025290139
> > The instant approach we take today gives no credit for a longish period
of time when no/few bytes were written.
>
> My mental model is that the goal of merge throttling
mikemccand commented on PR #12517:
URL: https://github.com/apache/lucene/pull/12517#issuecomment-2025238979
> The built kuromoji jar with unidic-cwj-3.1.1-full eventually becomes 442M.
Besides the size, I think we should consider performance. I'm worried that
there can be a significant impa
jpountz commented on PR #13229:
URL: https://github.com/apache/lucene/pull/13229#issuecomment-2025225176
> Looks fine now. How should we handle the DEFAULT context?
I'm looking into a (separate) change that renames it to `WRITE` and enforces
that it's never used for reading. Let's see
jpountz commented on PR #13224:
URL: https://github.com/apache/lucene/pull/13224#issuecomment-2025171056
Could you add a test when the `blockShift` that is passed at write time is
less than `log2(numValues)` to make sure that returning a reader that has a
different number of blocks is fine?
vletard commented on PR #13165:
URL: https://github.com/apache/lucene/pull/13165#issuecomment-2025143936
I added a test in TestUnifiedHighlighterExtensibility, probably too simple
for what you asked though.
From my understanding, performing a more realistic test with adequate UH and
quer
original-brownbear commented on PR #13224:
URL: https://github.com/apache/lucene/pull/13224#issuecomment-2025129227
Thanks @benwtrent! Done in
[e579101](https://github.com/apache/lucene/pull/13224/commits/e579101a98c18194e9a455d010efce53a332d698)
--
This is an automated message from the A
uschindler commented on PR #13196:
URL: https://github.com/apache/lucene/pull/13196#issuecomment-2025086037
> As disussed before, for implementing fadvise for reading/writing files, we
would need to write a full stack of IO layer natively (OutputStream for writing
and FileChannel for NIOFSD
mikemccand commented on code in PR #13192:
URL: https://github.com/apache/lucene/pull/13192#discussion_r1542884001
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##
@@ -196,6 +207,90 @@ void loadBlock() throws IOException {
s
mikemccand commented on issue #13218:
URL: https://github.com/apache/lucene/issues/13218#issuecomment-2025045014
> FWIW I plan on treating all issues that have their milestone set to 10.0
as needing discussion if we want to exclude them from 10.0.
Awesome, thanks @jpountz.
--
This
mikemccand commented on PR #13149:
URL: https://github.com/apache/lucene/pull/13149#issuecomment-2025041318
> Do we believe that we can merge this PR and then continue with changing
the BKD visit API in a later change, or should we try to change the abstraction
in this PR?
+1 -- PNP!
mikemccand commented on code in PR #11888:
URL: https://github.com/apache/lucene/pull/11888#discussion_r1542769731
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##
@@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef ta
benwtrent commented on PR #13202:
URL: https://github.com/apache/lucene/pull/13202#issuecomment-2024967034
> unit vectors, 100 dimensions, indexed first 1M vectors,
@kaivalnp AH, ok, only 100 dimensions, this explains the overly large impact
that checking for timeout had, as there is
uschindler commented on PR #13223:
URL: https://github.com/apache/lucene/pull/13223#issuecomment-2024955655
I am also a bit skeptical why you need to modify the block device. If this
would be a file system setting I can imagine it's useful.
@rmuir this came from investigation by Wikim
rmuir commented on code in PR #13223:
URL: https://github.com/apache/lucene/pull/13223#discussion_r1542723020
##
lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java:
##
@@ -38,6 +38,15 @@
* fragmented address space. If you get an {@link IOException} about mapping
kaivalnp commented on PR #13202:
URL: https://github.com/apache/lucene/pull/13202#issuecomment-2024899453
> What was the dimension count & dataset for your performance testing
It was the enwiki dataset
(https://home.apache.org/~sokolov/enwiki-20120502-lines-1k-100d.vec), unit
vectors
uschindler commented on PR #13229:
URL: https://github.com/apache/lucene/pull/13229#issuecomment-2024875315
Looks fine now. How should we handle the DEFAULT context?
I think for the purpose here it can be seen as READ.
--
This is an automated message from the Apache Git Service.
To
original-brownbear commented on PR #13224:
URL: https://github.com/apache/lucene/pull/13224#issuecomment-2024829219
Sounds good @jpountz and @benwtrent, how about
[f924708](https://github.com/apache/lucene/pull/13224/commits/f924708da93b14a99ca9aa312bab675782b0ddac)
for a simpler version of
uschindler commented on PR #13206:
URL: https://github.com/apache/lucene/pull/13206#issuecomment-2024790717
All backported to 9.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
uschindler commented on PR #13206:
URL: https://github.com/apache/lucene/pull/13206#issuecomment-2024776901
I did not notice that changes entry was in wrong section, fixed in main
branch
(https://github.com/apache/lucene/commit/376ec27a5166ccfad2e68fc22c7543dc38e1fb46).
Now backporting.
uschindler merged PR #13206:
URL: https://github.com/apache/lucene/pull/13206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
vsop-479 commented on PR #11888:
URL: https://github.com/apache/lucene/pull/11888#issuecomment-2024550150
Thanks for your comments @mikemccand . I have fixed them, and removed the
stale change entry about this change.
Please take a look when you get a chance.
--
This is an automated me
63 matches
Mail list logo
