vletard commented on PR #13165: URL: https://github.com/apache/lucene/pull/13165#issuecomment-2025143936
I added a test in TestUnifiedHighlighterExtensibility, probably too simple for what you asked though. From my understanding, performing a more realistic test with adequate UH and query setup would require one of the following: - cross-package import some code from TestUnifiedHighlighter to TestUnifiedHighlighterExtensibility - copy this code instead of importing it (we probably want to avoid this as it would duplicate much of the randomized generation process) - create an extensibility test in the `uhighlight` package instead of `uhighlight.visibility` Options 1 and 3 that I tend to prefer would require not-so-light edits, so I'd like your opinion. What is the expected way to do this in Lucene unit testing? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
