uschindler commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1987374489
I mean when you enable coverage or start the virtual "coverage task", gradle
should automatically set security manager to off. When I start coverage run
locally it breaks, too, so it
uschindler commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1987371974
Can't we do that in the gradle magic automatically?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
mikemccand commented on PR #13149:
URL: https://github.com/apache/lucene/pull/13149#issuecomment-1987369263
> I tried benchmarking this with luceneutil, but did not see any significant
change with the default benchmark - I suspect that I'm using the wrong
luceneutil tasks to see any major d
dweiss commented on code in PR #13177:
URL: https://github.com/apache/lucene/pull/13177#discussion_r1518987031
##
lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java:
##
@@ -256,7 +257,7 @@ public void test() throws Exception {
if (TEST
dweiss opened a new pull request, #13177:
URL: https://github.com/apache/lucene/pull/13177
A follow-up to #13164 . I don't fully understand this code (I get the gist)
so I didn't go for any revolutionary changes - just removed the halt() call in
favor of an external process killer. I've re-
dweiss commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1987350805
I've turned off security manager for these coverage runs. Jacoco jar/
options are resolved/ added by plugins and it's hard to wrap one's head around
it (where does the jar come from, what
stefanvodita commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1518965858
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java:
##
@@ -142,6 +249,301 @@ DimConfig verifyDim(String dim) {
return dimConfig;
stefanvodita commented on issue #13175:
URL: https://github.com/apache/lucene/issues/13175#issuecomment-1987337676
Maybe we can also extract out a common function from all the `Facets`
inserting into a priority queue, as @Shradha26
[suggests](https://github.com/apache/lucene/pull/12966#disc
stefanvodita commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1518965319
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java:
##
@@ -142,6 +249,301 @@ DimConfig verifyDim(String dim) {
return dimConfig;
timgrein opened a new pull request, #13176:
URL: https://github.com/apache/lucene/pull/13176
### Description
For the following seed `gradlew test --tests
TestFloatVectorSimilarityQuery.testBoostQuery -Dtests.seed=3F71A3D0594CEBC0
-Dtests.nightly=true -Dtests.locale=de-Latn-DE -Dtests
stefanvodita commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1518798993
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetFloatAssociations.java:
##
@@ -188,8 +190,10 @@ private void aggregateValues(
of
stefanvodita commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1518798524
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java:
##
@@ -76,6 +111,78 @@ public int compare(FacetResult a, FacetResult b) {
this
stefanvodita commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1518798260
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java:
##
@@ -67,6 +91,17 @@ public int compare(FacetResult a, FacetResult b) {
/** Map
stefanvodita commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1518798043
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java:
##
@@ -76,6 +111,78 @@ public int compare(FacetResult a, FacetResult b) {
this
stefanvodita commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1518797444
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java:
##
@@ -17,20 +17,44 @@
package org.apache.lucene.facet.taxonomy;
+import com.c
stefanvodita commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1518796616
##
lucene/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java:
##
@@ -347,8 +347,8 @@ private TopChildrenForPath computeTop
stefanvodita opened a new issue, #13175:
URL: https://github.com/apache/lucene/issues/13175
### Description
There are several occurrences in our code where we check that an incoming
value can be inserted in a priority queue and then call `insertWithOverflow`,
which re-does the check.
stefanvodita commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1518795915
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java:
##
@@ -142,6 +249,301 @@ DimConfig verifyDim(String dim) {
return dimConfig;
18 matches
Mail list logo
