stefanvodita commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1518798993
##########
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetFloatAssociations.java:
##########
@@ -188,8 +190,10 @@ private void aggregateValues(
offset += 4;
float value = (float) BitUtil.VH_BE_FLOAT.get(bytes, offset);
offset += 4;
- float newValue = aggregationFunction.aggregate(values[ord], value);
- values[ord] = newValue;
+ float currentValue = getValue(ord);
+ float newValue = aggregationFunction.aggregate(currentValue, value);
+ setValue(ord, newValue);
+ setCount(ord, getCount(ord) + 1);
Review Comment:
I think it has some nice advantages, e.g. it will resolve #11282 and #12585.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
