stefanvodita commented on code in PR #12966: URL: https://github.com/apache/lucene/pull/12966#discussion_r1518798260
########## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java: ########## @@ -67,6 +91,17 @@ public int compare(FacetResult a, FacetResult b) { /** Maps an ordinal to its parent, or -1 if there is no parent (root node). */ final int[] parents; + /** Dense ordinal counts. */ + int[] counts; Review Comment: It's important that `IntTaxonomyFacets` and `FloatTaxonomyFacets` have their own data structures for efficiency. This array here only keep counts and not other aggregations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org