dweiss commented on code in PR #13087:
URL: https://github.com/apache/lucene/pull/13087#discussion_r1486863725
##
lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestSimpleServer.java:
##
@@ -61,7 +61,7 @@
@SuppressForbidden(reason = "We need Unsafe to actually crus
dweiss commented on issue #13116:
URL: https://github.com/apache/lucene/issues/13116#issuecomment-1970525526
A much better solution would be to try to track down why
UncheckedIOException is thrown in the stack - something is likely missing a
proper IOException signature (or something higher
dweiss commented on PR #13141:
URL: https://github.com/apache/lucene/pull/13141#issuecomment-1970518645
I confirm it's working on schedule, as intended:
https://github.com/apache/lucene/actions/runs/8090015214
--
This is an automated message from the Apache Git Service.
To respond to th
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1505632559
##
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##
@@ -92,6 +93,7 @@ public Automaton() {
public Automaton(int numStates, int numTransitio
shubhamvishu commented on code in PR #13124:
URL: https://github.com/apache/lucene/pull/13124#discussion_r1506927786
##
lucene/core/src/java/org/apache/lucene/index/SegmentMerger.java:
##
@@ -56,13 +58,19 @@ final class SegmentMerger {
InfoStream infoStream,
Direct
easyice commented on issue #13116:
URL: https://github.com/apache/lucene/issues/13116#issuecomment-1970163120
> Likely many Lucene tests are missing/failing to catch UncheckedIOException
now...
emmm... yeah, should we open another issue about this?
--
This is an automated message f
easyice opened a new pull request, #13144:
URL: https://github.com/apache/lucene/pull/13144
From https://github.com/apache/lucene/issues/13116
```
gradlew test --tests TestIndexWriterOnDiskFull.testAddIndexOnDiskFull
-Dtests.seed=D7C2553CB8A4ADB5 -Dtests.nightly=true -Dtests.locale
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970065350
> I have no time to do this now, but we should at least one time check that
Emma works with Java 21 class files:
>
> ```shell
> $ ./gradlew test -Ptests.coverage=true
> ``
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970050803
I have no time to do this now, but we should at least one time check that
Emma works with Java 21:
```sh
$ ./gradlew test -Ptests.coverage=true
```
--
This is an automated
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970043318
Policeman Jenkins also updated to use Java 21 as base JDK and randomize this
or later versions/bitness/GC options with RUNTIME_JAVA_HOME
--
This is an automated message from the Apa
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970023486
ASF Jenkins was updated to run all Jobs with Java 21. Currently untested is
EMMA Coverage builds, we should maybe test this here, too. It could be that we
may need to update Emma depe
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970011748
Just give me a one hour pre-announcenent before merging this PR, so I can
reconfigure Jenkins servers.
It's too late today, but I will do this tomorrow morning.
--
This is an aut
gsmiller commented on PR #12862:
URL: https://github.com/apache/lucene/pull/12862#issuecomment-1969991101
@epotyom I'd be happy to do a pass on this and help get it merged if you
like. Would you mind resolving the current merge conflicts then I'll have a
look?
--
This is an automated mes
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1969985276
The vote has passed. I think it's ready to merge.
I have time tomorrow and would like to cleanup the MR-JAR code and remove
the legacy ByteBufferIndexInput.
--
This is an aut
uschindler commented on PR #13087:
URL: https://github.com/apache/lucene/pull/13087#issuecomment-1969950639
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
uschindler merged PR #13087:
URL: https://github.com/apache/lucene/pull/13087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler commented on code in PR #13087:
URL: https://github.com/apache/lucene/pull/13087#discussion_r1506679359
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -80,7 +81,7 @@ public abstract class BackwardsCompati
sabi0 commented on code in PR #13087:
URL: https://github.com/apache/lucene/pull/13087#discussion_r1506677807
##
lucene/core/src/java/org/apache/lucene/store/NativeFSLockFactory.java:
##
@@ -65,7 +64,7 @@ public final class NativeFSLockFactory extends FSLockFactory {
/** Sing
sabi0 commented on code in PR #13087:
URL: https://github.com/apache/lucene/pull/13087#discussion_r1506672577
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -80,7 +81,7 @@ public abstract class BackwardsCompatibilit
sabi0 commented on code in PR #13087:
URL: https://github.com/apache/lucene/pull/13087#discussion_r1506669079
##
lucene/core/src/java/org/apache/lucene/util/VirtualMethod.java:
##
@@ -74,14 +73,13 @@
*/
public final class VirtualMethod {
- private static final Set singleto
sabi0 commented on PR #13087:
URL: https://github.com/apache/lucene/pull/13087#issuecomment-1969921461
> There seems to be overlap with the latest PR regarding concurrent sets.
Maybe revert those changes from this PR.
This was a good idea. Thank you.
Now there is a clean separation
mccullocht opened a new pull request, #13143:
URL: https://github.com/apache/lucene/pull/13143
### Description
As of #12806 the hnsw codec has implemented a more complete version of this
logic that may trigger without a pre-filter query. The `exactSearch()` might
also have some odd b
dweiss merged PR #13141:
URL: https://github.com/apache/lucene/pull/13141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1505632559
##
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##
@@ -92,6 +93,7 @@ public Automaton() {
public Automaton(int numStates, int numTransitio
kaivalnp closed pull request #12820: Re-use information from graph traversal
during exact search
URL: https://github.com/apache/lucene/pull/12820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
uschindler commented on PR #13087:
URL: https://github.com/apache/lucene/pull/13087#issuecomment-1968559762
> Hi @uschindler, I was away from computer last week. I will take care of
the conflicts and your remarks later today. Sorry for the delay.
There seems to be overlap with the lat
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1505621389
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -67,12 +68,16 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
points
sabi0 commented on PR #13087:
URL: https://github.com/apache/lucene/pull/13087#issuecomment-1968530248
Hi @uschindler,
I was away from computer last week. I will take care of the conflicts and
your remarks later today.
Sorry for the delay.
--
This is an automated message from the Ap
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1505583695
##
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##
@@ -70,6 +70,7 @@ public class Automaton implements Accountable,
TransitionAccessor {
dweiss commented on code in PR #13142:
URL: https://github.com/apache/lucene/pull/13142#discussion_r1505580073
##
lucene/replicator/src/java/org/apache/lucene/replicator/nrt/PrimaryNode.java:
##
@@ -158,10 +158,7 @@ public long getPrimaryGen() {
*/
public boolean flushAnd
dweiss commented on code in PR #13142:
URL: https://github.com/apache/lucene/pull/13142#discussion_r1505553339
##
lucene/core/src/java/org/apache/lucene/util/VirtualMethod.java:
##
@@ -100,7 +98,7 @@ public VirtualMethod(Class baseClass, String method,
Class... parameters)
sabi0 commented on code in PR #13142:
URL: https://github.com/apache/lucene/pull/13142#discussion_r1505545772
##
lucene/replicator/src/java/org/apache/lucene/replicator/nrt/PrimaryNode.java:
##
@@ -158,10 +158,7 @@ public long getPrimaryGen() {
*/
public boolean flushAndR
sabi0 commented on code in PR #13142:
URL: https://github.com/apache/lucene/pull/13142#discussion_r1505545772
##
lucene/replicator/src/java/org/apache/lucene/replicator/nrt/PrimaryNode.java:
##
@@ -158,10 +158,7 @@ public long getPrimaryGen() {
*/
public boolean flushAndR
sabi0 commented on code in PR #13142:
URL: https://github.com/apache/lucene/pull/13142#discussion_r1505532560
##
lucene/core/src/java/org/apache/lucene/util/VirtualMethod.java:
##
@@ -100,7 +98,7 @@ public VirtualMethod(Class baseClass, String method,
Class... parameters)
uschindler commented on PR #13087:
URL: https://github.com/apache/lucene/pull/13087#issuecomment-1968437746
Hi @sabi0,
what's going on with this? Should I merge this one after resolving the
conflict? The changes entry needs to be moved to 9.11.
--
This is an automated message from the
35 matches
Mail list logo
