sabi0 commented on code in PR #13087:
URL: https://github.com/apache/lucene/pull/13087#discussion_r1506672577
##########
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##########
@@ -80,7 +81,7 @@ public abstract class BackwardsCompatibilityTestBase extends
LuceneTestCase {
// make sure we never miss a version.
assertTrue("Version: " + version + " missing",
binaryVersions.remove(version));
}
- BINARY_SUPPORTED_VERSIONS = binaryVersions;
+ BINARY_SUPPORTED_VERSIONS = Collections.unmodifiableSet(binaryVersions);
Review Comment:
`TestAncientIndicesCompatibility.UNSUPPORTED_INDEXES` is already immutable:
https://github.com/apache/lucene/blob/390c109e673c9164c5359eda34223688875e4b66/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestAncientIndicesCompatibility.java#L84
Or did you mean something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
