vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1505632559
##########
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##########
@@ -92,6 +93,7 @@ public Automaton() {
public Automaton(int numStates, int numTransitions) {
states = new int[numStates * 2];
isAccept = new BitSet(numStates);
+ terminable = new BitSet(numStates);
Review Comment:
> E.g. if I build a RegexpQuery that is actually a PrefixQuery we won't set
this?
Yes, I only implemented this in `PrefixQuery` in current version.
> Everything else about Automaton today is fundamental (states, transitions,
isAccept) and necessary, but this new member is more a best effort optimization?
Yes, I will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
