Re: [PR] Fix a bug in ShapeTestUtil [lucene]

2024-01-23 Thread via GitHub
heemin32 commented on PR #12287: URL: https://github.com/apache/lucene/pull/12287#issuecomment-1907155750 Any update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Add support for similarity-based vector searches [lucene]

2024-01-23 Thread via GitHub
junqiu-lei commented on PR #12679: URL: https://github.com/apache/lucene/pull/12679#issuecomment-1907152593 Hi, do we have any scheduled release date for this exciting feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] LUCENE-10334: Introduce a BlockReader based on ForUtil and use it for NumericDocValues [lucene]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #562: URL: https://github.com/apache/lucene/pull/562#issuecomment-1907130825 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] GH#11922: Allow DisjunctionDISIApproximation to short-circuit [lucene]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #11928: URL: https://github.com/apache/lucene/pull/11928#issuecomment-1907130536 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1907130580 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Remove redundant code in Lucene search [lucene]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #12035: URL: https://github.com/apache/lucene/pull/12035#issuecomment-1907130465 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Use `instanceof` pattern-matching where possible [lucene]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #12295: URL: https://github.com/apache/lucene/pull/12295#issuecomment-1907130198 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Fix a bug in ShapeTestUtil [lucene]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #12287: URL: https://github.com/apache/lucene/pull/12287#issuecomment-1907130242 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] upgrade to OpenNLP 2.3.1 [lucene]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #12674: URL: https://github.com/apache/lucene/pull/12674#issuecomment-1907129893 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Generalize LSBRadixSorter and use it in SortingPostingsEnum [lucene]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #12800: URL: https://github.com/apache/lucene/pull/12800#issuecomment-1907129767 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Add Facets#getBulkSpecificValues method [lucene]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #12862: URL: https://github.com/apache/lucene/pull/12862#issuecomment-1907129639 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Add new token filters for Japanese sutegana (捨て仮名) [lucene]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #12915: URL: https://github.com/apache/lucene/pull/12915#issuecomment-1907129523 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Forbidden Thread.sleep API [lucene]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #13001: URL: https://github.com/apache/lucene/pull/13001#issuecomment-1907129375 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Fix issues with chunked TaxonomyIndexArray [lucene]

2024-01-23 Thread via GitHub
msfroh commented on code in PR #13028: URL: https://github.com/apache/lucene/pull/13028#discussion_r1463878454 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java: ## @@ -95,7 +97,8 @@ public TaxonomyIndexArrays(IndexReader reader, Taxon

Re: [PR] Fix issues with chunked TaxonomyIndexArray [lucene]

2024-01-23 Thread via GitHub
msfroh commented on code in PR #13028: URL: https://github.com/apache/lucene/pull/13028#discussion_r1463869892 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestTaxonomyIndexArrays.java: ## @@ -59,4 +74,88 @@ public void testMultiplesOfChunkSize() {

Re: [PR] Fix NPE when sampling for quantization in Lucene99HnswScalarQuantizedVectorsFormat [lucene]

2024-01-23 Thread via GitHub
benwtrent merged PR #13027: URL: https://github.com/apache/lucene/pull/13027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Enable MemorySegment in MMapDirectory for Java 22+ and Vectorization (incubation) for exact Java 22 [lucene]

2024-01-23 Thread via GitHub
ChrisHegarty commented on PR #12706: URL: https://github.com/apache/lucene/pull/12706#issuecomment-1905951549 > I don't think there will be any changes till release, but my plan was to merge this on 2024-02-08. That sounds fine to me. And I agree with merging this at the JDK 22 RC dat

Re: [PR] Fix NPE when sampling for quantization in Lucene99HnswScalarQuantizedVectorsFormat [lucene]

2024-01-23 Thread via GitHub
ChrisHegarty commented on code in PR #13027: URL: https://github.com/apache/lucene/pull/13027#discussion_r1463192412 ## lucene/CHANGES.txt: ## @@ -243,6 +243,13 @@ Other * GITHUB#12934: Cleaning up old references to Lucene/Solr. (Jakub Slowinski) + L

Re: [PR] Fix NPE when sampling for quantization in Lucene99HnswScalarQuantizedVectorsFormat [lucene]

2024-01-23 Thread via GitHub
benwtrent commented on code in PR #13027: URL: https://github.com/apache/lucene/pull/13027#discussion_r1463174260 ## lucene/core/src/java/org/apache/lucene/util/ScalarQuantizer.java: ## @@ -201,13 +233,26 @@ public String toString() { * * @param floatVectorValues the flo

Re: [PR] Initial impl of MMapDirectory and Vectorization (incubation) for Java 22 [lucene]

2024-01-23 Thread via GitHub
uschindler commented on PR #12706: URL: https://github.com/apache/lucene/pull/12706#issuecomment-1905762807 I don't think there will be any changes till release, but my plan was to merge this on 2024-02-08. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Initial impl of MMapDirectory and Vectorization (incubation) for Java 22 [lucene]

2024-01-23 Thread via GitHub
uschindler commented on PR #12706: URL: https://github.com/apache/lucene/pull/12706#issuecomment-1905761622 Hey, yes. I wanted to wait till RC phase and check everything before it. In case we want to release a new Lucene version we can merge this earlier, I just want to be on safe sid

Re: [PR] Initial impl of MMapDirectory and Vectorization (incubation) for Java 22 [lucene]

2024-01-23 Thread via GitHub
ChrisHegarty commented on PR #12706: URL: https://github.com/apache/lucene/pull/12706#issuecomment-1905715861 @uschindler This looks like it is in good shape. I think that it is ready for merging, right? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Fix NPE when sampling for quantization in Lucene99HnswScalarQuantizedVectorsFormat [lucene]

2024-01-23 Thread via GitHub
ChrisHegarty commented on code in PR #13027: URL: https://github.com/apache/lucene/pull/13027#discussion_r1463026638 ## lucene/CHANGES.txt: ## @@ -243,6 +243,13 @@ Other * GITHUB#12934: Cleaning up old references to Lucene/Solr. (Jakub Slowinski) + L

Re: [PR] Fix NPE when sampling for quantization in Lucene99HnswScalarQuantizedVectorsFormat [lucene]

2024-01-23 Thread via GitHub
ChrisHegarty commented on code in PR #13027: URL: https://github.com/apache/lucene/pull/13027#discussion_r1463016033 ## lucene/core/src/java/org/apache/lucene/util/ScalarQuantizer.java: ## @@ -201,13 +233,26 @@ public String toString() { * * @param floatVectorValues the

Re: [PR] Fix NPE when sampling for quantization in Lucene99HnswScalarQuantizedVectorsFormat [lucene]

2024-01-23 Thread via GitHub
ChrisHegarty commented on code in PR #13027: URL: https://github.com/apache/lucene/pull/13027#discussion_r1463016033 ## lucene/core/src/java/org/apache/lucene/util/ScalarQuantizer.java: ## @@ -201,13 +233,26 @@ public String toString() { * * @param floatVectorValues the

Re: [I] What if we pick up segments in segment size's ascending order in TieredMergePolicy.doFindMerges? [lucene]

2024-01-23 Thread via GitHub
vsop-479 commented on issue #13022: URL: https://github.com/apache/lucene/issues/13022#issuecomment-1905672274 > Is findMerges() a bottleck for your use-case? No, though we find indexing performance downgrade when our index get too big, but the main reason may be `doStall` takes long

Re: [PR] Writing a HOWTO migrate codec version [lucene]

2024-01-23 Thread via GitHub
shubhamvishu commented on code in PR #12930: URL: https://github.com/apache/lucene/pull/12930#discussion_r1462861811 ## dev-docs/codec-version-bump-howto.md: ## @@ -0,0 +1,74 @@ + + +# Lucene Codec Version Bump How-To Manual + +Changing the name of the codec in Lucene is require

Re: [PR] Writing a HOWTO migrate codec version [lucene]

2024-01-23 Thread via GitHub
shubhamvishu commented on code in PR #12930: URL: https://github.com/apache/lucene/pull/12930#discussion_r1462857551 ## dev-docs/codec-version-bump-howto.md: ## @@ -0,0 +1,74 @@ + + +# Lucene Codec Version Bump How-To Manual + +Changing the name of the codec in Lucene is require