benwtrent commented on code in PR #13027:
URL: https://github.com/apache/lucene/pull/13027#discussion_r1463174260
##########
lucene/core/src/java/org/apache/lucene/util/ScalarQuantizer.java:
##########
@@ -201,13 +233,26 @@ public String toString() {
*
* @param floatVectorValues the float vector values from which to calculate
the quantiles
* @param confidenceInterval the confidence interval used to calculate the
quantiles
+ * @param totalVectorCount the total number of live float vectors in the
index. This is vital for
+ * accounting for deleted documents when calculating the quantiles.
* @return A new {@link ScalarQuantizer} instance
* @throws IOException if there is an error reading the float vector values
*/
public static ScalarQuantizer fromVectors(
- FloatVectorValues floatVectorValues, float confidenceInterval) throws
IOException {
+ FloatVectorValues floatVectorValues, float confidenceInterval, int
totalVectorCount)
Review Comment:
Yeah, changing a public definition in a bug fix stinks. I can overload it
for the bug fix and remove the overload in a minor release. These are
experimental, so we should be able to change them in minors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
