Re: [I] [DISCUSS] Should we change TieredMergePolicy's segment deletion accounting to use numDocs in the denominator rather than MaxDoc? [lucene]

2023-11-12 Thread via GitHub
jpountz commented on issue #12792: URL: https://github.com/apache/lucene/issues/12792#issuecomment-1807619406 The way I understand deletions percentage is something like "how much of my doc ID space is taken by deleted docs", ie. the current definition. I find it easier to reason about beca

Re: [PR] Speedup concurrent multi-segment HNWS graph search [lucene]

2023-11-12 Thread via GitHub
mayya-sharipova commented on PR #12794: URL: https://github.com/apache/lucene/pull/12794#issuecomment-1807150252 **10M vectors of 100 dims** : k=100, 27 segments || Avg visited nodes |QPS| Recall| | :--- | ---: | ---: | ---: |

Re: [I] Multiple ClassNotFoundExceptions in IntelliJ Fat Jar on ARM64 Java 20 [lucene]

2023-11-12 Thread via GitHub
uschindler commented on issue #12307: URL: https://github.com/apache/lucene/issues/12307#issuecomment-1807127120 > Apparently, starting from Lucene 9.x the Multi-Release JAR files are used: Actually, Lucene already used in its 8.x releases the MRJAR features, but without the extra cla

Re: [I] Multiple ClassNotFoundExceptions in IntelliJ Fat Jar on ARM64 Java 20 [lucene]

2023-11-12 Thread via GitHub
uschindler commented on issue #12307: URL: https://github.com/apache/lucene/issues/12307#issuecomment-1807121916 FYI, one reason why they might have done this: if the whole thing is a webapp, with wrong setup or broken containers the class loading is often broken, especially if somebody dro

Re: [I] Multiple ClassNotFoundExceptions in IntelliJ Fat Jar on ARM64 Java 20 [lucene]

2023-11-12 Thread via GitHub
uschindler commented on issue #12307: URL: https://github.com/apache/lucene/issues/12307#issuecomment-1807110136 There is no need to merge those files and as said before this is discouraged. It was never required. I have no idea why they did this. It is and was broken from the beginning.

Re: [I] Multiple ClassNotFoundExceptions in IntelliJ Fat Jar on ARM64 Java 20 [lucene]

2023-11-12 Thread via GitHub
davido commented on issue #12307: URL: https://github.com/apache/lucene/issues/12307#issuecomment-1807097946 @uschindler Thank you for clarifying and for the links to the specifications. What confused me, is that the problem showed up after two changes: using JDK 21 at runtime

Re: [PR] Allow FST builder to use different writer (#12543) [lucene]

2023-11-12 Thread via GitHub
dungba88 commented on code in PR #12624: URL: https://github.com/apache/lucene/pull/12624#discussion_r1390363849 ## lucene/core/src/java/org/apache/lucene/util/fst/BytesStore.java: ## @@ -26,7 +27,8 @@ // TODO: merge with PagedBytes, except PagedBytes doesn't // let you read w