[GitHub] [lucene] javanna commented on issue #11963: Improve vector quantization API

javanna commented on issue #11963: URL: https://github.com/apache/lucene/issues/11963#issuecomment-1401129828 It looks like we made all the suggested changes. One step that is missing is renaming the float classes and methods to follow exactly the naming convention suggested in the last com

[GitHub] [lucene] javanna opened a new pull request, #12105: Rename vector float classes

javanna opened a new pull request, #12105: URL: https://github.com/apache/lucene/pull/12105 We recently introduced `KnnByteVectorField`, `KnnByteVectorQuery` and `ByteVectorValues`, the corresponding float variants of the same classes don't follow the same naming convention: `KnnVectorField

[GitHub] [lucene] magibney commented on pull request #12096: remove username from MANIFEST.MF in build artifacts

magibney commented on PR #12096: URL: https://github.com/apache/lucene/pull/12096#issuecomment-1401067860 >After your last message I was about to do it on my own. Thanks, and sorry for the mixed signals. Just wanted to make sure it got done in time for 9.5! -- This is an automated

[GitHub] [lucene] javanna merged pull request #12104: Replace BytesRef usages in byte vectors API with byte[] (#12102)

javanna merged PR #12104: URL: https://github.com/apache/lucene/pull/12104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] uschindler commented on pull request #12096: remove username from MANIFEST.MF in build artifacts

uschindler commented on PR #12096: URL: https://github.com/apache/lucene/pull/12096#issuecomment-1401051499 Thanks for merging this. After your last message I was about to do it on my own. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [lucene] magibney commented on pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)

magibney commented on PR #12094: URL: https://github.com/apache/lucene/pull/12094#issuecomment-1401040344 Closed; superseded by https://github.com/apache/lucene/pull/12096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [lucene] magibney closed pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)

magibney closed pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id) URL: https://github.com/apache/lucene/pull/12094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] magibney commented on pull request #12096: remove username from MANIFEST.MF in build artifacts

magibney commented on PR #12096: URL: https://github.com/apache/lucene/pull/12096#issuecomment-1401038928 Merged/backported to make this available for 9.5 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene] magibney merged pull request #12096: remove username from MANIFEST.MF in build artifacts

magibney merged PR #12096: URL: https://github.com/apache/lucene/pull/12096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

[GitHub] [lucene] magibney merged pull request #12095: buildAndPushRelease should optionally pause before assembleRelease

magibney merged PR #12095: URL: https://github.com/apache/lucene/pull/12095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

[GitHub] [lucene] javanna commented on a diff in pull request #12102: Replace BytesRef usages in byte vectors API with byte[]

javanna commented on code in PR #12102: URL: https://github.com/apache/lucene/pull/12102#discussion_r1084580078 ## lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java: ## @@ -284,7 +285,9 @@ private static class SortingByteVectorValues extends ByteVectorValues

[GitHub] [lucene] javanna opened a new pull request, #12104: Replace BytesRef usages in byte vectors API with byte[] (#12102)

javanna opened a new pull request, #12104: URL: https://github.com/apache/lucene/pull/12104 The main classes involved are ByteVectorValues, KnnByteVectorField and KnnByteVectorQuery. It becomes quite natural to simplify things further and use byte[] in the following methods too: ByteVectorV

[GitHub] [lucene] javanna commented on a diff in pull request #12102: Replace BytesRef usages in byte vectors API with byte[]

javanna commented on code in PR #12102: URL: https://github.com/apache/lucene/pull/12102#discussion_r1084564868 ## lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java: ## @@ -284,7 +285,9 @@ private static class SortingByteVectorValues extends ByteVectorValues

[GitHub] [lucene] benwtrent commented on a diff in pull request #12102: Replace BytesRef usages in byte vectors API with byte[]

benwtrent commented on code in PR #12102: URL: https://github.com/apache/lucene/pull/12102#discussion_r1084544377 ## lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java: ## @@ -284,7 +285,9 @@ private static class SortingByteVectorValues extends ByteVectorValue

[GitHub] [lucene] javanna merged pull request #12102: Replace BytesRef usages in byte vectors API with byte[]

javanna merged PR #12102: URL: https://github.com/apache/lucene/pull/12102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] javanna commented on a diff in pull request #12102: Replace BytesRef usages in byte vectors API with byte[]

javanna commented on code in PR #12102: URL: https://github.com/apache/lucene/pull/12102#discussion_r1084539250 ## lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java: ## @@ -534,10 +532,10 @@ float[] next() throws IOException { return target; } -

[GitHub] [lucene] benwtrent commented on a diff in pull request #12102: Replace BytesRef usages in byte vectors API with byte[]

benwtrent commented on code in PR #12102: URL: https://github.com/apache/lucene/pull/12102#discussion_r1084523450 ## lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java: ## @@ -534,10 +532,10 @@ float[] next() throws IOException { return target; }

[GitHub] [lucene] jpountz commented on a diff in pull request #12102: Replace BytesRef usages in byte vectors API with byte[]

jpountz commented on code in PR #12102: URL: https://github.com/apache/lucene/pull/12102#discussion_r1084511508 ## lucene/core/src/java/org/apache/lucene/util/VectorUtil.java: ## @@ -182,12 +182,12 @@ private static float squareDistanceUnrolled(float[] v1, float[] v2, int index

[GitHub] [lucene] javanna merged pull request #12103: Add missing changelog entry for KnnByteVectorField and friends

javanna merged PR #12103: URL: https://github.com/apache/lucene/pull/12103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] javanna opened a new pull request, #12103: Add missing changelog entry for KnnByteVectorField and friends

javanna opened a new pull request, #12103: URL: https://github.com/apache/lucene/pull/12103 I noticed that the changelog was missing an entry for #12064 so I added it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [lucene] javanna commented on a diff in pull request #12102: Replace BytesRef usages in byte vectors API with byte[]

javanna commented on code in PR #12102: URL: https://github.com/apache/lucene/pull/12102#discussion_r1084474237 ## lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java: ## @@ -534,10 +532,10 @@ float[] next() throws IOException { return target; } -

[GitHub] [lucene] javanna opened a new pull request, #12102: Replace BytesRef usages in byte vectors API with byte[]

javanna opened a new pull request, #12102: URL: https://github.com/apache/lucene/pull/12102 The main goal of this PR is to replace `BytesRef` usages across the byte vectors API. The main classes involved are `ByteVectorValues`, `KnnByteVectorField` and `KnnByteVectorQuery`. It becomes quit

[GitHub] [lucene] magibney commented on pull request #12096: remove username from MANIFEST.MF in build artifacts

magibney commented on PR #12096: URL: https://github.com/apache/lucene/pull/12096#issuecomment-1400769293 I'll leave it to someone else to merge this. I'm perfectly content with the substance of this PR; I opened it as a (trivial) courtesy and raised a few concerns in good faith. I do

[GitHub] [lucene] jpountz commented on pull request #12101: Remove binaryValue() on VectorValues and ByteVectorValues.

jpountz commented on PR #12101: URL: https://github.com/apache/lucene/pull/12101#issuecomment-1400319320 This change was more mechanical that I had anticipated thanks to @benwtrent 's recent refactorings. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene] jpountz merged pull request #12101: Remove binaryValue() on VectorValues and ByteVectorValues.

jpountz merged PR #12101: URL: https://github.com/apache/lucene/pull/12101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] jpountz opened a new pull request, #12101: Remove binaryValue() on VectorValues and ByteVectorValues.

jpountz opened a new pull request, #12101: URL: https://github.com/apache/lucene/pull/12101 This method tries to expose an encoded view of vectors, but we shouldn't have this part of our user-facing API. With this change, the way vectors are encoded is entirely on the codec. -- This is a

[GitHub] [lucene] alessandrobenedetti merged pull request #12029: introduce support in KnnVectorQuery for getters/setters

alessandrobenedetti merged PR #12029: URL: https://github.com/apache/lucene/pull/12029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] alessandrobenedetti closed issue #12099: introduce support in KnnVectorQuery for getters

alessandrobenedetti closed issue #12099: introduce support in KnnVectorQuery for getters URL: https://github.com/apache/lucene/issues/12099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [lucene] naddame commented on issue #11218: GraphTokenStreamFiniteStrings#articulationPointsRecurse can run into stack overflows [LUCENE-10181]

naddame commented on issue #11218: URL: https://github.com/apache/lucene/issues/11218#issuecomment-1400033076 Hi @mkhludnev we have the same problem with elasticsearch version 8.3.2 Our application is used for search engine in ecommerce context. We use multi_match query with this pa