javanna opened a new pull request, #12105: URL: https://github.com/apache/lucene/pull/12105
We recently introduced `KnnByteVectorField`, `KnnByteVectorQuery` and `ByteVectorValues`, the corresponding float variants of the same classes don't follow the same naming convention: `KnnVectorField`, `KnnVectoryQuery` and `VectorValues`. Ideally their names would reflect that they are the float variant of the vector field, vector query and vector values. This PR aims at clarifying this in the public facing API, by deprecating the current float classes in favour of new ones that are their exact copy but follow the same naming conventions as the byte ones. As a result, `LeafReader#getVectorValues` and `KnnVectorsReader#getVectorValues` are also deprecated in favour of newly introduced `getFloatVectorValues` methods that return `FloatVectorValues`. I opened a single PR to gather feedback first. I can also split it up in multiple PRs if we want to move forward in this direction. Relates to #11963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
