benwtrent commented on code in PR #12102:
URL: https://github.com/apache/lucene/pull/12102#discussion_r1084544377
##########
lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java:
##########
@@ -284,7 +285,9 @@ private static class SortingByteVectorValues extends
ByteVectorValues {
for (int doc = delegate.nextDoc(); doc != NO_MORE_DOCS; doc =
delegate.nextDoc()) {
int newDocID = sortMap.oldToNew(doc);
docsWithField.set(newDocID);
- binaryVectors[newDocID] = BytesRef.deepCopyOf(delegate.vectorValue());
+ binaryVectors[newDocID] =
Review Comment:
The `binaryVectors` should be a `byte[][]` now instead of `BytesRef[]`. We
are copying the arrays already, so might as well just use a raw `byte[]` here
instead of the unnecessary wrapping in `BytesRef`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
