[GitHub] [lucene-jira-archive] vlsi commented on issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
vlsi commented on issue #124: URL: https://github.com/apache/lucene-jira-archive/issues/124#issuecomment-1207344183 Looks reasonable to me. Then, the question is whether "migrated from jira" link is needed for every comment -- This is an automated message from the Apache Git Service. To

[GitHub] [lucene-jira-archive] mocobeta merged pull request #133: Drop jira link from linked-issues

2022-08-06 Thread GitBox
mocobeta merged PR #133: URL: https://github.com/apache/lucene-jira-archive/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene-jira-archive] mocobeta commented on issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
mocobeta commented on issue #124: URL: https://github.com/apache/lucene-jira-archive/issues/124#issuecomment-1207342271 I wonder if we no longer need links to Jira issue: #133. We already dropped the original Jira issue link for short form by replacing `LUCENE-` with `#NN` for succin

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #133: Drop jira link from linked-issues

2022-08-06 Thread GitBox
mocobeta opened a new pull request, #133: URL: https://github.com/apache/lucene-jira-archive/pull/133 We use GitHub issue link `#NN` for the first place; then I think there would be no need for creating links to Jira anymore (a fallback link to the original Jira is available in each GitHub

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207335431 > Are you going to include the link to GitHub issue? Yes, this is the main purpose of leaving a comment to each Jira. The message will be something like `This was moved

[GitHub] [lucene-jira-archive] vlsi commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
vlsi commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207335068 >This wad moved to GitHub  Are you going to include the link to GitHub issue? Would that trigger JIRA notifications? -- This is an automated message from the Apache Gi

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207334349 I sent an email on the dev@ list to share the change in the migration (~72 hours downtime for issues/PRs). I'd be glad if you give further suggestions there. If there are

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207323500 I recognize strong suggestions to make both Jira and GitHub non-writable during migration. Generally, I agree with it - stopping all activities for two or three days would no

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207320713 > I can also look into stuff if it is going on. On whcih machine do you want to start the meigration? I'd suggest to do this on some server at ASF (like the Jenkins Slave luc

[GitHub] [lucene-jira-archive] mocobeta commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207316046 #131 seems to work - I'm closing this. Internal issue links (URLs) to LUCENE Jira will be addressed in #132. -- This is an automated message from the Apache Git S

[GitHub] [lucene-jira-archive] mocobeta merged pull request #131: Create hyperlinks to other ASF projects for PRJ-XXXX style cross-issue links.

2022-08-06 Thread GitBox
mocobeta merged PR #131: URL: https://github.com/apache/lucene-jira-archive/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene-jira-archive] mocobeta closed issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta closed issue #129: Should we create links to Jira issues other than Lucene? URL: https://github.com/apache/lucene-jira-archive/issues/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #131: Create hyperlinks to other ASF projects for PRJ-XXXX style cross-issue links.

2022-08-06 Thread GitBox
mocobeta commented on PR #131: URL: https://github.com/apache/lucene-jira-archive/pull/131#issuecomment-1207313857 I run this on ~8000 issues; here are the generated issue links (sampled). ``` https://issues.apache.org/jira/browse/SOLR-15 https://issues.apache.org/jira/browse/SOLR-8

[jira] [Commented] (LUCENE-10386) Add BOM module for ease of dependency management in dependent projects

2022-08-06 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576301#comment-17576301 ] Michael Sokolov commented on LUCENE-10386: -- It seems we're not going to do thi

[GitHub] [lucene] msokolov commented on pull request #948: Fix typo in PostingsReaderBase docstring

2022-08-06 Thread GitBox
msokolov commented on PR #948: URL: https://github.com/apache/lucene/pull/948#issuecomment-1207305547 @vigyasharma did you forget about this one ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] msokolov commented on pull request #955: LUCENE-10612: Introduced Lucene93CodecParameters for Lucene93Codec

2022-08-06 Thread GitBox
msokolov commented on PR #955: URL: https://github.com/apache/lucene/pull/955#issuecomment-1207305478 I'm not sure why this is easier or cleaner. To me it seems to create an unneccessary intermediate class, just for the purpose of passing parameters. Perhaps if we were trying to load parame

[GitHub] [lucene] msokolov commented on pull request #1040: LUCENE-10404: use IntIntHashMap to track HNSW visited nodes

2022-08-06 Thread GitBox
msokolov commented on PR #1040: URL: https://github.com/apache/lucene/pull/1040#issuecomment-1207305068 I'm going to close this since it was sometimes better and sometimes worse than what we have now, and we should probably not bother with this, and instead try some kind of hybrid adaptive

[GitHub] [lucene] msokolov closed pull request #1040: LUCENE-10404: use IntIntHashMap to track HNSW visited nodes

2022-08-06 Thread GitBox
msokolov closed pull request #1040: LUCENE-10404: use IntIntHashMap to track HNSW visited nodes URL: https://github.com/apache/lucene/pull/1040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [lucene] msokolov commented on a diff in pull request #1058: LUCENE-10207: TermInSetQuery now provides a ScoreSupplier with cost estimation for use in TermInSetQuery

2022-08-06 Thread GitBox
msokolov commented on code in PR #1058: URL: https://github.com/apache/lucene/pull/1058#discussion_r939587786 ## lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java: ## @@ -345,15 +345,62 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOExceptio

[GitHub] [lucene-jira-archive] uschindler commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
uschindler commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207288810 And doing something like changing permission scheme can be done with communication on Slack. That's all. I did this several times. -- This is an automated message from th

[GitHub] [lucene-jira-archive] uschindler commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
uschindler commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207288675 Hi mocobeta, I can also look into stuff if it is going on. On whcih machine do you want to start the meigration? I'd suggest to do this on some server at ASF (like the J

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207273658 Don't get me wrong - I appreciate suggestions from all of you. However, there are many things you can easily control but I can't due to several differences (timezone, languag

[GitHub] [lucene] msokolov commented on pull request #1054: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-08-06 Thread GitBox
msokolov commented on PR #1054: URL: https://github.com/apache/lucene/pull/1054#issuecomment-1207262818 I made the needed changes to KnnGraphTester and ran several tests with different datasets. I believe this version of the PR addresses all the previous comments, and I'd like to move ahead

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207262101 I'll reach INFRA, but If possible, I would like to proceed with the whole process in async-style without real-time conversation using Slack - there is a time difference betwe

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207260905 Yes, but - making a Jira project would not be a quick fix I think? I'm missing something maybe? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [lucene-jira-archive] mocobeta commented on issue #132: Replace LUCENE issue links (URLs like https://issues.apache.org/jira/browse/LUCENE-XXXX) with GitHub mentions #NN

2022-08-06 Thread GitBox
mocobeta commented on issue #132: URL: https://github.com/apache/lucene-jira-archive/issues/132#issuecomment-1207259951 I just did a quick-check with grep command. Estimated # of issues that contain urls to LUCENE issues. ``` $ cat github-import-data/*.json | jq '.issue.body' |

[GitHub] [lucene-jira-archive] uschindler commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
uschindler commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207258917 Just do this live with the Infra team on Slack. They are very cooperative and fix stuff in realtime. Just make some appointment with them and you can work together with the

[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #132: Replace LUCENE issue links (URLs like https://issues.apache.org/jira/browse/LUCENE-XXXX) with GitHub mentions #NN

2022-08-06 Thread GitBox
mocobeta opened a new issue, #132: URL: https://github.com/apache/lucene-jira-archive/issues/132 Spin-off from #129. There could be multiple URLs to one issue. I suppose this regex would work? ``` https://issues\.apache\.org/jira/.+/LUCENE-\d+ ``` -- This is an automated me

[GitHub] [lucene-jira-archive] mocobeta closed issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
mocobeta closed issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style URL: https://github.com/apache/lucene-jira-archive/issues/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-jira-archive] mocobeta commented on issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
mocobeta commented on issue #124: URL: https://github.com/apache/lucene-jira-archive/issues/124#issuecomment-1207252369 Merged #130 - I'm closing this. Thanks @vlsi and @mikemccand for your suggestions. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207244201 > Have we confirmed with INFRA that we can quickly make Jira read-only for just our project (Lucene)? We need to update all Jira issues at the last step. If we want Jir

[GitHub] [lucene-jira-archive] mikemccand commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mikemccand commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207243538 > But if we follow the two-pass migration plan written in #7, we do not need any downtime. OK, as long as we feel the risks are all contained (because you had planned

[GitHub] [lucene-jira-archive] mikemccand commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mikemccand commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207243404 Have we confirmed with INFRA that we can quickly make Jira read-only for just our project (Lucene)? -- This is an automated message from the Apache Git Service. To respon

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207242420 > Does the second pass generate GitHub notifications for the users mentioned in the issues? We confirmed the second pass does not cause any notifications. It seems Git

[GitHub] [lucene-jira-archive] vlsi commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
vlsi commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207241887 Does the second pass generate GitHub notifications for the users mentioned in the issues? I think those notifications would be too much -- This is an automated message from

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #131: Create hyperlinks to other ASF projects for PRJ-XXXX style cross-issue links.

2022-08-06 Thread GitBox
mocobeta commented on PR #131: URL: https://github.com/apache/lucene-jira-archive/pull/131#issuecomment-1207239340 I think it'd be difficult to ensure the coverage. There might be false negatives since this regex is rather strict. At least we can log the detected links and check them. --

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207238227 Maybe I should have strongly argued we should allow some downtime (no new issues, PRs and comments for one or two days) so that we make the migration plan more simple.

[GitHub] [lucene-jira-archive] mikemccand commented on issue #91: Can we strike-through issues that were resolved on migration?

2022-08-06 Thread GitBox
mikemccand commented on issue #91: URL: https://github.com/apache/lucene-jira-archive/issues/91#issuecomment-1207238066 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [lucene-jira-archive] mocobeta commented on issue #126: Show small attachments and images inline

2022-08-06 Thread GitBox
mocobeta commented on issue #126: URL: https://github.com/apache/lucene-jira-archive/issues/126#issuecomment-1207237106 I think I'll open two PRs against this issue - one for patches and one for orphaned images that are not mentioned in any comments. -- This is an automated message from

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #131: Create hyperlinks to other ASF projects for PRJ-XXXX style cross-issue links.

2022-08-06 Thread GitBox
mikemccand commented on PR #131: URL: https://github.com/apache/lucene-jira-archive/pull/131#issuecomment-1207237084 Hi, did you test on a few issues? Hard to parse these regexps! But the change looks good to me. I wonder if any of these projects that we may link to have also migra

[GitHub] [lucene-jira-archive] mocobeta commented on issue #123: Consider removing "Legacy JIRA" from the issue descriptions

2022-08-06 Thread GitBox
mocobeta commented on issue #123: URL: https://github.com/apache/lucene-jira-archive/issues/123#issuecomment-1207236874 #128 was merged - I'm closing this. Thanks @vlsi and @mikemccand for your suggestions. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene-jira-archive] mocobeta closed issue #123: Consider removing "Legacy JIRA" from the issue descriptions

2022-08-06 Thread GitBox
mocobeta closed issue #123: Consider removing "Legacy JIRA" from the issue descriptions URL: https://github.com/apache/lucene-jira-archive/issues/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene-jira-archive] mocobeta closed issue #122: Consider removing "Legacy Jira: by" prefix from comments

2022-08-06 Thread GitBox
mocobeta closed issue #122: Consider removing "Legacy Jira: by" prefix from comments URL: https://github.com/apache/lucene-jira-archive/issues/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene-jira-archive] mocobeta commented on issue #122: Consider removing "Legacy Jira: by" prefix from comments

2022-08-06 Thread GitBox
mocobeta commented on issue #122: URL: https://github.com/apache/lucene-jira-archive/issues/122#issuecomment-1207236845 #128 was merged - I'm closing this. Thanks @vlsi and @mikemccand for your suggestions. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene-jira-archive] mocobeta commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207235887 Addressed in #131. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #131: Create hyperlinks to other ASF projects for PRJ-XXXX style cross-issue links.

2022-08-06 Thread GitBox
mocobeta commented on PR #131: URL: https://github.com/apache/lucene-jira-archive/pull/131#issuecomment-1207235784 For example, this contains lots of links to SOLR. https://github.com/mocobeta/migration-test-3/issues/560 And this contains a few links to INFRA. https://github.com

[GitHub] [lucene-jira-archive] mikemccand commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mikemccand commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207235773 Yeah I'm not proposing we change this approach now. I am proposing we mark both GitHub and Jira read-only during the migration. I think the community would agree, si

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #131: Create hyperlinks to other ASF projects for PRJ-XXXX style cross-issue links.

2022-08-06 Thread GitBox
mocobeta opened a new pull request, #131: URL: https://github.com/apache/lucene-jira-archive/pull/131 Close #129. This captures all Jira issue keys like `{PRJ}-{NUMBER}` in issue descriptions/comments and generates hyperlinks to the issues if the `{PRJ}` is known ASF projects. --

[GitHub] [lucene-jira-archive] mikemccand commented on issue #126: Show small attachments and images inline

2022-08-06 Thread GitBox
mikemccand commented on issue #126: URL: https://github.com/apache/lucene-jira-archive/issues/126#issuecomment-1207235027 > > > I think we cannot determine where to insert the image if the author does not create the link to it? > > > > > > If users do not mention the image, then

[GitHub] [lucene-jira-archive] mocobeta commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207234626 > > If the authors just paste https://issues.apache.org/jira/browse/LUCENE-10661 in an issue, GitHub interprets it's an ordinary hyperlink. It'd be great if we replace it

[GitHub] [lucene-jira-archive] mikemccand merged pull request #128: Refine jira headers in descrition and comments

2022-08-06 Thread GitBox
mikemccand merged PR #128: URL: https://github.com/apache/lucene-jira-archive/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene-jira-archive] mikemccand commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mikemccand commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207233814 > If the authors just paste https://issues.apache.org/jira/browse/LUCENE-10661 in an issue, GitHub interprets it's an ordinary hyperlink. It'd be great if we replace it

[GitHub] [lucene-jira-archive] mikemccand commented on issue #106: Inlined patches don't migrate correctly

2022-08-06 Thread GitBox
mikemccand commented on issue #106: URL: https://github.com/apache/lucene-jira-archive/issues/106#issuecomment-120720 Ahh OK +1 then. We should note that in the known limitations of migration. I'll add it to that doc: https://docs.google.com/document/d/10m6--f7vbU9OC_SfANN6vbNDvu25CO

[GitHub] [lucene-jira-archive] vlsi commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
vlsi commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207226888 There might be issues.apache.org/-style references, see https://github.com/vlsi/bugzilla2github/issues/7 -- This is an automated message from the Apache Git Service. To res

[GitHub] [lucene-jira-archive] mocobeta commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207226410 If the authors just paste https://issues.apache.org/jira/browse/LUCENE-10661 in an issue, GitHub interprets it's an ordinary hyperlink. It'd be great if we replace it wit

[GitHub] [lucene-jira-archive] mocobeta commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207225166 > Do you already recognize URL-links to LUCENE issues and convert them to "github issue + jira fallback"? No - we do not touch URL-style links to LUCENE (or other p

[GitHub] [lucene-jira-archive] vlsi commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
vlsi commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207223302 >GitHub properly recognizes URLs and automatically generates links for them. Just to double-check. Do you already recognize URL-links to LUCENE issues and convert them

[GitHub] [lucene-jira-archive] vlsi commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
vlsi commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207223133 > is not too slow. Do you mean `(?:SOLR|LUCENE|...|...)-\d+?` ? In any case, something like `[A-Z]{2,7}-\d+` should be sufficiently fast, and then you could double-c

[GitHub] [lucene-jira-archive] mocobeta commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207223134 For this issue, we need to consider only the "short form"; GitHub properly recognizes URLs and automatically generates links for them. -- This is an automated message f

[GitHub] [lucene-jira-archive] vlsi commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
vlsi commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207222737 Just in case: the links might come in multiple flavours. For instance: * short form: `SOLR-2355` * URL: `https://issues.apache.org/jira/projects/ARTEMIS/issues/ART

[GitHub] [lucene-jira-archive] mocobeta commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207222671 Thanks! I'll try to include all Jira projects - if the regex to capture issue keys is not too slow. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [lucene-jira-archive] vlsi commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
vlsi commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207222313 See https://issues.apache.org/jira/rest/api/latest/project -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [lucene-jira-archive] mocobeta commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207221972 > What if you export all the ASF project names and cross-link them? Can we export all ASF projects? I'm not really familiar with Jira APIs. -- This is an automate

[GitHub] [lucene-jira-archive] vlsi commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
vlsi commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207221618 What if you export all the ASF project names and cross-link them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [lucene-jira-archive] mocobeta commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207219901 - PyLucene: https://issues.apache.org/jira/projects/PYLUCENE - Open Relevance: https://issues.apache.org/jira/projects/ORP - Solr: https://issues.apache.org/jira/proj

[GitHub] [lucene-jira-archive] mocobeta commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207218732 I don't think we should cover all ASF Jira projects, but we can list all related projects to Lucene. ![Screenshot from 2022-08-06 22-50-26](https://user-images.git

[GitHub] [lucene-jira-archive] mocobeta commented on issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
mocobeta commented on issue #124: URL: https://github.com/apache/lucene-jira-archive/issues/124#issuecomment-1207213143 Addressed in #130. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [lucene-jira-archive] mocobeta merged pull request #130: Place github issue link first

2022-08-06 Thread GitBox
mocobeta merged PR #130: URL: https://github.com/apache/lucene-jira-archive/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #130: Place github issue link first

2022-08-06 Thread GitBox
mocobeta commented on PR #130: URL: https://github.com/apache/lucene-jira-archive/pull/130#issuecomment-1207213022 It's a trivial format change, I'd merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #130: Place github issue link first

2022-08-06 Thread GitBox
mocobeta opened a new pull request, #130: URL: https://github.com/apache/lucene-jira-archive/pull/130 Suggested in #124 See https://github.com/mocobeta/migration-test-3/issues/544. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta opened a new issue, #129: URL: https://github.com/apache/lucene-jira-archive/issues/129 For example, there are cross-issue links such as `SOLR-`, `INFRA-`, or `LEGAL-`. At least we can/should create links to frequent projects in Lucene? -- This is an automated messag

[GitHub] [lucene-jira-archive] mocobeta commented on issue #123: Consider removing "Legacy JIRA" from the issue descriptions

2022-08-06 Thread GitBox
mocobeta commented on issue #123: URL: https://github.com/apache/lucene-jira-archive/issues/123#issuecomment-1207209332 Addressed in #128. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [lucene-jira-archive] mocobeta commented on issue #122: Consider removing "Legacy Jira: by" prefix from comments

2022-08-06 Thread GitBox
mocobeta commented on issue #122: URL: https://github.com/apache/lucene-jira-archive/issues/122#issuecomment-1207209281 Addressed in #128. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #128: Refine jira headers in descrition and comments

2022-08-06 Thread GitBox
mocobeta opened a new pull request, #128: URL: https://github.com/apache/lucene-jira-archive/pull/128 Suggested in #122 and #123. - Remove "Legacy Jira" header from issue description. Instead, add "Migrated from" before Jira key (link) - Shorten comment header (remove created and u

[GitHub] [lucene-jira-archive] mocobeta commented on issue #127: Consider using GitHub Pages for attachments rather than raw.githubusercontent.com

2022-08-06 Thread GitBox
mocobeta commented on issue #127: URL: https://github.com/apache/lucene-jira-archive/issues/127#issuecomment-1207203014 > GitHub pages is a self-service thing. See "GitHub Pages" in https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features I didn't notice it, thanks

[GitHub] [lucene-jira-archive] vlsi commented on issue #127: Consider using GitHub Pages for attachments rather than raw.githubusercontent.com

2022-08-06 Thread GitBox
vlsi commented on issue #127: URL: https://github.com/apache/lucene-jira-archive/issues/127#issuecomment-1207202628 > I think we need to ask ASF infra I do not think so. GitHub pages is a self-service thing. See "GitHub Pages" in https://cwiki.apache.org/confluence/display/INFRA/

[GitHub] [lucene-jira-archive] mocobeta commented on issue #127: Consider using GitHub Pages for attachments rather than raw.githubusercontent.com

2022-08-06 Thread GitBox
mocobeta commented on issue #127: URL: https://github.com/apache/lucene-jira-archive/issues/127#issuecomment-1207201764 Thanks, GitHub pages are actually scalable. I think we need to ask ASF infra (GitHub pages are per user/organization). -- This is an automated message from the Apache G

[GitHub] [lucene-jira-archive] mocobeta commented on issue #126: Show small attachments and images inline

2022-08-06 Thread GitBox
mocobeta commented on issue #126: URL: https://github.com/apache/lucene-jira-archive/issues/126#issuecomment-1207200567 > > I think we cannot determine where to insert the image if the author does not create the link to it? > > If users do not mention the image, then the image should

[GitHub] [lucene-jira-archive] vlsi commented on issue #126: Show small attachments and images inline

2022-08-06 Thread GitBox
vlsi commented on issue #126: URL: https://github.com/apache/lucene-jira-archive/issues/126#issuecomment-1207199987 > I think we cannot determine where to insert the image if the author does not create the link to it? If users do not mention the image, then the image should probably

[GitHub] [lucene-jira-archive] mocobeta commented on issue #126: Show small attachments and images inline

2022-08-06 Thread GitBox
mocobeta commented on issue #126: URL: https://github.com/apache/lucene-jira-archive/issues/126#issuecomment-1207199512 The reason the image in this issue is not shown inline, the author attached the image but did not create a link to it - I think we cannot determine where to insert the im

[GitHub] [lucene-jira-archive] mocobeta commented on issue #126: Show small attachments and images inline

2022-08-06 Thread GitBox
mocobeta commented on issue #126: URL: https://github.com/apache/lucene-jira-archive/issues/126#issuecomment-1207198390 It's really cool to show the patch in the colored diff. As for images, we have already shown them inline in the comments (without `alt`). https://github.com/moco

[GitHub] [lucene-jira-archive] mocobeta commented on issue #122: Consider removing "Legacy Jira: by" prefix from comments

2022-08-06 Thread GitBox
mocobeta commented on issue #122: URL: https://github.com/apache/lucene-jira-archive/issues/122#issuecomment-1207195977 OK makes sense to me, I'll change the header like this. Yuting Gan (@ Yuti-G) ([migrated from JIRA](https://issues.apache.org/jira/browse/LUCENE-10644?focusedCommen

[GitHub] [lucene-jira-archive] mocobeta commented on issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
mocobeta commented on issue #124: URL: https://github.com/apache/lucene-jira-archive/issues/124#issuecomment-1207195604 OK, the change would be easy - I'll update the conversion script. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [lucene-jira-archive] mocobeta commented on issue #106: Inlined patches don't migrate correctly

2022-08-06 Thread GitBox
mocobeta commented on issue #106: URL: https://github.com/apache/lucene-jira-archive/issues/106#issuecomment-1207195204 @mikemccand sorry, I didn't mean we should close this - I think it'd be better to keep open (forever) to show what cannot be done in this migration. -- This is an autom

[GitHub] [lucene-jira-archive] mikemccand closed issue #106: Inlined patches don't migrate correctly

2022-08-06 Thread GitBox
mikemccand closed issue #106: Inlined patches don't migrate correctly URL: https://github.com/apache/lucene-jira-archive/issues/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [lucene-jira-archive] mikemccand commented on issue #106: Inlined patches don't migrate correctly

2022-08-06 Thread GitBox
mikemccand commented on issue #106: URL: https://github.com/apache/lucene-jira-archive/issues/106#issuecomment-1207194996 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [lucene-jira-archive] mikemccand commented on issue #96: Some user references don't convert?

2022-08-06 Thread GitBox
mikemccand commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1207194931 Yes, sorry for the delay! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene-jira-archive] mikemccand closed issue #96: Some user references don't convert?

2022-08-06 Thread GitBox
mikemccand closed issue #96: Some user references don't convert? URL: https://github.com/apache/lucene-jira-archive/issues/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene-jira-archive] mikemccand commented on issue #104: Should we regenerate another full export?

2022-08-06 Thread GitBox
mikemccand commented on issue #104: URL: https://github.com/apache/lucene-jira-archive/issues/104#issuecomment-1207194850 Thanks @mocobeta. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [lucene-jira-archive] vlsi commented on issue #126: Show small attachments and images inline

2022-08-06 Thread GitBox
vlsi commented on issue #126: URL: https://github.com/apache/lucene-jira-archive/issues/126#issuecomment-1207194439 > Would we need to load the image and check its size before doing so? Here's a sample issue with big screenshots: https://github.com/vlsi/tmp-jmeter-issues/issues/4743

[GitHub] [lucene-jira-archive] vlsi commented on issue #126: Show small attachments and images inline

2022-08-06 Thread GitBox
vlsi commented on issue #126: URL: https://github.com/apache/lucene-jira-archive/issues/126#issuecomment-1207194067 The markup there "diff language": Preview of ```BUG_42248.patch```: ```diff Index: src/core/org/apache/jmeter/gui/GuiPackage.java ==

[GitHub] [lucene-jira-archive] mikemccand commented on issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
mikemccand commented on issue #124: URL: https://github.com/apache/lucene-jira-archive/issues/124#issuecomment-1207193836 +1 to make the GItHub link prominent (first link) and then legacy Jira link after. I agree we should design this for ease-of-use in a GitHub world. -- This is

[GitHub] [lucene-jira-archive] vlsi commented on issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
vlsi commented on issue #124: URL: https://github.com/apache/lucene-jira-archive/issues/124#issuecomment-1207193708 > Jira issues to GitHub while preserving the original contents as far as possible In the new world, you would have GitHub issues only, and new issues would reference o

[GitHub] [lucene-jira-archive] mikemccand commented on issue #126: Show small attachments and images inline

2022-08-06 Thread GitBox
mikemccand commented on issue #126: URL: https://github.com/apache/lucene-jira-archive/issues/126#issuecomment-1207193639 Whoa, I love the color on that inlined patch @vlsi! Does GitHub just auto-detect a diff/patch inside a ``` block? If the original Jira commenter/author inlined t

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207193324 Current two-pass migration is carefully considered and safe, and there is no risk; though I admit it's a bit complicated. I don't think we should change the two-pass migratio

[GitHub] [lucene-jira-archive] mocobeta commented on issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
mocobeta commented on issue #124: URL: https://github.com/apache/lucene-jira-archive/issues/124#issuecomment-1207192781 Thanks for your suggestion. I considered the implications and effects of this change. I'd prefer the current format - "Linked issues" or "Sub-tasks" are not GitHub

[GitHub] [lucene-jira-archive] mikemccand commented on issue #122: Consider removing "Legacy Jira: by" prefix from comments

2022-08-06 Thread GitBox
mikemccand commented on issue #122: URL: https://github.com/apache/lucene-jira-archive/issues/122#issuecomment-1207192509 > The date is already present in GitHub UI, so duplicating it does not add much. +1, I like that. It can just say "migrated from Jira" (no need to say comment/d

[GitHub] [lucene-jira-archive] mikemccand commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mikemccand commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207192249 > > I think it should be able to prevent creating issues and PRs during the import: > > Personally, I wish we could temporarily stop all new issues/PRs during migrat

[GitHub] [lucene-jira-archive] vlsi commented on issue #122: Consider removing "Legacy Jira: by" prefix from comments

2022-08-06 Thread GitBox
vlsi commented on issue #122: URL: https://github.com/apache/lucene-jira-archive/issues/122#issuecomment-1207191411 How about changing from [Legacy Jira: by Yuting Gan (@ Yuti-G) on [Jul 10 2022](https://issues.apache.org/jira/browse/LUCENE-10644?focusedCommentId=17564642&page=com.at

[GitHub] [lucene-jira-archive] mocobeta commented on issue #122: Consider removing "Legacy Jira: by" prefix from comments

2022-08-06 Thread GitBox
mocobeta commented on issue #122: URL: https://github.com/apache/lucene-jira-archive/issues/122#issuecomment-1207190807 > we need to convey this was a migrated comment to future people who didn't even know we did this issue migration. Maybe "Prior Jira: "? "Migrated Jira: "? I'm also

  1   2   >