mikemccand commented on issue #126: URL: https://github.com/apache/lucene-jira-archive/issues/126#issuecomment-1207193639
Whoa, I love the color on that inlined patch @vlsi! Does GitHub just auto-detect a diff/patch inside a ``` block? If the original Jira commenter/author inlined the image, it should be carried over as inlined. But if not, this is a bit tricky to just insert? Would we just append the `<img ...>` at the end of the comment? Would we need to load the image and check its size before doing so? Would we thumbnail it if it's too large, or just skip it. In general we have taken the approach of preserving how the original Jira author entered the comment and not trying (too hard) to improve the comment on import. But I agree this would be nice icing on the cake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
