msokolov commented on PR #955: URL: https://github.com/apache/lucene/pull/955#issuecomment-1207305478
I'm not sure why this is easier or cleaner. To me it seems to create an unneccessary intermediate class, just for the purpose of passing parameters. Perhaps if we were trying to load parameters from a file or some other configuration storage, such a class might be useful. But then I think that class really belongs in the system that manages the properties or configuration, and can easily enough call these methods with the config class's members? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
