[jira] [Created] (LUCENE-10615) Add license information for SmartChineseAnalyzer to NOTICE.txt

2022-06-13 Thread Jan Dornseifer (Jira)
Jan Dornseifer created LUCENE-10615: --- Summary: Add license information for SmartChineseAnalyzer to NOTICE.txt Key: LUCENE-10615 URL: https://issues.apache.org/jira/browse/LUCENE-10615 Project: Lucen

[jira] [Commented] (LUCENE-10598) SortedSetDocValues#docValueCount() should be always greater than zero

2022-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553895#comment-17553895 ] ASF subversion and git services commented on LUCENE-10598: -- Co

[GitHub] [lucene] LuXugang merged pull request #942: LUCENE-10598: Use count to record docValueCount similar to SortedNumericDocValues did

2022-06-13 Thread GitBox
LuXugang merged PR #942: URL: https://github.com/apache/lucene/pull/942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-13 Thread GitBox
shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1154701271 I pushed some more cleanups and minor refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] mdmarshmallow commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-13 Thread GitBox
mdmarshmallow commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1154629173 I agree with Greg, we should not let benchmarking block releasing this. I pushed a commit to remove the `byte[]` matches API -- This is an automated message from the Apache Git Servi

[GitHub] [lucene] gsmiller commented on a diff in pull request #914: LUCENE-10550: Add getAllChildren functionality to facets

2022-06-13 Thread GitBox
gsmiller commented on code in PR #914: URL: https://github.com/apache/lucene/pull/914#discussion_r896240300 ## lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java: ## @@ -346,6 +346,43 @@ private void increment(long value) { } } + @Override + publ

[jira] [Created] (LUCENE-10614) Properly support getTopChildren in RangeFacetCounts

2022-06-13 Thread Greg Miller (Jira)
Greg Miller created LUCENE-10614: Summary: Properly support getTopChildren in RangeFacetCounts Key: LUCENE-10614 URL: https://issues.apache.org/jira/browse/LUCENE-10614 Project: Lucene - Core

[GitHub] [lucene] jtibshirani commented on pull request #956: Make sure KnnVectorQuery applies search boost

2022-06-13 Thread GitBox
jtibshirani commented on PR #956: URL: https://github.com/apache/lucene/pull/956#issuecomment-1154554441 Thank you @mocobeta for leading the change to allow GitHub issues in CHANGES.txt -- this was very convenient to fix compared to before. -- This is an automated message from the Apache

[GitHub] [lucene] jtibshirani opened a new pull request, #956: Make sure KnnVectorQuery applies search boost

2022-06-13 Thread GitBox
jtibshirani opened a new pull request, #956: URL: https://github.com/apache/lucene/pull/956 Before, the rewritten query DocAndScoreQuery ignored the boost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] gsmiller commented on pull request #954: LUCENE-10603: Change iteration methodology for SSDV ordinals in the f…

2022-06-13 Thread GitBox
gsmiller commented on PR #954: URL: https://github.com/apache/lucene/pull/954#issuecomment-1154550479 @jpountz: > plus there may be lots of users doing old-style iteration so we'll need to deprecate and maybe only clean this up in 10.0 or 11.0 Right, makes sense. > But I'm c

[GitHub] [lucene] jtibshirani commented on a diff in pull request #951: LUCENE-10606: Optimize Prefilter Hit Collection

2022-06-13 Thread GitBox
jtibshirani commented on code in PR #951: URL: https://github.com/apache/lucene/pull/951#discussion_r896012687 ## lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java: ## @@ -92,20 +91,40 @@ public KnnVectorQuery(String field, float[] target, int k, Query filter) {

[GitHub] [lucene] shahrs87 commented on a diff in pull request #907: LUCENE-10357 Ghost fields and postings/points

2022-06-13 Thread GitBox
shahrs87 commented on code in PR #907: URL: https://github.com/apache/lucene/pull/907#discussion_r896006974 ## lucene/codecs/src/java/org/apache/lucene/codecs/bloom/BloomFilteringPostingsFormat.java: ## @@ -200,8 +200,8 @@ public Terms terms(String field) throws IOException {

[GitHub] [lucene] dweiss commented on a diff in pull request #927: LUCENE-10151: Adding Timeout Support to IndexSearcher

2022-06-13 Thread GitBox
dweiss commented on code in PR #927: URL: https://github.com/apache/lucene/pull/927#discussion_r895987477 ## build.gradle: ## @@ -183,3 +183,5 @@ apply from: file('gradle/hacks/turbocharge-jvm-opts.gradle') apply from: file('gradle/hacks/dummy-outputs.gradle') apply from: fi

[jira] [Commented] (LUCENE-10613) Clean up outdated NOTICE.txt information concerning morfologik

2022-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553740#comment-17553740 ] ASF subversion and git services commented on LUCENE-10613: -- Co

[jira] [Commented] (LUCENE-10613) Clean up outdated NOTICE.txt information concerning morfologik

2022-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553741#comment-17553741 ] ASF subversion and git services commented on LUCENE-10613: -- Co

[jira] [Resolved] (LUCENE-10613) Clean up outdated NOTICE.txt information concerning morfologik

2022-06-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10613. -- Assignee: Dawid Weiss Resolution: Fixed > Clean up outdated NOTICE.txt information conc

[GitHub] [lucene] Deepika0510 commented on a diff in pull request #927: LUCENE-10151: Adding Timeout Support to IndexSearcher

2022-06-13 Thread GitBox
Deepika0510 commented on code in PR #927: URL: https://github.com/apache/lucene/pull/927#discussion_r895985779 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -766,18 +778,29 @@ protected void search(List leaves, Weight weight, Collector c }

[jira] [Updated] (LUCENE-10613) Clean up outdated NOTICE.txt information concerning morfologik

2022-06-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10613: - Fix Version/s: 9.3 > Clean up outdated NOTICE.txt information concerning morfologik > -

[jira] [Updated] (LUCENE-10613) Clean up outdated NOTICE.txt information concerning morfologik

2022-06-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10613: - Description: It's been pointed out to me that NOTICE.txt contains information about licensing t

[jira] [Created] (LUCENE-10613) Clean up outdated NOTICE.txt information concerning morfologik

2022-06-13 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10613: Summary: Clean up outdated NOTICE.txt information concerning morfologik Key: LUCENE-10613 URL: https://issues.apache.org/jira/browse/LUCENE-10613 Project: Lucene - Co

[GitHub] [lucene] shahrs87 commented on pull request #897: LUCENE-10266 Move nearest-neighbor search on points to core

2022-06-13 Thread GitBox
shahrs87 commented on PR #897: URL: https://github.com/apache/lucene/pull/897#issuecomment-1154177806 Thank you @jpountz for the review and merge. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] jpountz commented on pull request #954: LUCENE-10603: Change iteration methodology for SSDV ordinals in the f…

2022-06-13 Thread GitBox
jpountz commented on PR #954: URL: https://github.com/apache/lucene/pull/954#issuecomment-1154152474 We'll have to wait to clean up indeed, plus there may be lots of users doing old-style iteration so we'll need to deprecate and maybe only clean this up in 10.0 or 11.0. But I'm curious of t

[GitHub] [lucene] gsmiller commented on pull request #954: LUCENE-10603: Change iteration methodology for SSDV ordinals in the f…

2022-06-13 Thread GitBox
gsmiller commented on PR #954: URL: https://github.com/apache/lucene/pull/954#issuecomment-1154150491 @jpountz +1 to testing this. Good call! Since I only tackled a subset of code accessing `NO_MORE_DOCS`, I think we'll have to wait to clean this up and test though right? -- This is an a

[jira] [Commented] (LUCENE-10078) Enable merge-on-refresh by default?

2022-06-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553697#comment-17553697 ] Adrien Grand commented on LUCENE-10078: --- As expected, this slowed down refresh la

[jira] [Resolved] (LUCENE-10266) Move nearest-neighbor search on points to core?

2022-06-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10266. --- Fix Version/s: 10.0 (main) Resolution: Fixed > Move nearest-neighbor search on point

[GitHub] [lucene] jpountz merged pull request #897: LUCENE-10266 Move nearest-neighbor search on points to core

2022-06-13 Thread GitBox
jpountz merged PR #897: URL: https://github.com/apache/lucene/pull/897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[GitHub] [lucene] jpountz commented on pull request #897: LUCENE-10266 Move nearest-neighbor search on points to core

2022-06-13 Thread GitBox
jpountz commented on PR #897: URL: https://github.com/apache/lucene/pull/897#issuecomment-1154147639 Thanks @shahrs87 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[jira] [Commented] (LUCENE-10266) Move nearest-neighbor search on points to core?

2022-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553702#comment-17553702 ] ASF subversion and git services commented on LUCENE-10266: -- Co

[jira] [Commented] (LUCENE-10527) Use bigger maxConn for last layer in HNSW

2022-06-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553699#comment-17553699 ] Adrien Grand commented on LUCENE-10527: --- I pushed an annotation to nightly benchm

[GitHub] [lucene] gsmiller commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-13 Thread GitBox
gsmiller commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1154143249 Ah, sorry... I accidentally hit the "close" button! My bad. Reopened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [lucene] gsmiller closed pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-13 Thread GitBox
gsmiller closed pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities URL: https://github.com/apache/lucene/pull/841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [lucene] gsmiller commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-13 Thread GitBox
gsmiller commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1154142817 > Anyway, let's benchmark it, but with the analysis above, I also agree we should actually start with the long[] API, and replace it with a byte[] one only if actually performs better.

[jira] [Commented] (LUCENE-10611) KnnVectorQuery throwing Heap Error for Restrictive Filters

2022-06-13 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553675#comment-17553675 ] Julie Tibshirani commented on LUCENE-10611: --- Thanks for catching this [~kaiva

[GitHub] [lucene-solr] anshumg merged pull request #2663: SOLR-16218: Fix bug in in-place update when failOnVersionConflicts=false

2022-06-13 Thread GitBox
anshumg merged PR #2663: URL: https://github.com/apache/lucene-solr/pull/2663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] msokolov commented on a diff in pull request #927: LUCENE-10151: Adding Timeout Support to IndexSearcher

2022-06-13 Thread GitBox
msokolov commented on code in PR #927: URL: https://github.com/apache/lucene/pull/927#discussion_r895817658 ## build.gradle: ## @@ -183,3 +183,5 @@ apply from: file('gradle/hacks/turbocharge-jvm-opts.gradle') apply from: file('gradle/hacks/dummy-outputs.gradle') apply from:

[GitHub] [lucene-solr] anshumg opened a new pull request, #2663: SOLR-16218: Fix bug in in-place update when failOnVersionConflicts=false

2022-06-13 Thread GitBox
anshumg opened a new pull request, #2663: URL: https://github.com/apache/lucene-solr/pull/2663 Added more people to CHANGES to include folks who contributed to reviewing this fix. Will updated the CHANGES in main and 9x too. -- This is an automated message from the Apache Git Service. To

[jira] [Comment Edited] (LUCENE-10612) Add parameters for HNSW codec in Lucene93Codec

2022-06-13 Thread Elia Porciani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553593#comment-17553593 ] Elia Porciani edited comment on LUCENE-10612 at 6/13/22 1:54 PM:

[jira] [Comment Edited] (LUCENE-10612) Add parameters for HNSW codec in Lucene93Codec

2022-06-13 Thread Elia Porciani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553593#comment-17553593 ] Elia Porciani edited comment on LUCENE-10612 at 6/13/22 1:54 PM:

[jira] [Commented] (LUCENE-10612) Add parameters for HNSW codec in Lucene93Codec

2022-06-13 Thread Elia Porciani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553593#comment-17553593 ] Elia Porciani commented on LUCENE-10612: However, I understand the concern abou

[GitHub] [lucene] eliaporciani opened a new pull request, #955: LUCENE-10612: Introduced Lucene93CodecParameters for Lucene93Codec

2022-06-13 Thread GitBox
eliaporciani opened a new pull request, #955: URL: https://github.com/apache/lucene/pull/955 https://issues.apache.org/jira/browse/LUCENE-10612 # Description Lucene93Codec should provide a way for providing custom parameters to HnswVectorsFormat # Solution For providi

[jira] [Commented] (LUCENE-8193) Deprecate LowercaseTokenizer

2022-06-13 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553541#comment-17553541 ] Andras Salamon commented on LUCENE-8193: This looks like a duplicate of LUCENE-8

[jira] [Commented] (LUCENE-10612) Add parameters for HNSW codec in Lucene93Codec

2022-06-13 Thread Elia Porciani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553518#comment-17553518 ] Elia Porciani commented on LUCENE-10612: Actually, the change I'm proposing is

[jira] [Commented] (LUCENE-10612) Add parameters for HNSW codec in Lucene93Codec

2022-06-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553499#comment-17553499 ] Adrien Grand commented on LUCENE-10612: --- We have been rejecting such requests in

[jira] [Created] (LUCENE-10612) Add parameters for HNSW codec in Lucene93Codec

2022-06-13 Thread Elia Porciani (Jira)
Elia Porciani created LUCENE-10612: -- Summary: Add parameters for HNSW codec in Lucene93Codec Key: LUCENE-10612 URL: https://issues.apache.org/jira/browse/LUCENE-10612 Project: Lucene - Core

[jira] [Commented] (LUCENE-10480) Specialize 2-clauses disjunctions

2022-06-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553494#comment-17553494 ] Adrien Grand commented on LUCENE-10480: --- Good question, looking at your BlockMaxM

[GitHub] [lucene] jpountz commented on a diff in pull request #950: LUCENE-10608: Implement Weight#count on pure conjunctions.

2022-06-13 Thread GitBox
jpountz commented on code in PR #950: URL: https://github.com/apache/lucene/pull/950#discussion_r895527360 ## lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java: ## @@ -344,6 +344,45 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOException {

[GitHub] [lucene] jpountz commented on a diff in pull request #950: LUCENE-10608: Implement Weight#count on pure conjunctions.

2022-06-13 Thread GitBox
jpountz commented on code in PR #950: URL: https://github.com/apache/lucene/pull/950#discussion_r895526857 ## lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java: ## @@ -344,6 +344,45 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOException {

[GitHub] [lucene] jpountz commented on pull request #954: LUCENE-10603: Change iteration methodology for SSDV ordinals in the f…

2022-06-13 Thread GitBox
jpountz commented on PR #954: URL: https://github.com/apache/lucene/pull/954#issuecomment-1153675730 @gsmiller I wonder if you could also test if there is a speed up if we remove checks that the codec has to do in order to make sure to return `NO_MORE_ORDS` when values for a doc are exhaust

[jira] [Updated] (LUCENE-10611) KnnVectorQuery throwing Heap Error for Restrictive Filters

2022-06-13 Thread Kaival Parikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaival Parikh updated LUCENE-10611: --- Description: The HNSW graph search does not consider that visitedLimit may be reached in th

[GitHub] [lucene] jpountz commented on a diff in pull request #951: LUCENE-10606: Optimize Prefilter Hit Collection

2022-06-13 Thread GitBox
jpountz commented on code in PR #951: URL: https://github.com/apache/lucene/pull/951#discussion_r895488795 ## lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java: ## @@ -92,20 +91,40 @@ public KnnVectorQuery(String field, float[] target, int k, Query filter) {

[jira] [Commented] (LUCENE-10611) KnnVectorQuery throwing Heap Error for Restrictive Filters

2022-06-13 Thread Kaival Parikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553467#comment-17553467 ] Kaival Parikh commented on LUCENE-10611: As a fix, we can check if results are

[jira] [Updated] (LUCENE-10611) KnnVectorQuery throwing Heap Error for Restrictive Filters

2022-06-13 Thread Kaival Parikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaival Parikh updated LUCENE-10611: --- Description: The HNSW graph search does not consider that visitedLimit may be reached in th

[jira] [Created] (LUCENE-10611) KnnVectorQuery throwing Heap Error for Restrictive Filters

2022-06-13 Thread Kaival Parikh (Jira)
Kaival Parikh created LUCENE-10611: -- Summary: KnnVectorQuery throwing Heap Error for Restrictive Filters Key: LUCENE-10611 URL: https://issues.apache.org/jira/browse/LUCENE-10611 Project: Lucene - Cor

[jira] [Updated] (LUCENE-10611) KnnVectorQuery throwing Heap Error for Restrictive Filters

2022-06-13 Thread Kaival Parikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaival Parikh updated LUCENE-10611: --- Description: The HNSW graph search does not consider that visitedLimit may be reached in th

[jira] [Commented] (LUCENE-10078) Enable merge-on-refresh by default?

2022-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553416#comment-17553416 ] ASF subversion and git services commented on LUCENE-10078: -- Co

[jira] [Commented] (LUCENE-10078) Enable merge-on-refresh by default?

2022-06-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553417#comment-17553417 ] ASF subversion and git services commented on LUCENE-10078: -- Co