dweiss commented on PR #828:
URL: https://github.com/apache/lucene/pull/828#issuecomment-1106059768
I'm fine with this, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
dweiss commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1106050402
A patch has been accepted in spotless so we can fix this without any hacks
and in a clean way after the next spotless release.
--
This is an automated message from the Apache Git Service.
T
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526207#comment-17526207
]
Dawid Weiss commented on LUCENE-10528:
--
Should we do it for an entire gradle proce
vigyasharma commented on PR #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1106016790
The build failure is on
`TestTaxonomyFacetAssociations.testFloatAssociationRandom`, and I'm unable to
repro it without the randomization seed.
The failure (with randomization see
boicehuang commented on code in PR #816:
URL: https://github.com/apache/lucene/pull/816#discussion_r855737016
##
lucene/core/src/java/org/apache/lucene/util/CloseableThreadLocal.java:
##
@@ -123,12 +122,34 @@ public void close() {
// Clear the hard refs; then, the only rema
mocobeta commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855707897
##
lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java:
##
@@ -73,8 +73,8 @@ public static void main(String[] args) throws Exception {
boolean sanit
rmuir commented on code in PR #829:
URL: https://github.com/apache/lucene/pull/829#discussion_r855707426
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/FilterPath.java:
##
@@ -270,7 +270,7 @@ public static Path unwrap(Path path) {
return Unwrappable.unwr
rmuir commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855703920
##
lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java:
##
@@ -73,8 +73,8 @@ public static void main(String[] args) throws Exception {
boolean sanityCh
sonatype-lift[bot] commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855698844
##
lucene/distribution/src/binary-release/bin/luke.sh:
##
@@ -26,6 +26,11 @@ if [ -z "$LAUNCH_CMD" ]; then
else
# We are integration-testing. Force UTF-8 as
mocobeta commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855698828
##
lucene/distribution/src/binary-release/bin/luke.sh:
##
@@ -26,6 +26,11 @@ if [ -z "$LAUNCH_CMD" ]; then
else
# We are integration-testing. Force UTF-8 as the encodi
sonatype-lift[bot] commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855698579
##
lucene/distribution/src/binary-release/bin/luke.sh:
##
@@ -26,6 +26,11 @@ if [ -z "$LAUNCH_CMD" ]; then
else
# We are integration-testing. Force UTF-8 as
mocobeta commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855698566
##
lucene/distribution/src/binary-release/bin/luke.sh:
##
@@ -26,6 +26,11 @@ if [ -z "$LAUNCH_CMD" ]; then
else
# We are integration-testing. Force UTF-8 as the encodi
sonatype-lift[bot] commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855697891
##
lucene/distribution/src/binary-release/bin/luke.sh:
##
@@ -26,6 +26,11 @@ if [ -z "$LAUNCH_CMD" ]; then
else
# We are integration-testing. Force UTF-8 as
sonatype-lift[bot] commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855697073
##
lucene/distribution/src/binary-release/bin/luke.sh:
##
@@ -26,6 +26,11 @@ if [ -z "$LAUNCH_CMD" ]; then
else
# We are integration-testing. Force UTF-8 as
mocobeta commented on PR #828:
URL: https://github.com/apache/lucene/pull/828#issuecomment-1105908107
@rmuir Thanks for updating. I have to go to work but I'll run it on myself
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rmuir commented on PR #828:
URL: https://github.com/apache/lucene/pull/828#issuecomment-1105906958
@mocobeta I updated the patch to move the logic to the launcher, section
where integration tests are handled.
It solves the issue for me on my computer, and it also allows this test to
mocobeta commented on PR #828:
URL: https://github.com/apache/lucene/pull/828#issuecomment-1105901542
Generally, I'd agree with the change, thank you @rmuir. If it'd be
sufficient to make it work only on Linux, I think I can make a final patch. (I
won't be able to make it work on Windows...
rmuir commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855692000
##
lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java:
##
@@ -73,8 +73,8 @@ public static void main(String[] args) throws Exception {
boolean sanityCh
mocobeta commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855687014
##
gradlew:
##
@@ -217,4 +217,8 @@ if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then
cd "$(dirname "$0")"
fi
-exec "$JAVACMD" "$@"
+if command -v xvfb-run >
gautamworah96 opened a new pull request, #829:
URL: https://github.com/apache/lucene/pull/829
In PR (https://github.com/apache/lucene/pull/762) we missed the case where a
tempDir name was using `:` in the dir name. This test was passing in Linux,
MacOS environments but ended up failing in W
mocobeta commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855687014
##
gradlew:
##
@@ -217,4 +217,8 @@ if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then
cd "$(dirname "$0")"
fi
-exec "$JAVACMD" "$@"
+if command -v xvfb-run >
mocobeta commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855685351
##
lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java:
##
@@ -73,8 +73,8 @@ public static void main(String[] args) throws Exception {
boolean sanit
mocobeta commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855685351
##
lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java:
##
@@ -73,8 +73,8 @@ public static void main(String[] args) throws Exception {
boolean sanit
rmuir commented on PR #828:
URL: https://github.com/apache/lucene/pull/828#issuecomment-1105810790
https://github.com/actions/virtual-environments/blob/main/images/linux/toolsets/toolset-2004.json#L174
--
This is an automated message from the Apache Git Service.
To respond to the message,
vigyasharma commented on PR #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1105799649
Thanks for reviewing these rather lengthy changes, @mikemccand! I've rebased
this on to the latest main branch, and updated doc string and exception message.
--
This is an automated me
vigyasharma commented on code in PR #633:
URL: https://github.com/apache/lucene/pull/633#discussion_r855621581
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -3127,143 +3135,307 @@ public long addIndexes(CodecReader... readers) throws
IOException {
vigyasharma commented on code in PR #633:
URL: https://github.com/apache/lucene/pull/633#discussion_r855621445
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -3121,147 +3125,265 @@ private void validateMergeReader(CodecReader leaf) {
*/
public lon
rmuir commented on PR #828:
URL: https://github.com/apache/lucene/pull/828#issuecomment-1105789160
@dweiss it already works here with our github action without even having to
install anything, looks like xvfb is already on the image.
I think it would be better to not have this logic
rmuir opened a new pull request, #828:
URL: https://github.com/apache/lucene/pull/828
Just gonna play and see if i can get it working with pull request tests
easily. Then we can clean everything up.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
[
https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526082#comment-17526082
]
Mayya Sharipova commented on LUCENE-10527:
--
Great investigation and work, Juli
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526083#comment-17526083
]
Robert Muir commented on LUCENE-10528:
--
Here's the simplest patch that fixes it:
{
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526081#comment-17526081
]
Robert Muir commented on LUCENE-10528:
--
I would prefer autodetecting, since it wou
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526073#comment-17526073
]
Robert Muir edited comment on LUCENE-10528 at 4/21/22 8:43 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526073#comment-17526073
]
Robert Muir commented on LUCENE-10528:
--
I guess i'm just proposing we either:
1. a
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526065#comment-17526065
]
Robert Muir commented on LUCENE-10528:
--
I run slow tests and i'm willing to instal
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526064#comment-17526064
]
Dawid Weiss commented on LUCENE-10528:
--
There are so many layers to awt/swing supp
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526056#comment-17526056
]
Robert Muir commented on LUCENE-10528:
--
Could the test on *nix look for the presen
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526054#comment-17526054
]
Robert Muir commented on LUCENE-10528:
--
sure, but does it need to display real win
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526050#comment-17526050
]
Dawid Weiss commented on LUCENE-10528:
--
Hmm... But we want to run this test occasi
[
https://issues.apache.org/jira/browse/LUCENE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526044#comment-17526044
]
Dawid Weiss commented on LUCENE-10521:
--
I'm not familiar with the code (or the tes
[
https://issues.apache.org/jira/browse/LUCENE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526002#comment-17526002
]
Gautam Worah edited comment on LUCENE-10521 at 4/21/22 7:15 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526002#comment-17526002
]
Gautam Worah commented on LUCENE-10521:
---
Welp, I thought about this a bit and the
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525999#comment-17525999
]
Robert Muir commented on LUCENE-10528:
--
One option, we could unset DISPLAY in the
Robert Muir created LUCENE-10528:
Summary: TestScripts.testLukeCanBeLaunched creates X Window when
running the tests
Key: LUCENE-10528
URL: https://issues.apache.org/jira/browse/LUCENE-10528
Project:
rmuir commented on code in PR #827:
URL: https://github.com/apache/lucene/pull/827#discussion_r855426589
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##
@@ -1112,12 +1112,17 @@ public void seekExact(long ord) throws IOException {
rmuir commented on code in PR #827:
URL: https://github.com/apache/lucene/pull/827#discussion_r855425060
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##
@@ -1112,12 +1112,17 @@ public void seekExact(long ord) throws IOException {
jpountz commented on PR #701:
URL: https://github.com/apache/lucene-solr/pull/701#issuecomment-1105489271
I have some interest in this change too so I ported it to the current codec
in a way that looks a bit less invasive as suggested above:
https://github.com/apache/lucene/pull/827
--
T
[
https://issues.apache.org/jira/browse/LUCENE-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10517.
---
Fix Version/s: 9.2
Resolution: Fixed
> Improve performance of SortedSetDV faceting b
[
https://issues.apache.org/jira/browse/LUCENE-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525846#comment-17525846
]
ASF subversion and git services commented on LUCENE-10517:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525839#comment-17525839
]
ASF subversion and git services commented on LUCENE-10517:
--
Co
jpountz merged PR #812:
URL: https://github.com/apache/lucene/pull/812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
jpountz merged PR #826:
URL: https://github.com/apache/lucene/pull/826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
[
https://issues.apache.org/jira/browse/LUCENE-10509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525780#comment-17525780
]
Robert Muir commented on LUCENE-10509:
--
maybe consider using a database instead of
[
https://issues.apache.org/jira/browse/LUCENE-10509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525767#comment-17525767
]
Rajesh T commented on LUCENE-10509:
---
Our usecase requires fetching document ids of *A
ChrisHegarty commented on PR #812:
URL: https://github.com/apache/lucene/pull/812#issuecomment-1105295002
>What I'm unsure of is whether we have good coverage for all combinations of
single-valued/multi-valued and no-deletes/with-deletes.
Running code coverage shows that there are so
ChrisHegarty commented on PR #812:
URL: https://github.com/apache/lucene/pull/812#issuecomment-1105295000
>What I'm unsure of is whether we have good coverage for all combinations of
single-valued/multi-valued and no-deletes/with-deletes.
Running code coverage shows that there are so
ChrisHegarty opened a new pull request, #826:
URL: https://github.com/apache/lucene/pull/826
During the review of another PR (which focuses on a specific performance
improvement), see [812][PR812], a question was raised about the test
coverage for the various branches in code. This chan
[
https://issues.apache.org/jira/browse/LUCENE-10509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525723#comment-17525723
]
Robert Muir commented on LUCENE-10509:
--
If you are calling lookupOrd potentially m
rmuir commented on PR #805:
URL: https://github.com/apache/lucene/pull/805#issuecomment-1105209410
I defer to Mike, he understands this Viterbi. I am happy to see this
refactoring, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
mocobeta commented on PR #805:
URL: https://github.com/apache/lucene/pull/805#issuecomment-1105200590
@mikemccand thanks for reviewing such a huge PR!
I'll look through this again, and merge it maybe next week.
@rmuir if you have any comments I'll try to reflect the feedback on this
rmuir merged PR #819:
URL: https://github.com/apache/lucene/pull/819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1105198961
OK let's merge this for now and investigate the properties refactoring as a
separate change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
rmuir commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1105150677
thanks @dweiss !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
rmuir merged PR #817:
URL: https://github.com/apache/lucene/pull/817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or
rmuir commented on code in PR #816:
URL: https://github.com/apache/lucene/pull/816#discussion_r855131404
##
lucene/core/src/java/org/apache/lucene/util/CloseableThreadLocal.java:
##
@@ -123,12 +122,34 @@ public void close() {
// Clear the hard refs; then, the only remaining
[
https://issues.apache.org/jira/browse/LUCENE-10509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525652#comment-17525652
]
Rajesh T edited comment on LUCENE-10509 at 4/21/22 11:59 AM:
mikemccand commented on code in PR #633:
URL: https://github.com/apache/lucene/pull/633#discussion_r830147648
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -3121,147 +3125,265 @@ private void validateMergeReader(CodecReader leaf) {
*/
public long
mikemccand commented on PR #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1105106481
> This method makes sure that incoming index fields are compatible with the
destination index, e.g. vectors have the same dimensions and use the same
similarity function.
>
> Chang
[
https://issues.apache.org/jira/browse/LUCENE-10509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525652#comment-17525652
]
Rajesh T commented on LUCENE-10509:
---
[~jpountz] I have made the change in our custom
boicehuang commented on code in PR #816:
URL: https://github.com/apache/lucene/pull/816#discussion_r854857934
##
lucene/core/src/java/org/apache/lucene/util/CloseableThreadLocal.java:
##
@@ -123,12 +121,27 @@ public void close() {
// Clear the hard refs; then, the only rema
70 matches
Mail list logo
