mikemccand commented on PR #633: URL: https://github.com/apache/lucene/pull/633#issuecomment-1105106481
> This method makes sure that incoming index fields are compatible with the destination index, e.g. vectors have the same dimensions and use the same similarity function. > > Changed access to package private. I retained method name - verifyFieldInfo(), as it internally calls verifySoftDeletedFieldName and verifySameSchema, which have a similar naming style. > > I can change it if assert*() is more in line with the Lucene convention. In which case, I also think that it should only return a condition and the asserts should be done by the caller.. Let me know.. OK let's leave it as `verify` now -- when in Rome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
