rmuir commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855703920
##########
lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java:
##########
@@ -73,8 +73,8 @@ public static void main(String[] args) throws Exception {
boolean sanityCheck = Arrays.asList(args).contains("--sanity-check");
if (sanityCheck && GraphicsEnvironment.isHeadless()) {
- Logger.getGlobal().log(Level.SEVERE, "[Vader] Hello, Luke. Can't do much
in headless mode.");
- Runtime.getRuntime().exit(0);
+ Logger.getGlobal().log(Level.SEVERE, "Hello, Luke. Can't do much in
headless mode.");
+ Runtime.getRuntime().exit(1);
Review Comment:
> I'm afraid that setting up a virtual window environment on every CI server
(every OS) can increase the administrator's load.
Maybe there is a misconception about the cost of this. Xvfb with a single
application costs 57KB of RAM running. We don't need to worry about it. It is
just an X server, it isn't a "desktop environment", there isn't even a window
manager. 50KB :) We happily launch java subprocesses with *hundreds of MB* of
memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
