Yuti-G commented on pull request #747:
URL: https://github.com/apache/lucene/pull/747#issuecomment-1079608718
> This looks good to me at this point. Since this changes the code path for
existing faceting functionality, it would be a good idea to run `luceneutil`
benchmarks and make sure th
Yuti-G commented on a change in pull request #751:
URL: https://github.com/apache/lucene/pull/751#discussion_r835713023
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
##
@@ -348,6 +348,9 @@ private void increment(long value) {
@Overr
[
https://issues.apache.org/jira/browse/LUCENE-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512660#comment-17512660
]
Zach Chen commented on LUCENE-10436:
Hi [~jpountz] , I took a look and created a PR
zacharymorn commented on pull request #767:
URL: https://github.com/apache/lucene/pull/767#issuecomment-1079574848
Quick question: shall I also merge existing test cases from
`TestNormsFieldExistsQuery`, `TestKnnVectorFieldExistsQuery` and
`TestDocValuesFieldExistsQuery` as well ?
--
Th
zacharymorn opened a new pull request #767:
URL: https://github.com/apache/lucene/pull/767
# Description / Solution
Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and
KnnVectorFieldExistsQuery with FieldExistsQuery
# Tests
Passed existing tests (especially `
Tomoko Uchida created LUCENE-10485:
--
Summary: Limit o.a.l.a.morph package visibility only to kuromoji
and nori
Key: LUCENE-10485
URL: https://issues.apache.org/jira/browse/LUCENE-10485
Project: Lucen
[
https://issues.apache.org/jira/browse/LUCENE-10393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-10393.
Fix Version/s: 10.0 (main)
Resolution: Fixed
> Should we unify the dictionary buil
javanna commented on a change in pull request #766:
URL: https://github.com/apache/lucene/pull/766#discussion_r835549312
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/search/FixedBitSetCollector.java
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Sof
javanna opened a new pull request #766:
URL: https://github.com/apache/lucene/pull/766
Some tests collect matching docs in a FixedBitSet. In the effort of moving
such tests to using IndexSearcher#search(Query, CollectorManager) as part of
LUCENE-10002, this commit adds a new FixedBitSetCol
gsmiller commented on a change in pull request #751:
URL: https://github.com/apache/lucene/pull/751#discussion_r835436710
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
##
@@ -348,6 +348,9 @@ private void increment(long value) {
@Ove
javanna removed a comment on pull request #761:
URL: https://github.com/apache/lucene/pull/761#issuecomment-1078818954
the build seems to have gotten stuck, not sure how to unblock it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/LUCENE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-10454:
--
Status: Open (was: Open)
WeightMatches is the default as of 9.0: LUCENE-9431 -- the ramifica
[
https://issues.apache.org/jira/browse/LUCENE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-10454:
--
Attachment: LUCENE-10454-fix.patch
> UnifiedHighlighter can miss terms because of query rewri
[
https://issues.apache.org/jira/browse/LUCENE-10484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luca Cavanna updated LUCENE-10484:
--
Description:
While FacetsCollectorManager exists to allows users to concurrently do facets
c
uschindler commented on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1078879090
FYI, here is this Test (it also checks if all components have factories):
https://github.com/apache/lucene/tree/main/lucene/analysis.tests/src/test/org/apache/lucene/analysis/te
Luca Cavanna created LUCENE-10484:
-
Summary: Add support for concurrent facets random sampling
Key: LUCENE-10484
URL: https://issues.apache.org/jira/browse/LUCENE-10484
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512284#comment-17512284
]
ASF subversion and git services commented on LUCENE-10393:
--
Co
mocobeta merged pull request #740:
URL: https://github.com/apache/lucene/pull/740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
mocobeta commented on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1078835237
@rmuir @uschindler
Thank you for your thorough review! I thought it'd take some more time.
I'm merging it now - I think it'd be better to open a follow-up issue to
make
mocobeta commented on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1078824500
>> I added test modules analysis/kuromoji.tests and analysis/nori.tests to
make sure that both tokenizers correctly load the dictionary resources and work
in module-mode. They a
javanna commented on pull request #761:
URL: https://github.com/apache/lucene/pull/761#issuecomment-1078818954
the build seems to have gotten stuck, not sure how to unblock it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
javanna opened a new pull request #764:
URL: https://github.com/apache/lucene/pull/764
In the effort of decreasing usages of IndexSearcher#search(query, Collector)
by using the corresponding method that accepts a collector manager, this commit
replaces many usages of FacetsCollector with i
uschindler commented on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1078737813
> I added test modules `analysis/kuromoji.tests` and `analysis/nori.tests`
to make sure that both tokenizers correctly load the dictionary resources and
work in module-mode. Th
23 matches
Mail list logo
