Yuti-G commented on pull request #747: URL: https://github.com/apache/lucene/pull/747#issuecomment-1079608718
> This looks good to me at this point. Since this changes the code path for existing faceting functionality, it would be a good idea to run `luceneutil` benchmarks and make sure there are no obvious regressions. I wouldn't suspect there to be, but it would be nice to catch them now if there are. @Yuti-G would you mind posting those results here? Thanks @gsmiller! I ran benchmarks several times but the first 3 taxoFacets tasks are still showing statistically significant, but my code didn’t touch taxonomy faceting. Not sure if this will cause issues. <img width="842" alt="Screen Shot 2022-03-25 at 10 17 26 PM" src="https://user-images.githubusercontent.com/44444710/160225861-fae93347-9b2e-4427-bcc2-f71af224f54f.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
![https://user-images.githubusercontent.com/44444710/160225861-fae93347-9b2e-4427-bcc2-f71af224f54f.png"](https://user-images.githubusercontent.com/44444710/160225861-fae93347-9b2e-4427-bcc2-f71af224f54f.png"){kind=link}