Yuti-G commented on a change in pull request #751:
URL: https://github.com/apache/lucene/pull/751#discussion_r835713023
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
##########
@@ -348,6 +348,9 @@ private void increment(long value) {
@Override
public FacetResult getTopChildren(int topN, String dim, String... path) {
+ if (topN <= 0) {
Review comment:
Hi @gsmiller, thanks for your feedback! Can you elaborate more on what
does open a spin-off issue mean in Lucene? I just added @lucene.experimental in
the new commit. If the community thinks this may not be an improvement in the
long-term, I can close the PR for now and if users have this use case in the
future, they can still see the history in Jira issue. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
