gautamworah96 commented on a change in pull request #658:
URL: https://github.com/apache/lucene/pull/658#discussion_r802364095
##
File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
##
@@ -369,6 +369,54 @@ public Scorer scorer(LeafReaderContext context
jpountz commented on a change in pull request #658:
URL: https://github.com/apache/lucene/pull/658#discussion_r802363166
##
File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
##
@@ -369,6 +369,54 @@ public Scorer scorer(LeafReaderContext context) thro
jpountz commented on a change in pull request #658:
URL: https://github.com/apache/lucene/pull/658#discussion_r802363166
##
File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
##
@@ -369,6 +369,54 @@ public Scorer scorer(LeafReaderContext context) thro
[
https://issues.apache.org/jira/browse/LUCENE-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489287#comment-17489287
]
spike liu commented on LUCENE-10188:
I will work on this.
> Give SortedSetDocValue
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489277#comment-17489277
]
Ignacio Vera commented on LUCENE-10378:
---
The idea is more a BFS over the tree (an
dsmiley commented on a change in pull request #643:
URL: https://github.com/apache/lucene/pull/643#discussion_r802285404
##
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##
@@ -526,4 +526,17 @@ public static void fsync(Path fileToSync, boolean isDir)
thro
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489193#comment-17489193
]
Gautam Worah edited comment on LUCENE-10378 at 2/9/22, 2:45 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489193#comment-17489193
]
Gautam Worah edited comment on LUCENE-10378 at 2/9/22, 2:37 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489193#comment-17489193
]
Gautam Worah edited comment on LUCENE-10378 at 2/9/22, 2:36 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489193#comment-17489193
]
Gautam Worah edited comment on LUCENE-10378 at 2/9/22, 2:08 AM:
-
msokolov commented on pull request #656:
URL: https://github.com/apache/lucene/pull/656#issuecomment-1033247680
> I was thinking we would implement exact search within KnnVectorQuery
itself, instead of exposing it through LeafReader. I think we already have all
the pieces we need through t
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489193#comment-17489193
]
Gautam Worah commented on LUCENE-10378:
---
Another basic question for you folks, si
mayya-sharipova edited a comment on pull request #649:
URL: https://github.com/apache/lucene/pull/649#issuecomment-1033175828
@jtibshirani @jpountz Thanks for your feedback. I've tried to address in
6bf1aea543ddb3d19909a5bc3d9ccbb1b4fcf9e4. I've decided to focus this PR only
on optimizing
mayya-sharipova commented on pull request #649:
URL: https://github.com/apache/lucene/pull/649#issuecomment-1033175828
@jtibshirani @jpountz Thanks for your feedback. I've tried to address in
6bf1aea543ddb3d19909a5bc3d9ccbb1b4fcf9e4. I've decided to focus this PR only
on optimizing the de
mayya-sharipova commented on a change in pull request #649:
URL: https://github.com/apache/lucene/pull/649#discussion_r802152096
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsWriter.java
##
@@ -140,7 +142,10 @@ public void writeField(F
mayya-sharipova commented on a change in pull request #649:
URL: https://github.com/apache/lucene/pull/649#discussion_r802150904
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java
##
@@ -311,7 +313,9 @@ public void close() throw
gautamworah96 commented on a change in pull request #658:
URL: https://github.com/apache/lucene/pull/658#discussion_r802144345
##
File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
##
@@ -369,6 +369,54 @@ public Scorer scorer(LeafReaderContext context
gautamworah96 commented on a change in pull request #658:
URL: https://github.com/apache/lucene/pull/658#discussion_r802144345
##
File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
##
@@ -369,6 +369,54 @@ public Scorer scorer(LeafReaderContext context
gautamworah96 commented on a change in pull request #658:
URL: https://github.com/apache/lucene/pull/658#discussion_r802141959
##
File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
##
@@ -369,6 +369,54 @@ public Scorer scorer(LeafReaderContext context
gautamworah96 commented on a change in pull request #658:
URL: https://github.com/apache/lucene/pull/658#discussion_r802141959
##
File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
##
@@ -369,6 +369,54 @@ public Scorer scorer(LeafReaderContext context
jtibshirani commented on pull request #656:
URL: https://github.com/apache/lucene/pull/656#issuecomment-1033082962
Thanks for reviewing. I'll work on another iteration and ping you when it's
out of "draft" status. One clarification first...
> +1 to expose searchExact and allow the Qu
jtibshirani commented on a change in pull request #656:
URL: https://github.com/apache/lucene/pull/656#discussion_r802075985
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java
##
@@ -253,6 +277,36 @@ public TopDocs search(String
jtibshirani commented on a change in pull request #656:
URL: https://github.com/apache/lucene/pull/656#discussion_r802075310
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java
##
@@ -227,16 +231,36 @@ public TopDocs search(Strin
jtibshirani edited a comment on pull request #656:
URL: https://github.com/apache/lucene/pull/656#issuecomment-1032109021
I tried out the around stopping the HNSW search early if it visits too many
docs. To test, I modified `KnnGraphTester` to create `acceptDocs` uniformly at
random with a
msokolov commented on a change in pull request #656:
URL: https://github.com/apache/lucene/pull/656#discussion_r801992612
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java
##
@@ -253,6 +277,36 @@ public TopDocs search(String fi
[
https://issues.apache.org/jira/browse/LUCENE-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489078#comment-17489078
]
Greg Miller commented on LUCENE-10398:
--
While I haven't looked into what it might
[
https://issues.apache.org/jira/browse/LUCENE-10403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10403.
--
Fix Version/s: 9.1
Resolution: Fixed
Merged into {{branch_9x}} and {{main. Resolving.}
gsmiller closed pull request #661:
URL: https://github.com/apache/lucene/pull/661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489072#comment-17489072
]
ASF subversion and git services commented on LUCENE-10403:
--
Co
gsmiller opened a new pull request #661:
URL: https://github.com/apache/lucene/pull/661
Backporting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489026#comment-17489026
]
ASF subversion and git services commented on LUCENE-10403:
--
Co
gsmiller commented on pull request #644:
URL: https://github.com/apache/lucene/pull/644#issuecomment-1032888391
Thanks for the review @msokolov !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gsmiller merged pull request #644:
URL: https://github.com/apache/lucene/pull/644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nhat Nguyen updated LUCENE-10190:
-
Fix Version/s: 9.1
10.0 (main)
Resolution: Fixed
Status: Re
[
https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489014#comment-17489014
]
ASF subversion and git services commented on LUCENE-10190:
--
Co
dnhatn merged pull request #660:
URL: https://github.com/apache/lucene/pull/660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489013#comment-17489013
]
ASF subversion and git services commented on LUCENE-10190:
--
Co
dnhatn merged pull request #659:
URL: https://github.com/apache/lucene/pull/659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10367.
---
Fix Version/s: 9.1
Resolution: Fixed
> Use WANDScorer in CoveringQuery Can accelerat
[
https://issues.apache.org/jira/browse/LUCENE-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488993#comment-17488993
]
Adrien Grand commented on LUCENE-10367:
---
I pushed your change with some minor mod
[
https://issues.apache.org/jira/browse/LUCENE-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488992#comment-17488992
]
ASF subversion and git services commented on LUCENE-10367:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488991#comment-17488991
]
ASF subversion and git services commented on LUCENE-10367:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-3331.
--
Resolution: Duplicate
This one got fixed long ago. :)
> consider allowing ScorerContext to sp
dnhatn opened a new pull request #660:
URL: https://github.com/apache/lucene/pull/660
DocumentWriter#anyChanges() can return false after we process and
generate a sequence number for an update operation; but before we adjust
the numDocsInRAM. In this window of time, refreshes are noop,
dnhatn opened a new pull request #659:
URL: https://github.com/apache/lucene/pull/659
DocumentWriter#anyChanges() can return false after we process and
generate a sequence number for an update operation; but before we adjust
the numDocsInRAM. In this window of time, refreshes are noop,
[
https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488949#comment-17488949
]
ASF subversion and git services commented on LUCENE-10190:
--
Co
dnhatn merged pull request #640:
URL: https://github.com/apache/lucene/pull/640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
dnhatn commented on pull request #640:
URL: https://github.com/apache/lucene/pull/640#issuecomment-1032734643
Thanks @jpountz.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
jpountz commented on a change in pull request #658:
URL: https://github.com/apache/lucene/pull/658#discussion_r801605478
##
File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
##
@@ -369,6 +369,54 @@ public Scorer scorer(LeafReaderContext context) thro
gf2121 closed pull request #545:
URL: https://github.com/apache/lucene/pull/545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488790#comment-17488790
]
Ignacio Vera edited comment on LUCENE-10378 at 2/8/22, 11:48 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488790#comment-17488790
]
Ignacio Vera edited comment on LUCENE-10378 at 2/8/22, 11:48 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488790#comment-17488790
]
Ignacio Vera edited comment on LUCENE-10378 at 2/8/22, 11:43 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488790#comment-17488790
]
Ignacio Vera commented on LUCENE-10378:
---
Hi Gautam!
Thanks for the PR but you ar
[
https://issues.apache.org/jira/browse/LUCENE-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488718#comment-17488718
]
Gautam Worah commented on LUCENE-10378:
---
Just added a draft PR. It took me a litt
gautamworah96 opened a new pull request #658:
URL: https://github.com/apache/lucene/pull/658
# Description
Implement Weight#count on PointRangeQuery. Also fixed a small style
inconsistency that I noticed
Issue: https://issues.apache.org/jira/browse/LUCENE-10378
[
https://issues.apache.org/jira/browse/LUCENE-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo resolved LUCENE-10410.
---
Fix Version/s: 9.1
Resolution: Fixed
> Add some more tests for legacy encoding logic in DocI
[
https://issues.apache.org/jira/browse/LUCENE-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488700#comment-17488700
]
ASF subversion and git services commented on LUCENE-10410:
--
Co
gf2121 merged pull request #657:
URL: https://github.com/apache/lucene/pull/657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
gf2121 opened a new pull request #657:
URL: https://github.com/apache/lucene/pull/657
Backport of https://github.com/apache/lucene/pull/654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
[
https://issues.apache.org/jira/browse/LUCENE-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488676#comment-17488676
]
ASF subversion and git services commented on LUCENE-10410:
--
Co
gf2121 merged pull request #654:
URL: https://github.com/apache/lucene/pull/654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488607#comment-17488607
]
Feng Guo edited comment on LUCENE-10409 at 2/8/22, 8:15 AM:
Adrien Grand created LUCENE-10411:
-
Summary: Add NN vectors support to ExitableDirectoryReader
Key: LUCENE-10411
URL: https://issues.apache.org/jira/browse/LUCENE-10411
Project: Lucene - Core
jpountz commented on a change in pull request #656:
URL: https://github.com/apache/lucene/pull/656#discussion_r801354469
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java
##
@@ -227,16 +231,36 @@ public TopDocs search(String fi
65 matches
Mail list logo
