dweiss commented on pull request #411:
URL: https://github.com/apache/lucene/pull/411#issuecomment-950587825
So, in other words - the POMs have to be right. If enabling metadata means
we have odd entries in POMs, I'm -1 for adding metadata. The lucene-root
dependency may be a result of how
dweiss commented on pull request #411:
URL: https://github.com/apache/lucene/pull/411#issuecomment-950586805
> This weird lucene-root dependency is only here; it isn't in any of the
other Lucene modules. I confirmed this only appears here because of the use of
this Gradle feature.
T
dweiss commented on pull request #353:
URL: https://github.com/apache/lucene/pull/353#issuecomment-950585341
Because back in the day it didn't work for me and broke downstream maven
builds. If you'd like to check whether things work without it, please remove it
and file a pr. I don't care.
[
https://issues.apache.org/jira/browse/LUCENE-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433565#comment-17433565
]
Julie Tibshirani edited comment on LUCENE-10191 at 10/25/21, 5:29 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433565#comment-17433565
]
Julie Tibshirani commented on LUCENE-10191:
---
This is helpful feedback. I'm al
[
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433549#comment-17433549
]
Animesh Pandey commented on LUCENE-10197:
-
[~dsmiley] I've created a draft PR f
apanimesh061 opened a new pull request #412:
URL: https://github.com/apache/lucene/pull/412
# Description
`UnifiedHighlighter` is not thread-safe due to the presence of setters. We
can move the fields to builder so that the class becomes thread-safe. Objective
is to made `UnifiedHig
dsmiley commented on pull request #411:
URL: https://github.com/apache/lucene/pull/411#issuecomment-950427225
I spot-checked the generated Maven POMs locally. As expected and according
to the Gradle docs, these dependencies showed as optional.
I see something weird though -- this de
dsmiley opened a new pull request #411:
URL: https://github.com/apache/lucene/pull/411
https://issues.apache.org/jira/browse/LUCENE-10202
TODO on choice of naming RE spherical vs spatial3d
Note: as of this writing, the build doesn't publish the nice Gradle metadata
--
This i
[
https://issues.apache.org/jira/browse/LUCENE-10202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-10202:
--
Summary: spatial: expose dependencies using Gradle Feature Variants (was:
Expose dependencie
[
https://issues.apache.org/jira/browse/LUCENE-10202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433521#comment-17433521
]
David Smiley commented on LUCENE-10202:
---
[~daddywri] when I was working on the PR
David Smiley created LUCENE-10202:
-
Summary: Expose dependencies using Gradle Feature Variants
Key: LUCENE-10202
URL: https://issues.apache.org/jira/browse/LUCENE-10202
Project: Lucene - Core
dsmiley commented on pull request #353:
URL: https://github.com/apache/lucene/pull/353#issuecomment-950407268
I'm looking at this and seeing `gradle/maven/publications-maven.gradle` at
the bottom has:
```
tasks.withType(GenerateModuleMetadata) {
enabled = false
}
```
[
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433506#comment-17433506
]
Animesh Pandey commented on LUCENE-10197:
-
Thanks for feedback on the patch. I
[
https://issues.apache.org/jira/browse/LUCENE-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433457#comment-17433457
]
Dawid Weiss commented on LUCENE-10192:
--
Correction - the classpath element is not
[
https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reopened LUCENE-9660:
-
Reopening to provide a workaround since there is a discussion about it.
> gradle task cache should
[
https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433446#comment-17433446
]
Dawid Weiss commented on LUCENE-9809:
-
https://help.sonatype.com/repomanager2/stagin
[
https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433445#comment-17433445
]
Dawid Weiss commented on LUCENE-9660:
-
It's not broken - it's normal and consistent
[
https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433444#comment-17433444
]
Robert Muir commented on LUCENE-9660:
-
I still think my argument holds, what is the
[
https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433443#comment-17433443
]
Robert Muir commented on LUCENE-9660:
-
[~dweiss] It is pretty common when reproducin
[
https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433436#comment-17433436
]
Dawid Weiss commented on LUCENE-9660:
-
No, no. Normally tests will execute every tim
[
https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433428#comment-17433428
]
Robert Muir commented on LUCENE-9660:
-
So we should be using {{cleanTest}} always?
[
https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433426#comment-17433426
]
Dawid Weiss commented on LUCENE-9809:
-
The alternative is to create a "bundle" which
[
https://issues.apache.org/jira/browse/LUCENE-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433425#comment-17433425
]
Dawid Weiss commented on LUCENE-10192:
--
([~janhoy] - I didn't touch the smoke test
[
https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433424#comment-17433424
]
Jan Høydahl edited comment on LUCENE-9809 at 10/24/21, 11:16 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433424#comment-17433424
]
Jan Høydahl commented on LUCENE-9809:
-
I'll try the env.var approach for pw. If folk
[
https://issues.apache.org/jira/browse/LUCENE-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433423#comment-17433423
]
Dawid Weiss commented on LUCENE-10192:
--
I've pushed a commit that makes Luke a par
[
https://issues.apache.org/jira/browse/LUCENE-10200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10200:
-
Description:
This is an umbrella issue for various sub-tasks as per my e-mail [1].
[1] https://
[
https://issues.apache.org/jira/browse/LUCENE-10200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10200:
-
Description:
This is an umbrella issue for various sub-tasks as per my e-mail [1].
[1] https://
[
https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433409#comment-17433409
]
Dawid Weiss commented on LUCENE-9809:
-
> There does not seem to be any configuration
30 matches
Mail list logo
