apanimesh061 opened a new pull request #412: URL: https://github.com/apache/lucene/pull/412
# Description `UnifiedHighlighter` is not thread-safe due to the presence of setters. We can move the fields to builder so that the class becomes thread-safe. Objective is to made `UnifiedHighlighter` immutable. # Solution Add a builder that is able to set all fields of the `UnifiedHighlighter` class. # Tests ``` ./gradlew -p lucene/highlighter test ./gradlew check ``` # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [X ] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [X] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
