[ 
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433549#comment-17433549
 ] 

Animesh Pandey commented on LUCENE-10197:
-----------------------------------------

[~dsmiley] I've created a draft PR for you to look at: 
https://github.com/apache/lucene/pull/412. Please take a look whenever you get 
a chance.

I've addressed some of your previous comments.

> UnifiedHighlighter should use builders for thread-safety
> --------------------------------------------------------
>
>                 Key: LUCENE-10197
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10197
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>            Reporter: Animesh Pandey
>            Priority: Minor
>              Labels: newdev
>         Attachments: LUCENE-10197.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> UnifiedHighlighter is not thread-safe due to the presence of setters. We can 
> move the fields to builder so that the class becomes thread-safe.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to