jpountz commented on a change in pull request #361:
URL: https://github.com/apache/lucene/pull/361#discussion_r723852770
##
File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java
##
@@ -115,19 +115,23 @@ public static float squareDistance(float[] v1, float[]
v2
jpountz commented on a change in pull request #364:
URL: https://github.com/apache/lucene/pull/364#discussion_r723849356
##
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java
##
@@ -130,12 +130,45 @@ public NumericLeafComparator(LeafRea
mayya-sharipova opened a new pull request #364:
URL: https://github.com/apache/lucene/pull/364
This patch adds getPointValues to NumericLeafComparatorsimilar how it
has getNumericDocValues.
Numeric Sort optimization with points relies on the assumption that
points and doc values
[
https://issues.apache.org/jira/browse/LUCENE-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425286#comment-17425286
]
Julie Tibshirani edited comment on LUCENE-10147 at 10/7/21, 12:10 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425286#comment-17425286
]
Julie Tibshirani commented on LUCENE-10147:
---
Good idea to make the update the
jtibshirani commented on a change in pull request #361:
URL: https://github.com/apache/lucene/pull/361#discussion_r723760893
##
File path: lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java
##
@@ -204,6 +207,64 @@ public void testScore() throws IOException {
rmuir opened a new pull request #363:
URL: https://github.com/apache/lucene/pull/363
Implement the bulk `readLongs()` with view buffers, consistent with how
`readFloats()` is implemented today.
This method is important for traversing the postings lists (PFOR
decompression), and
[
https://issues.apache.org/jira/browse/LUCENE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Popitich updated LUCENE-10156:
Description:
After fix LUCENE-8343 BlendedInfixSuggester applies additional 1 / L
[
https://issues.apache.org/jira/browse/LUCENE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Popitich updated LUCENE-10156:
Description:
After fix LUCENE-8343 BlendedInfixSuggester applies additional 1 / L
Aleksandr Popitich created LUCENE-10156:
---
Summary: BlendedInfixSuggester incorrectly scores items with high
and low weights
Key: LUCENE-10156
URL: https://issues.apache.org/jira/browse/LUCENE-10156
[
https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425235#comment-17425235
]
David Smiley commented on LUCENE-9431:
--
Thanks Animesh! There was a documentation
dsmiley opened a new pull request #362:
URL: https://github.com/apache/lucene/pull/362
https://issues.apache.org/jira/browse/LUCENE-9431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
[
https://issues.apache.org/jira/browse/LUCENE-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425230#comment-17425230
]
Robert Muir commented on LUCENE-10150:
--
Sorry about above typo on the issue number
[
https://issues.apache.org/jira/browse/LUCENE-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425226#comment-17425226
]
ASF subversion and git services commented on LUCENE-10150:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-10149.
--
Resolution: Fixed
Committed in ba75dc5e6bf7e90b8c40906ba8ca7b258a5b39c0
(sorry about typo on
[
https://issues.apache.org/jira/browse/LUCENE-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425221#comment-17425221
]
Michael Sokolov commented on LUCENE-10147:
--
OK, I went with convertToScore. I
msokolov opened a new pull request #361:
URL: https://github.com/apache/lucene/pull/361
Adds VectorSimilarity.convertToScore and uses that to "normalize" scores in
vector search() function
before returning in TopDocs.scoreDocs..score
--
This is an automated message from the Apache G
[
https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425208#comment-17425208
]
Robert Muir commented on LUCENE-10149:
--
OK i investigated improving the testing, i
rmuir opened a new pull request #360:
URL: https://github.com/apache/lucene/pull/360
BaseChunkedDirectoryTestCase is an extension of BaseDirectoryTestCase
where the concrete test class instantiates with a specified chunk size.
It then tries to test boundary conditions around all the ch
Robert Muir created LUCENE-10155:
Summary: Refactor TestMultiMMap into a BaseChunkedDirectoryTestCase
Key: LUCENE-10155
URL: https://issues.apache.org/jira/browse/LUCENE-10155
Project: Lucene - Core
dweiss commented on pull request #358:
URL: https://github.com/apache/lucene/pull/358#issuecomment-937056600
Dealing with this in scripts is nightmarish... but if you do want it then
you should:
- provide the defaults (empty string) if the variable is not defined,
- modify all scripts
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425178#comment-17425178
]
Dawid Weiss commented on LUCENE-9488:
-
Hi Jan. I've added collecting changes and mav
madrob commented on pull request #358:
URL: https://github.com/apache/lucene/pull/358#issuecomment-936805007
Thanks for this patch! Can you please also update gradlew.bat?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
balmukundblr opened a new pull request #358:
URL: https://github.com/apache/lucene/pull/358
# Description
Lucene uses a custom WrapperDownloader to download the gradle-wrapper jar
file. The call is made via a script here:
https://github.com/apache/lucene/blob/main/gradlew#L1
cpoerschke commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r723514273
##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -658,97 +616,41 @@ def verifyUnpacked(java, project, artifact, unpackPath,
gitRevision, version
[
https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425102#comment-17425102
]
ASF subversion and git services commented on LUCENE-10153:
--
Co
jpountz merged pull request #357:
URL: https://github.com/apache/lucene/pull/357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425063#comment-17425063
]
ASF subversion and git services commented on LUCENE-9325:
-
Commi
romseygeek merged pull request #338:
URL: https://github.com/apache/lucene/pull/338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
romseygeek commented on a change in pull request #338:
URL: https://github.com/apache/lucene/pull/338#discussion_r72909
##
File path: lucene/CHANGES.txt
##
@@ -153,7 +153,9 @@ API Changes
* LUCENE-10115: Add an extension point, BaseQueryParser#getFuzzyDistance, to
allow c
Mayya Sharipova created LUCENE-10154:
Summary: NumericLeafComparator to define getPointValues
Key: LUCENE-10154
URL: https://issues.apache.org/jira/browse/LUCENE-10154
Project: Lucene - Core
danmuzi commented on a change in pull request #338:
URL: https://github.com/apache/lucene/pull/338#discussion_r723295887
##
File path: lucene/CHANGES.txt
##
@@ -153,7 +153,9 @@ API Changes
* LUCENE-10115: Add an extension point, BaseQueryParser#getFuzzyDistance, to
allow cust
jpountz commented on a change in pull request #357:
URL: https://github.com/apache/lucene/pull/357#discussion_r723290327
##
File path: lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java
##
@@ -694,4 +694,81 @@ public static int compareUnsigned4(byte[] a, int aOffset,
b
rmuir commented on a change in pull request #357:
URL: https://github.com/apache/lucene/pull/357#discussion_r723259603
##
File path: lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java
##
@@ -694,4 +694,81 @@ public static int compareUnsigned4(byte[] a, int aOffset,
byt
jpountz commented on a change in pull request #357:
URL: https://github.com/apache/lucene/pull/357#discussion_r723240957
##
File path: lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java
##
@@ -694,4 +694,81 @@ public static int compareUnsigned4(byte[] a, int aOffset,
b
janhoy commented on pull request #356:
URL: https://github.com/apache/lucene/pull/356#issuecomment-936116661
Thanks for the review @dweiss - one step closer to a smooth 9.0 release :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/LUCENE-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424952#comment-17424952
]
ASF subversion and git services commented on LUCENE-10152:
--
Co
janhoy merged pull request #356:
URL: https://github.com/apache/lucene/pull/356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
rmuir commented on a change in pull request #357:
URL: https://github.com/apache/lucene/pull/357#discussion_r723176939
##
File path: lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java
##
@@ -694,4 +694,81 @@ public static int compareUnsigned4(byte[] a, int aOffset,
byt
janhoy commented on pull request #356:
URL: https://github.com/apache/lucene/pull/356#issuecomment-936110866
For reference, see https://en.wikipedia.org/wiki/Md5sum where it mentions
> There must be two spaces or a space and an asterisk between each md5sum
value and filename to be compa
janhoy commented on a change in pull request #356:
URL: https://github.com/apache/lucene/pull/356#discussion_r723172070
##
File path: gradle/publishing/distribution.gradle
##
@@ -22,7 +22,7 @@ allprojects {
def checksum = {
outputs.files.each { File file -
rmuir commented on a change in pull request #357:
URL: https://github.com/apache/lucene/pull/357#discussion_r723158701
##
File path: lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java
##
@@ -694,4 +694,81 @@ public static int compareUnsigned4(byte[] a, int aOffset,
byt
dweiss commented on a change in pull request #356:
URL: https://github.com/apache/lucene/pull/356#discussion_r723143837
##
File path: gradle/publishing/distribution.gradle
##
@@ -22,7 +22,7 @@ allprojects {
def checksum = {
outputs.files.each { File file -
[
https://issues.apache.org/jira/browse/LUCENE-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424940#comment-17424940
]
Dawid Weiss commented on LUCENE-10152:
--
This missing '*' seems to be implementatio
jpountz commented on pull request #357:
URL: https://github.com/apache/lucene/pull/357#issuecomment-936016565
I like that BKDConfig today only records data (bytesPerDim, etc.) rather
than logic (how to compare byte[] arrays), so I have a bias towards keeping
things as they are today.
--
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424931#comment-17424931
]
Dawid Weiss commented on LUCENE-9488:
-
Yep. We already do some of the work pushing n
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424925#comment-17424925
]
Jan Høydahl commented on LUCENE-9488:
-
Think the ant build uses Maven Ant task to do
iverase commented on pull request #357:
URL: https://github.com/apache/lucene/pull/357#issuecomment-935961662
I am not worry about object creation but because we always call it with the
same parameter (config.bytesPerDim), it seems to belong to config.
--
This is an automated message fro
janhoy commented on a change in pull request #1435:
URL: https://github.com/apache/lucene-solr/pull/1435#discussion_r723118782
##
File path: solr/bin/install_solr_service.sh
##
@@ -229,21 +229,21 @@ if [ -z "$SOLR_UPGRADE" ]; then
fi
if [ ! "$SOLR_UPGRADE" = "YES" ]; then
-
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424919#comment-17424919
]
Dawid Weiss commented on LUCENE-9488:
-
Right. So it's the same thing as with Sonatyp
janhoy commented on pull request #1435:
URL: https://github.com/apache/lucene-solr/pull/1435#issuecomment-935942553
@andreasbolstad As you may see, this PR is rather old, and it is also
against the old git repo. So if anyone would care to bring it up to date and
make a new PR against https
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424913#comment-17424913
]
Jan Høydahl commented on LUCENE-9488:
-
The release Wizard says this:
[https://githu
iverase edited a comment on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-935900865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
iverase commented on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-935900865
> Would it be easy/cheap to know the accurate count?
Actually I think we can do it pretty cheap taking into account that now we
always build an unbalance tree and we can assume t
jpountz commented on pull request #357:
URL: https://github.com/apache/lucene/pull/357#issuecomment-93589
I agree that improved readability is a nice side-effect. I don't know if
this actually triggers object creations since we are returning references to
existing methods, do you know
jpountz commented on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-935886196
> Currently we might return a size that is bigger that the number of points.
Should we modified the method to return the exact number of points all the time
or change the contract of t
jpountz merged pull request #350:
URL: https://github.com/apache/lucene/pull/350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
jpountz commented on pull request #350:
URL: https://github.com/apache/lucene/pull/350#issuecomment-935862391
Actually there is an even simpler fix: the only long is `dvGen` which we
don't need to check since it's always -1. I'll update the PR description
accordingly.
--
This is an auto
[
https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424878#comment-17424878
]
Adrien Grand commented on LUCENE-10153:
---
I opened a PR that gives me a ~6% speedu
[
https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-10153:
--
Description: LUCENE-10145 leveraged VarHandles to speed up unsigned
comparisons of byte[4] or
jpountz opened a new pull request #357:
URL: https://github.com/apache/lucene/pull/357
See https://issues.apache.org/jira/browse/LUCENE-10153.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
iverase commented on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-935815211
I run another iteration on this patch as I was noticing that this version
was consistently slower than the current version. I think the issue was the way
we were handling adding all wh
[
https://issues.apache.org/jira/browse/LUCENE-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424862#comment-17424862
]
Jan Høydahl edited comment on LUCENE-10152 at 10/6/21, 9:14 AM:
-
janhoy opened a new pull request #356:
URL: https://github.com/apache/lucene/pull/356
https://issues.apache.org/jira/browse/LUCENE-10152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424863#comment-17424863
]
Dawid Weiss commented on LUCENE-9488:
-
I can add the assembly of these maven files t
[
https://issues.apache.org/jira/browse/LUCENE-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424862#comment-17424862
]
Jan Høydahl commented on LUCENE-10152:
--
Found a bug in the {{.sha512}} file genera
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424859#comment-17424859
]
Jan Høydahl commented on LUCENE-9488:
-
Ok, guess that will also be part of LUCENE-10
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424857#comment-17424857
]
Dawid Weiss commented on LUCENE-9488:
-
Jan, do you know the process by which maven a
andreasbolstad commented on pull request #1435:
URL: https://github.com/apache/lucene-solr/pull/1435#issuecomment-935792533
Is this going to be merged soon? I would have greatly appreciated not having
had to set up my own service file, and I think others will too.
--
This is an automated
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424853#comment-17424853
]
Dawid Weiss commented on LUCENE-9488:
-
I added this "maven-local" for just verifying
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424850#comment-17424850
]
Jan Høydahl commented on LUCENE-9488:
-
The old ant target 'prepare-release' invokes
Adrien Grand created LUCENE-10153:
-
Summary: More speedups for operations on byte[] via VarHandles
Key: LUCENE-10153
URL: https://issues.apache.org/jira/browse/LUCENE-10153
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424837#comment-17424837
]
Jan Høydahl commented on LUCENE-9997:
-
I have started on the smoketester in
[https:
janhoy opened a new pull request #355:
URL: https://github.com/apache/lucene/pull/355
https://issues.apache.org/jira/browse/LUCENE-9997
This PR mostly removes solr specific tests, but also
* Fix some python formatting, such as two LF before methods
* Initialize non-initialized v
dweiss commented on pull request #353:
URL: https://github.com/apache/lucene/pull/353#issuecomment-935660694
Thanks @janhoy !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
[
https://issues.apache.org/jira/browse/LUCENE-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424812#comment-17424812
]
Adrien Grand commented on LUCENE-10145:
---
There's also a nice ~7% speedup for box
76 matches
Mail list logo
