jpountz commented on a change in pull request #364:
URL: https://github.com/apache/lucene/pull/364#discussion_r723849356
##########
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java
##########
@@ -130,12 +130,45 @@ public NumericLeafComparator(LeafReaderContext context)
throws IOException {
}
}
- /** Retrieves the NumericDocValues for the field in this segment */
+ /**
+ * Retrieves the NumericDocValues for the field in this segment
+ *
+ * <p>If you override this method, you must also override {@link
+ * #getPointValues(LeafReaderContext, String)} This class uses sort
optimization that
+ * substitutes an iterator over doc_values with one over points, so it
relies on the assumption
Review comment:
Minor suggestion to give a higher-level description of how the
optimization works since users might not be familiar with the implementation
deltails.
```suggestion
* leverages points to filter out non-competitive matches, which relies
on the assumption
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
