rmuir commented on a change in pull request #357:
URL: https://github.com/apache/lucene/pull/357#discussion_r723176939



##########
File path: lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java
##########
@@ -694,4 +694,81 @@ public static int compareUnsigned4(byte[] a, int aOffset, 
byte[] b, int bOffset)
     return Integer.compareUnsigned(
         (int) BitUtil.VH_BE_INT.get(a, aOffset), (int) 
BitUtil.VH_BE_INT.get(b, bOffset));
   }
+
+  /**
+   * Return a comparator that computes the common prefix length across the 
next {@code numBytes} of
+   * the provided arrays.
+   */
+  public static ByteArrayComparator getPrefixLengthComparator(int numBytes) {

Review comment:
       also, wouldnt need to be public this way. the current patch explodes the 
public API and exposes a LOT of surface area on arrayutil, but it is all 
unnecessary.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to