[GitHub] [lucene-solr] jpountz commented on a change in pull request #2512: LUCENE-9976: Fix WANDScorer assertion error

jpountz commented on a change in pull request #2512: URL: https://github.com/apache/lucene-solr/pull/2512#discussion_r648889041 ## File path: lucene/CHANGES.txt ## @@ -54,7 +54,7 @@ Bug Fixes Other - -(No changes) +* LUCENE-9976: Fix WANDScorer assertion

[jira] [Commented] (LUCENE-9965) Add tooling to introspect query execution time

[ https://issues.apache.org/jira/browse/LUCENE-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360593#comment-17360593 ] ASF subversion and git services commented on LUCENE-9965: - Commi

[jira] [Commented] (LUCENE-8638) Remove deprecated code in master

[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360556#comment-17360556 ] David Smiley commented on LUCENE-8638: -- Folks, let's return to actually finish at l

[jira] [Commented] (LUCENE-9976) WANDScorer assertion error in ensureConsistent

[ https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360555#comment-17360555 ] Zach Chen commented on LUCENE-9976: --- {quote}[~zacharymorn] I believe that the same pro

[GitHub] [lucene-solr] zacharymorn opened a new pull request #2512: LUCENE-9976: Fix WANDScorer assertion error

zacharymorn opened a new pull request #2512: URL: https://github.com/apache/lucene-solr/pull/2512 Backports changes from apache/lucene#171 into branch_8x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene-solr] zacharymorn opened a new pull request #2511: LUCENE-9976: Fix WANDScorer assertion error

zacharymorn opened a new pull request #2511: URL: https://github.com/apache/lucene-solr/pull/2511 Backports changes from https://github.com/apache/lucene/pull/171 into branch_8_9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [lucene] dnhatn commented on pull request #140: LUCENE-9935: Enable bulk-merge for term vectors with index sort

dnhatn commented on pull request #140: URL: https://github.com/apache/lucene/pull/140#issuecomment-858243141 @jpountz Thanks for reviews. It's ready again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] dnhatn commented on a change in pull request #140: LUCENE-9935: Enable bulk-merge for term vectors with index sort

dnhatn commented on a change in pull request #140: URL: https://github.com/apache/lucene/pull/140#discussion_r648815760 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java ## @@ -667,43 +673,92 @@ public void testRandom() thr

[GitHub] [lucene] dnhatn commented on a change in pull request #140: LUCENE-9935: Enable bulk-merge for term vectors with index sort

dnhatn commented on a change in pull request #140: URL: https://github.com/apache/lucene/pull/140#discussion_r648815647 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsReader.java ## @@ -91,6 +91,7 @@ private fi

[jira] [Commented] (LUCENE-9204) Move span queries to the queries module

[ https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360503#comment-17360503 ] Michael Gibney commented on LUCENE-9204: Apologies for the delayed response. Thi

[jira] [Commented] (LUCENE-9983) Stop sorting determinize powersets unnecessarily

[ https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360495#comment-17360495 ] Haoyu Zhai commented on LUCENE-9983: I constructed a file with 235k words that has s

[jira] [Resolved] (LUCENE-9965) Add tooling to introspect query execution time

[ https://issues.apache.org/jira/browse/LUCENE-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani resolved LUCENE-9965. -- Fix Version/s: 8.10 Resolution: Fixed > Add tooling to introspect query executi

[jira] [Commented] (LUCENE-9965) Add tooling to introspect query execution time

[ https://issues.apache.org/jira/browse/LUCENE-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360419#comment-17360419 ] ASF subversion and git services commented on LUCENE-9965: - Commi

[jira] [Commented] (LUCENE-9965) Add tooling to introspect query execution time

[ https://issues.apache.org/jira/browse/LUCENE-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360361#comment-17360361 ] ASF subversion and git services commented on LUCENE-9965: - Commi

[jira] [Commented] (LUCENE-9965) Add tooling to introspect query execution time

[ https://issues.apache.org/jira/browse/LUCENE-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360359#comment-17360359 ] Julie Tibshirani commented on LUCENE-9965: -- The linked PR was just merged, whic

[GitHub] [lucene-solr] dsmiley opened a new pull request #2510: SolrZkClient: remove dead code

dsmiley opened a new pull request #2510: URL: https://github.com/apache/lucene-solr/pull/2510 It's impossible for the "prettyPrint" code to be reached. This has been so for 9 years. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (LUCENE-9965) Add tooling to introspect query execution time

[ https://issues.apache.org/jira/browse/LUCENE-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360347#comment-17360347 ] ASF subversion and git services commented on LUCENE-9965: - Commi

[jira] [Commented] (LUCENE-9965) Add tooling to introspect query execution time

[ https://issues.apache.org/jira/browse/LUCENE-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360341#comment-17360341 ] ASF subversion and git services commented on LUCENE-9965: - Commi

[GitHub] [lucene] jtibshirani merged pull request #144: LUCENE-9965: Add tooling to introspect query execution time

jtibshirani merged pull request #144: URL: https://github.com/apache/lucene/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [lucene] jtibshirani commented on pull request #144: LUCENE-9965: Add tooling to introspect query execution time

jtibshirani commented on pull request #144: URL: https://github.com/apache/lucene/pull/144#issuecomment-857916002 @jdconrad asked that I finish off this work as he'll be away for several weeks. I pushed a few changes: * Adjust class visibility and other small clean-ups * Fold QueryPro

[jira] [Commented] (LUCENE-9992) During merging, write empty (headers-only) numeric vectors when vector-valued FieldInfos is present

[ https://issues.apache.org/jira/browse/LUCENE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360207#comment-17360207 ] Adrien Grand commented on LUCENE-9992: -- [~sokolov] I tried to address test failures

[jira] [Commented] (LUCENE-9992) During merging, write empty (headers-only) numeric vectors when vector-valued FieldInfos is present

[ https://issues.apache.org/jira/browse/LUCENE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360205#comment-17360205 ] ASF subversion and git services commented on LUCENE-9992: - Commi

[GitHub] [lucene-solr] cholpas commented on a change in pull request #2472: SOLR-15217: Use shardsWhitelist in ReplicationHandler.

cholpas commented on a change in pull request #2472: URL: https://github.com/apache/lucene-solr/pull/2472#discussion_r648376275 ## File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java ## @@ -271,7 +274,34 @@ public IndexFetcher(@SuppressWarnings({"rawtypes"})

[jira] [Commented] (LUCENE-9995) JDK17 generates wbr tags which make javadocs checker angry

[ https://issues.apache.org/jira/browse/LUCENE-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360125#comment-17360125 ] Uwe Schindler commented on LUCENE-9995: --- I think we should backport this and also

[jira] [Commented] (LUCENE-9977) Gradle's RAT task has missing inputs, so it can't figure out when to run

[ https://issues.apache.org/jira/browse/LUCENE-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360120#comment-17360120 ] Uwe Schindler commented on LUCENE-9977: --- (y) > Gradle's RAT task has missing inpu

[jira] [Commented] (LUCENE-9977) Gradle's RAT task has missing inputs, so it can't figure out when to run

[ https://issues.apache.org/jira/browse/LUCENE-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360114#comment-17360114 ] Dawid Weiss commented on LUCENE-9977: - Just FYI - I started working on this and I th

[jira] [Comment Edited] (LUCENE-9992) During merging, write empty (headers-only) numeric vectors when vector-valued FieldInfos is present

[ https://issues.apache.org/jira/browse/LUCENE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360040#comment-17360040 ] Alan Woodward edited comment on LUCENE-9992 at 6/9/21, 12:48 PM: -

[jira] [Commented] (LUCENE-9992) During merging, write empty (headers-only) numeric vectors when vector-valued FieldInfos is present

[ https://issues.apache.org/jira/browse/LUCENE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360040#comment-17360040 ] Alan Woodward commented on LUCENE-9992: --- This looks like it's causing failures in

[GitHub] [lucene] uschindler commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

uschindler commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r648260976 ## File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java ## @@ -16,28 +16,17 @@ */ package org.apache.lucene.store; -import stat

[GitHub] [lucene] uschindler commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

uschindler commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r648259655 ## File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java ## @@ -16,28 +16,17 @@ */ package org.apache.lucene.store; -import stat

[GitHub] [lucene-solr] janhoy commented on a change in pull request #2472: SOLR-15217: Use shardsWhitelist in ReplicationHandler.

janhoy commented on a change in pull request #2472: URL: https://github.com/apache/lucene-solr/pull/2472#discussion_r648234288 ## File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java ## @@ -271,7 +274,34 @@ public IndexFetcher(@SuppressWarnings({"rawtypes"})f

[jira] [Commented] (LUCENE-9992) During merging, write empty (headers-only) numeric vectors when vector-valued FieldInfos is present

[ https://issues.apache.org/jira/browse/LUCENE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360011#comment-17360011 ] ASF subversion and git services commented on LUCENE-9992: - Commi

[GitHub] [lucene] msokolov merged pull request #172: LUCENE-9992: write empty vector fields when merging

msokolov merged pull request #172: URL: https://github.com/apache/lucene/pull/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [lucene] msokolov commented on pull request #172: LUCENE-9992: write empty vector fields when merging

msokolov commented on pull request #172: URL: https://github.com/apache/lucene/pull/172#issuecomment-857631686 @rmuir I hear you about the test coverage. It's surprising this wasn't already covered. I thought I had looked at a coverage report at some point, but that isn't perfect of course

[GitHub] [lucene-solr] cholpas commented on a change in pull request #2472: SOLR-15217: Use shardsWhitelist in ReplicationHandler.

cholpas commented on a change in pull request #2472: URL: https://github.com/apache/lucene-solr/pull/2472#discussion_r648227029 ## File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java ## @@ -271,7 +274,34 @@ public IndexFetcher(@SuppressWarnings({"rawtypes"})

[GitHub] [lucene] dweiss commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

dweiss commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r648223161 ## File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java ## @@ -16,28 +16,17 @@ */ package org.apache.lucene.store; -import static j

[GitHub] [lucene] msokolov commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

msokolov commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r648221346 ## File path: lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java ## @@ -0,0 +1,614 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [lucene] msokolov commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

msokolov commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r648219715 ## File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java ## @@ -16,28 +16,17 @@ */ package org.apache.lucene.store; -import static

[GitHub] [lucene-solr] janhoy commented on a change in pull request #2472: SOLR-15217: Use shardsWhitelist in ReplicationHandler.

janhoy commented on a change in pull request #2472: URL: https://github.com/apache/lucene-solr/pull/2472#discussion_r648218229 ## File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java ## @@ -271,7 +274,34 @@ public IndexFetcher(@SuppressWarnings({"rawtypes"})f

[GitHub] [lucene] uschindler commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

uschindler commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r648182602 ## File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java ## @@ -16,28 +16,17 @@ */ package org.apache.lucene.store; -import stat

[GitHub] [lucene] uschindler commented on a change in pull request #177: Initial rewrite of MMapDirectory for JDK-17 preview (incubating) Panama APIs (>= JDK-17-ea-b25)

uschindler commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r648181777 ## File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java ## @@ -16,28 +16,17 @@ */ package org.apache.lucene.store; -import stat

[GitHub] [lucene-solr] cholpas commented on a change in pull request #2472: SOLR-15217: Use shardsWhitelist in ReplicationHandler.

cholpas commented on a change in pull request #2472: URL: https://github.com/apache/lucene-solr/pull/2472#discussion_r648148773 ## File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java ## @@ -271,7 +274,34 @@ public IndexFetcher(@SuppressWarnings({"rawtypes"})

[jira] [Created] (LUCENE-9996) Can we improve DWPT's initial memory footprint?

Adrien Grand created LUCENE-9996: Summary: Can we improve DWPT's initial memory footprint? Key: LUCENE-9996 URL: https://issues.apache.org/jira/browse/LUCENE-9996 Project: Lucene - Core Issue

[jira] [Resolved] (LUCENE-9995) JDK17 generates wbr tags which make javadocs checker angry

[ https://issues.apache.org/jira/browse/LUCENE-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9995. - Fix Version/s: main (9.0) Resolution: Fixed > JDK17 generates wbr tags which make javadoc

[jira] [Commented] (LUCENE-9995) JDK17 generates wbr tags which make javadocs checker angry

[ https://issues.apache.org/jira/browse/LUCENE-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359873#comment-17359873 ] ASF subversion and git services commented on LUCENE-9995: - Commi

[jira] [Created] (LUCENE-9995) JDK17 generates wbr tags which make javadocs checker angry

Dawid Weiss created LUCENE-9995: --- Summary: JDK17 generates wbr tags which make javadocs checker angry Key: LUCENE-9995 URL: https://issues.apache.org/jira/browse/LUCENE-9995 Project: Lucene - Core

[jira] [Commented] (LUCENE-9976) WANDScorer assertion error in ensureConsistent

[ https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359856#comment-17359856 ] Adrien Grand commented on LUCENE-9976: -- [~zacharymorn] I believe that the same prob

[jira] [Commented] (LUCENE-9976) WANDScorer assertion error in ensureConsistent

[ https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359851#comment-17359851 ] Dawid Weiss commented on LUCENE-9976: - Thanks Zach and Adrien for tackling this. >

[GitHub] [lucene-solr] atris commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

atris commented on a change in pull request #1294: URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r648047731 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutor.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [lucene-solr] 16pierre commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

16pierre commented on a change in pull request #1294: URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r648032751 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutor.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] jpountz commented on a change in pull request #144: LUCENE-9965: Add tooling to introspect query execution time

jpountz commented on a change in pull request #144: URL: https://github.com/apache/lucene/pull/144#discussion_r648031093 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfiler.java ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Resolved] (LUCENE-9976) WANDScorer assertion error in ensureConsistent

[ https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach Chen resolved LUCENE-9976. --- Resolution: Fixed > WANDScorer assertion error in ensureConsistent > ---

[GitHub] [lucene-solr] 16pierre commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

16pierre commented on a change in pull request #1294: URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r648032751 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutor.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] 16pierre commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

16pierre commented on a change in pull request #1294: URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r648032751 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutor.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] jpountz commented on a change in pull request #144: LUCENE-9965: Add tooling to introspect query execution time

jpountz commented on a change in pull request #144: URL: https://github.com/apache/lucene/pull/144#discussion_r648030421 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/queries/profile/ProfileIndexSearcher.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache

[jira] [Assigned] (LUCENE-9976) WANDScorer assertion error in ensureConsistent

[ https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach Chen reassigned LUCENE-9976: - Assignee: Zach Chen > WANDScorer assertion error in ensureConsistent >

[jira] [Commented] (LUCENE-9976) WANDScorer assertion error in ensureConsistent

[ https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359822#comment-17359822 ] ASF subversion and git services commented on LUCENE-9976: - Commi

[jira] [Commented] (LUCENE-9976) WANDScorer assertion error in ensureConsistent

[ https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359821#comment-17359821 ] ASF subversion and git services commented on LUCENE-9976: - Commi

[GitHub] [lucene] zacharymorn merged pull request #171: LUCENE-9976: Fix WANDScorer assertion error

zacharymorn merged pull request #171: URL: https://github.com/apache/lucene/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [lucene] zacharymorn commented on pull request #171: LUCENE-9976: Fix WANDScorer assertion error

zacharymorn commented on pull request #171: URL: https://github.com/apache/lucene/pull/171#issuecomment-857446169 > Thank you! Thanks Adrien for the review and approval! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub