uschindler commented on a change in pull request #177: URL: https://github.com/apache/lucene/pull/177#discussion_r648182602
########## File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java ########## @@ -16,28 +16,17 @@ */ package org.apache.lucene.store; -import static java.lang.invoke.MethodHandles.*; -import static java.lang.invoke.MethodType.methodType; - import java.io.IOException; -import java.lang.invoke.MethodHandle; -import java.lang.reflect.Field; -import java.nio.ByteBuffer; -import java.nio.ByteOrder; -import java.nio.MappedByteBuffer; import java.nio.channels.ClosedChannelException; // javadoc @link -import java.nio.channels.FileChannel; import java.nio.channels.FileChannel.MapMode; +import java.nio.file.Files; import java.nio.file.Path; -import java.nio.file.StandardOpenOption; -import java.security.AccessController; -import java.security.PrivilegedAction; import java.util.Locale; -import java.util.Objects; import java.util.concurrent.Future; -import org.apache.lucene.store.ByteBufferGuard.BufferCleaner; +import jdk.incubator.foreign.MemorySegment; +import jdk.incubator.foreign.ResourceScope; import org.apache.lucene.util.Constants; -import org.apache.lucene.util.SuppressForbidden; +import org.apache.lucene.util.Unwrapable; Review comment: It is called "unwrapable" (I can fix the typo), because this interface is implemented by all classes that can unwrap themselves (like FilterPath can return its inner Path). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org